From 3913a6392b16dad22fa284ec9147d40591139a99 Mon Sep 17 00:00:00 2001
From: Evan Lezar <elezar@nvidia.com>
Date: Wed, 2 Apr 2025 14:13:54 +0200
Subject: [PATCH] [no-relnote] Fix QF1012: Use fmt.Fprintf(...) instead of
WriteString(fmt.Sprintf(...)) lint errors
Signed-off-by: Evan Lezar <elezar@nvidia.com>
---
cmd/nvidia-cdi-hook/cudacompat/cudacompat.go | 2 +-
cmd/nvidia-cdi-hook/update-ldcache/update-ldcache.go | 2 +-
cmd/nvidia-container-runtime-hook/hook_config_test.go | 2 +-
cmd/nvidia-ctk-installer/main.go | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/cmd/nvidia-cdi-hook/cudacompat/cudacompat.go b/cmd/nvidia-cdi-hook/cudacompat/cudacompat.go
index 0cecd6c1..fff06fec 100644
--- a/cmd/nvidia-cdi-hook/cudacompat/cudacompat.go
+++ b/cmd/nvidia-cdi-hook/cudacompat/cudacompat.go
@@ -199,7 +199,7 @@ func (m command) createLdsoconfdFile(in containerRoot, pattern string, dirs ...s
if added[dir] {
continue
}
- _, err = configFile.WriteString(fmt.Sprintf("%s\n", dir))
+ _, err = fmt.Fprintf(configFile, "%s\n", dir)
if err != nil {
return fmt.Errorf("failed to update config file: %w", err)
}
diff --git a/cmd/nvidia-cdi-hook/update-ldcache/update-ldcache.go b/cmd/nvidia-cdi-hook/update-ldcache/update-ldcache.go
index e35da8ae..4118ad9c 100644
--- a/cmd/nvidia-cdi-hook/update-ldcache/update-ldcache.go
+++ b/cmd/nvidia-cdi-hook/update-ldcache/update-ldcache.go
@@ -184,7 +184,7 @@ func (m command) createLdsoconfdFile(in containerRoot, pattern string, dirs ...s
if added[dir] {
continue
}
- _, err = configFile.WriteString(fmt.Sprintf("%s\n", dir))
+ _, err = fmt.Fprintf(configFile, "%s\n", dir)
if err != nil {
return fmt.Errorf("failed to update config file: %w", err)
}
diff --git a/cmd/nvidia-container-runtime-hook/hook_config_test.go b/cmd/nvidia-container-runtime-hook/hook_config_test.go
index ade45d27..19147ecf 100644
--- a/cmd/nvidia-container-runtime-hook/hook_config_test.go
+++ b/cmd/nvidia-container-runtime-hook/hook_config_test.go
@@ -85,7 +85,7 @@ func TestGetHookConfig(t *testing.T) {
configflag = &filename
for _, line := range tc.lines {
- _, err := configFile.WriteString(fmt.Sprintf("%s\n", line))
+ _, err := fmt.Fprintf(configFile, "%s\n", line)
require.NoError(t, err)
}
}
diff --git a/cmd/nvidia-ctk-installer/main.go b/cmd/nvidia-ctk-installer/main.go
index fce109aa..fa1dabad 100644
--- a/cmd/nvidia-ctk-installer/main.go
+++ b/cmd/nvidia-ctk-installer/main.go
@@ -240,7 +240,7 @@ func (a *app) initialize(pidFile string) error {
return fmt.Errorf("unable to get flock on pidfile: %v", err)
}
- _, err = f.WriteString(fmt.Sprintf("%v\n", os.Getpid()))
+ _, err = fmt.Fprintf(f, "%v\n", os.Getpid())
if err != nil {
return fmt.Errorf("unable to write PID to pidfile: %v", err)
}