Add config search paths option to driver root.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
This commit is contained in:
Evan Lezar 2023-11-24 16:45:19 +01:00
parent 643b89e539
commit 2a9e3537ec
5 changed files with 34 additions and 2 deletions

View File

@ -53,6 +53,7 @@ type options struct {
vendor string vendor string
class string class string
configSearchPaths cli.StringSlice
librarySearchPaths cli.StringSlice librarySearchPaths cli.StringSlice
csv struct { csv struct {
@ -86,6 +87,11 @@ func (m command) build() *cli.Command {
} }
c.Flags = []cli.Flag{ c.Flags = []cli.Flag{
&cli.StringSliceFlag{
Name: "config-search-path",
Usage: "Specify the path to search for config files when discovering the entities that should be included in the CDI specification.",
Destination: &opts.configSearchPaths,
},
&cli.StringFlag{ &cli.StringFlag{
Name: "output", Name: "output",
Usage: "Specify the file to output the generated CDI specification to. If this is '' the specification is output to STDOUT", Usage: "Specify the file to output the generated CDI specification to. If this is '' the specification is output to STDOUT",
@ -260,6 +266,7 @@ func (m command) generateSpec(opts *options) (spec.Interface, error) {
nvcdi.WithLdconfigPath(opts.ldconfigPath), nvcdi.WithLdconfigPath(opts.ldconfigPath),
nvcdi.WithDeviceNamers(deviceNamers...), nvcdi.WithDeviceNamers(deviceNamers...),
nvcdi.WithMode(opts.mode), nvcdi.WithMode(opts.mode),
nvcdi.WithConfigSearchPaths(opts.configSearchPaths.Value()),
nvcdi.WithLibrarySearchPaths(opts.librarySearchPaths.Value()), nvcdi.WithLibrarySearchPaths(opts.librarySearchPaths.Value()),
nvcdi.WithCSVFiles(opts.csv.files.Value()), nvcdi.WithCSVFiles(opts.csv.files.Value()),
nvcdi.WithCSVIgnorePatterns(opts.csv.ignorePatterns.Value()), nvcdi.WithCSVIgnorePatterns(opts.csv.ignorePatterns.Value()),

View File

@ -37,3 +37,9 @@ func WithLibrarySearchPaths(paths ...string) Option {
d.librarySearchPaths = paths d.librarySearchPaths = paths
} }
} }
func WithConfigSearchPaths(paths ...string) Option {
return func(d *Driver) {
d.configSearchPaths = paths
}
}

View File

@ -30,6 +30,8 @@ type Driver struct {
Root string Root string
// librarySearchPaths specifies explicit search paths for discovering libraries. // librarySearchPaths specifies explicit search paths for discovering libraries.
librarySearchPaths []string librarySearchPaths []string
// configSearchPaths specified explicit search paths for discovering driver config files.
configSearchPaths []string
} }
// New creates a new Driver root using the specified options. // New creates a new Driver root using the specified options.
@ -54,11 +56,20 @@ func (r *Driver) Libraries() lookup.Locator {
} }
// Configs returns a locator for driver configs. // Configs returns a locator for driver configs.
// If configSearchPaths is specified, these paths are used as absolute paths,
// otherwise, /etc and /usr/share are searched.
func (r *Driver) Configs() lookup.Locator { func (r *Driver) Configs() lookup.Locator {
searchRoot := r.Root
searchPaths := []string{"/etc", "/usr/share"}
if len(r.configSearchPaths) > 0 {
searchRoot = "/"
searchPaths = normalizeSearchPaths(r.configSearchPaths...)
}
return lookup.NewFileLocator( return lookup.NewFileLocator(
lookup.WithLogger(r.logger), lookup.WithLogger(r.logger),
lookup.WithRoot(r.Root), lookup.WithRoot(searchRoot),
lookup.WithSearchPaths("/etc", "/usr/share"), lookup.WithSearchPaths(searchPaths...),
) )
} }

View File

@ -50,6 +50,7 @@ type nvcdilib struct {
devRoot string devRoot string
nvidiaCTKPath string nvidiaCTKPath string
ldconfigPath string ldconfigPath string
configSearchPaths []string
librarySearchPaths []string librarySearchPaths []string
csvFiles []string csvFiles []string

View File

@ -126,6 +126,13 @@ func WithCSVIgnorePatterns(csvIgnorePatterns []string) Option {
} }
} }
// WithConfigSearchPaths sets the search paths for config files.
func WithConfigSearchPaths(paths []string) Option {
return func(o *nvcdilib) {
o.configSearchPaths = paths
}
}
// WithLibrarySearchPaths sets the library search paths. // WithLibrarySearchPaths sets the library search paths.
// This is currently only used for CSV-mode. // This is currently only used for CSV-mode.
func WithLibrarySearchPaths(paths []string) Option { func WithLibrarySearchPaths(paths []string) Option {