2022-06-20 15:03:02 +00:00
|
|
|
/**
|
|
|
|
# Copyright (c) 2022, NVIDIA CORPORATION. All rights reserved.
|
|
|
|
#
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
#
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
#
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
# limitations under the License.
|
|
|
|
**/
|
|
|
|
|
|
|
|
package modifier
|
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
2023-03-23 18:18:22 +00:00
|
|
|
"strings"
|
2022-06-20 15:03:02 +00:00
|
|
|
|
|
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/config"
|
|
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/config/image"
|
2023-03-22 12:27:43 +00:00
|
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/logger"
|
2023-06-22 12:45:25 +00:00
|
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/modifier/cdi"
|
2022-06-20 15:03:02 +00:00
|
|
|
"github.com/NVIDIA/nvidia-container-toolkit/internal/oci"
|
2023-06-22 12:45:25 +00:00
|
|
|
"github.com/container-orchestrated-devices/container-device-interface/pkg/parser"
|
2022-06-20 15:03:02 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
// NewCDIModifier creates an OCI spec modifier that determines the modifications to make based on the
|
2023-08-25 14:14:06 +00:00
|
|
|
// CDI specifications available on the system. The NVIDIA_VISIBLE_DEVICES environment variable is
|
2022-06-20 15:03:02 +00:00
|
|
|
// used to select the devices to include.
|
2023-03-22 12:27:43 +00:00
|
|
|
func NewCDIModifier(logger logger.Interface, cfg *config.Config, ociSpec oci.Spec) (oci.SpecModifier, error) {
|
2023-03-09 09:15:34 +00:00
|
|
|
devices, err := getDevicesFromSpec(logger, ociSpec, cfg)
|
2022-06-22 08:08:52 +00:00
|
|
|
if err != nil {
|
|
|
|
return nil, fmt.Errorf("failed to get required devices from OCI specification: %v", err)
|
|
|
|
}
|
|
|
|
if len(devices) == 0 {
|
|
|
|
logger.Debugf("No devices requested; no modification required.")
|
|
|
|
return nil, nil
|
|
|
|
}
|
2023-03-06 11:40:21 +00:00
|
|
|
logger.Debugf("Creating CDI modifier for devices: %v", devices)
|
2022-06-22 08:08:52 +00:00
|
|
|
|
2023-06-22 12:45:25 +00:00
|
|
|
return cdi.New(
|
|
|
|
cdi.WithLogger(logger),
|
|
|
|
cdi.WithDevices(devices...),
|
|
|
|
cdi.WithSpecDirs(cfg.NVIDIAContainerRuntimeConfig.Modes.CDI.SpecDirs...),
|
|
|
|
)
|
2022-06-22 08:08:52 +00:00
|
|
|
}
|
|
|
|
|
2023-03-22 12:27:43 +00:00
|
|
|
func getDevicesFromSpec(logger logger.Interface, ociSpec oci.Spec, cfg *config.Config) ([]string, error) {
|
2022-06-20 15:03:02 +00:00
|
|
|
rawSpec, err := ociSpec.Load()
|
|
|
|
if err != nil {
|
|
|
|
return nil, fmt.Errorf("failed to load OCI spec: %v", err)
|
|
|
|
}
|
|
|
|
|
2023-03-23 18:18:22 +00:00
|
|
|
annotationDevices, err := getAnnotationDevices(cfg.NVIDIAContainerRuntimeConfig.Modes.CDI.AnnotationPrefixes, rawSpec.Annotations)
|
2022-06-22 08:08:52 +00:00
|
|
|
if err != nil {
|
|
|
|
return nil, fmt.Errorf("failed to parse container annotations: %v", err)
|
2022-06-20 15:03:02 +00:00
|
|
|
}
|
2023-03-06 11:40:21 +00:00
|
|
|
if len(annotationDevices) > 0 {
|
|
|
|
return annotationDevices, nil
|
|
|
|
}
|
2022-06-20 15:03:02 +00:00
|
|
|
|
2023-03-09 09:15:34 +00:00
|
|
|
container, err := image.NewCUDAImageFromSpec(rawSpec)
|
2023-03-06 11:40:21 +00:00
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
2022-06-20 15:03:02 +00:00
|
|
|
}
|
2023-03-09 09:15:34 +00:00
|
|
|
envDevices := container.DevicesFromEnvvars(visibleDevicesEnvvar)
|
2022-06-20 15:03:02 +00:00
|
|
|
|
2022-06-22 08:08:52 +00:00
|
|
|
var devices []string
|
2023-03-06 11:40:21 +00:00
|
|
|
seen := make(map[string]bool)
|
|
|
|
for _, name := range envDevices.List() {
|
2023-06-22 12:45:25 +00:00
|
|
|
if !parser.IsQualifiedName(name) {
|
2023-03-09 09:15:34 +00:00
|
|
|
name = fmt.Sprintf("%s=%s", cfg.NVIDIAContainerRuntimeConfig.Modes.CDI.DefaultKind, name)
|
2023-03-06 11:40:21 +00:00
|
|
|
}
|
|
|
|
if seen[name] {
|
|
|
|
logger.Debugf("Ignoring duplicate device %q", name)
|
|
|
|
continue
|
|
|
|
}
|
2022-06-22 08:08:52 +00:00
|
|
|
devices = append(devices, name)
|
2022-06-20 15:03:02 +00:00
|
|
|
}
|
|
|
|
|
2023-03-09 09:15:34 +00:00
|
|
|
if len(devices) == 0 {
|
|
|
|
return nil, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
if cfg.AcceptEnvvarUnprivileged || image.IsPrivileged(rawSpec) {
|
|
|
|
return devices, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
logger.Warningf("Ignoring devices specified in NVIDIA_VISIBLE_DEVICES: %v", devices)
|
|
|
|
|
2023-03-10 21:11:29 +00:00
|
|
|
return nil, nil
|
2022-06-20 15:03:02 +00:00
|
|
|
}
|
|
|
|
|
2023-03-23 18:18:22 +00:00
|
|
|
// getAnnotationDevices returns a list of devices specified in the annotations.
|
|
|
|
// Keys starting with the specified prefixes are considered and expected to contain a comma-separated list of
|
|
|
|
// fully-qualified CDI devices names. If any device name is not fully-quality an error is returned.
|
|
|
|
// The list of returned devices is deduplicated.
|
|
|
|
func getAnnotationDevices(prefixes []string, annotations map[string]string) ([]string, error) {
|
|
|
|
devicesByKey := make(map[string][]string)
|
|
|
|
for key, value := range annotations {
|
|
|
|
for _, prefix := range prefixes {
|
|
|
|
if strings.HasPrefix(key, prefix) {
|
|
|
|
devicesByKey[key] = strings.Split(value, ",")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
seen := make(map[string]bool)
|
|
|
|
var annotationDevices []string
|
|
|
|
for key, devices := range devicesByKey {
|
|
|
|
for _, device := range devices {
|
2023-06-22 12:45:25 +00:00
|
|
|
if !parser.IsQualifiedName(device) {
|
2023-03-23 18:18:22 +00:00
|
|
|
return nil, fmt.Errorf("invalid device name %q in annotation %q", device, key)
|
|
|
|
}
|
|
|
|
if seen[device] {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
annotationDevices = append(annotationDevices, device)
|
|
|
|
seen[device] = true
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return annotationDevices, nil
|
|
|
|
}
|