refactor(frontend): optimize useDialogs logic

This commit is contained in:
yassinedorbozgithub 2025-02-09 01:45:35 +01:00
parent 90a7c55646
commit f4a438b9dd
19 changed files with 19 additions and 83 deletions

View File

@ -32,7 +32,6 @@ export const AttachmentForm: FC<ComponentFormProps<AttachmentFormData>> = ({
return ( return (
<Wrapper <Wrapper
open={!!WrapperProps?.open}
onSubmit={() => { onSubmit={() => {
data?.onChange?.(selected); data?.onChange?.(selected);
rest.onSuccess?.(); rest.onSuccess?.();

View File

@ -98,11 +98,7 @@ export const MenuForm: FC<ComponentFormProps<MenuFormData>> = ({
}, [reset, data?.row]); }, [reset, data?.row]);
return ( return (
<Wrapper <Wrapper onSubmit={handleSubmit(onSubmitForm)} {...WrapperProps}>
open={!!WrapperProps?.open}
onSubmit={handleSubmit(onSubmitForm)}
{...WrapperProps}
>
<form onSubmit={handleSubmit(onSubmitForm)}> <form onSubmit={handleSubmit(onSubmitForm)}>
<ContentContainer> <ContentContainer>
<ContentContainer flexDirection="row"> <ContentContainer flexDirection="row">

View File

@ -71,11 +71,7 @@ export const CategoryForm: FC<ComponentFormProps<ICategory>> = ({
}, [data, reset]); }, [data, reset]);
return ( return (
<Wrapper <Wrapper onSubmit={handleSubmit(onSubmitForm)} {...WrapperProps}>
open={!!WrapperProps?.open}
onSubmit={handleSubmit(onSubmitForm)}
{...WrapperProps}
>
<form onSubmit={handleSubmit(onSubmitForm)}> <form onSubmit={handleSubmit(onSubmitForm)}>
<ContentContainer> <ContentContainer>
<ContentItem> <ContentItem>
@ -93,5 +89,3 @@ export const CategoryForm: FC<ComponentFormProps<ICategory>> = ({
</Wrapper> </Wrapper>
); );
}; };
CategoryForm.displayName = "CategoryForm";

View File

@ -106,11 +106,7 @@ export const ContentTypeForm: FC<ComponentFormProps<IContentType>> = ({
}, [data, reset]); }, [data, reset]);
return ( return (
<Wrapper <Wrapper onSubmit={handleSubmit(onSubmitForm)} {...WrapperProps}>
open={!!WrapperProps?.open}
onSubmit={handleSubmit(onSubmitForm)}
{...WrapperProps}
>
<form onSubmit={handleSubmit(onSubmitForm)}> <form onSubmit={handleSubmit(onSubmitForm)}>
<ContentContainer> <ContentContainer>
<ContentItem> <ContentItem>

View File

@ -203,11 +203,7 @@ export const ContentForm: FC<ComponentFormProps<ContentFormData>> = ({
}, [content, reset]); }, [content, reset]);
return ( return (
<Wrapper <Wrapper onSubmit={handleSubmit(onSubmitForm)} {...WrapperProps}>
open={!!WrapperProps?.open}
onSubmit={handleSubmit(onSubmitForm)}
{...WrapperProps}
>
<form onSubmit={handleSubmit(onSubmitForm)}> <form onSubmit={handleSubmit(onSubmitForm)}>
<ContentContainer> <ContentContainer>
{(contentType?.fields || []).map((contentField, index) => ( {(contentType?.fields || []).map((contentField, index) => (

View File

@ -53,7 +53,6 @@ export const ContentImportForm: FC<
return ( return (
<Wrapper <Wrapper
open={!!WrapperProps?.open}
onSubmit={handleImportClick} onSubmit={handleImportClick}
{...WrapperProps} {...WrapperProps}
confirmButtonProps={{ confirmButtonProps={{

View File

@ -93,11 +93,7 @@ export const ContextVarForm: FC<ComponentFormProps<IContextVar>> = ({
}, [data, reset]); }, [data, reset]);
return ( return (
<Wrapper <Wrapper onSubmit={handleSubmit(onSubmitForm)} {...WrapperProps}>
open={!!WrapperProps?.open}
onSubmit={handleSubmit(onSubmitForm)}
{...WrapperProps}
>
<form onSubmit={handleSubmit(onSubmitForm)}> <form onSubmit={handleSubmit(onSubmitForm)}>
<ContentContainer> <ContentContainer>
<ContentItem> <ContentItem>

View File

@ -81,11 +81,7 @@ export const LabelForm: FC<ComponentFormProps<ILabel>> = ({
}, [data, reset]); }, [data, reset]);
return ( return (
<Wrapper <Wrapper onSubmit={handleSubmit(onSubmitForm)} {...WrapperProps}>
open={!!WrapperProps?.open}
onSubmit={handleSubmit(onSubmitForm)}
{...WrapperProps}
>
<form onSubmit={handleSubmit(onSubmitForm)}> <form onSubmit={handleSubmit(onSubmitForm)}>
<ContentContainer> <ContentContainer>
<ContentItem> <ContentItem>

View File

@ -82,11 +82,7 @@ export const LanguageForm: FC<ComponentFormProps<ILanguage>> = ({
}, [data, reset]); }, [data, reset]);
return ( return (
<Wrapper <Wrapper onSubmit={handleSubmit(onSubmitForm)} {...WrapperProps}>
open={!!WrapperProps?.open}
onSubmit={handleSubmit(onSubmitForm)}
{...WrapperProps}
>
<form onSubmit={handleSubmit(onSubmitForm)}> <form onSubmit={handleSubmit(onSubmitForm)}>
<ContentContainer> <ContentContainer>
<ContentItem> <ContentItem>

View File

@ -89,11 +89,7 @@ export const NlpEntityVarForm: FC<ComponentFormProps<INlpEntity>> = ({
}, [data, reset]); }, [data, reset]);
return ( return (
<Wrapper <Wrapper onSubmit={handleSubmit(onSubmitForm)} {...WrapperProps}>
open={!!WrapperProps?.open}
onSubmit={handleSubmit(onSubmitForm)}
{...WrapperProps}
>
<form onSubmit={handleSubmit(onSubmitForm)}> <form onSubmit={handleSubmit(onSubmitForm)}>
<ContentContainer> <ContentContainer>
{!data ? ( {!data ? (

View File

@ -62,13 +62,8 @@ export const NlpSampleForm: FC<ComponentFormProps<INlpDatasetSample>> = ({
}; };
return ( return (
<Wrapper open={!!WrapperProps?.open} onSubmit={() => {}} {...WrapperProps}> <Wrapper onSubmit={() => {}} {...WrapperProps}>
<form> <NlpDatasetSample sample={data || undefined} submitForm={onSubmitForm} />
<NlpDatasetSample
sample={data || undefined}
submitForm={onSubmitForm}
/>
</form>
</Wrapper> </Wrapper>
); );
}; };

View File

@ -91,11 +91,7 @@ export const NlpValueForm: FC<
}, [data, reset]); }, [data, reset]);
return ( return (
<Wrapper <Wrapper onSubmit={handleSubmit(onSubmitForm)} {...WrapperProps}>
open={!!WrapperProps?.open}
onSubmit={handleSubmit(onSubmitForm)}
{...WrapperProps}
>
<form onSubmit={handleSubmit(onSubmitForm)}> <form onSubmit={handleSubmit(onSubmitForm)}>
<ContentContainer> <ContentContainer>
<ContentItem> <ContentItem>

View File

@ -117,7 +117,7 @@ export const PermissionsBody: FC<ComponentFormProps<IRole>> = ({
}, [models]); }, [models]);
return ( return (
<Wrapper open={!!WrapperProps?.open} onSubmit={() => {}} {...WrapperProps}> <Wrapper onSubmit={() => {}} {...WrapperProps}>
<Typography fontWeight={700} sx={{ marginBottom: 2 }}> <Typography fontWeight={700} sx={{ marginBottom: 2 }}>
{role?.name} {role?.name}
</Typography> </Typography>

View File

@ -70,11 +70,7 @@ export const RoleForm: FC<ComponentFormProps<IRole>> = ({
}, [data, reset]); }, [data, reset]);
return ( return (
<Wrapper <Wrapper onSubmit={handleSubmit(onSubmitForm)} {...WrapperProps}>
open={!!WrapperProps?.open}
onSubmit={handleSubmit(onSubmitForm)}
{...WrapperProps}
>
<form onSubmit={handleSubmit(onSubmitForm)}> <form onSubmit={handleSubmit(onSubmitForm)}>
<ContentContainer> <ContentContainer>
<ContentItem> <ContentItem>

View File

@ -61,11 +61,7 @@ export const SubscriberForm: FC<ComponentFormProps<ISubscriber>> = ({
}, [data, reset]); }, [data, reset]);
return ( return (
<Wrapper <Wrapper onSubmit={handleSubmit(onSubmitForm)} {...WrapperProps}>
open={!!WrapperProps?.open}
onSubmit={handleSubmit(onSubmitForm)}
{...WrapperProps}
>
<form onSubmit={handleSubmit(onSubmitForm)}> <form onSubmit={handleSubmit(onSubmitForm)}>
<ContentContainer> <ContentContainer>
<ContentItem> <ContentItem>

View File

@ -82,11 +82,7 @@ export const TranslationForm: FC<ComponentFormProps<ITranslation>> = ({
}; };
return ( return (
<Wrapper <Wrapper onSubmit={handleSubmit(onSubmitForm)} {...WrapperProps}>
open={!!WrapperProps?.open}
onSubmit={handleSubmit(onSubmitForm)}
{...WrapperProps}
>
<form onSubmit={handleSubmit(onSubmitForm)}> <form onSubmit={handleSubmit(onSubmitForm)}>
<ContentItem> <ContentItem>
<FormLabel>{t("label.original_text")}</FormLabel> <FormLabel>{t("label.original_text")}</FormLabel>

View File

@ -74,11 +74,7 @@ export const EditUserForm: FC<ComponentFormProps<EditUserFormData>> = ({
}, [reset, data?.user]); }, [reset, data?.user]);
return ( return (
<Wrapper <Wrapper onSubmit={handleSubmit(onSubmitForm)} {...WrapperProps}>
open={!!WrapperProps?.open}
onSubmit={handleSubmit(onSubmitForm)}
{...WrapperProps}
>
<form onSubmit={handleSubmit(onSubmitForm)}> <form onSubmit={handleSubmit(onSubmitForm)}>
<ContentContainer> <ContentContainer>
<ContentItem> <ContentItem>

View File

@ -62,11 +62,7 @@ export const InviteUserForm: FC<ComponentFormProps<undefined>> = ({
sendInvitation(params); sendInvitation(params);
return ( return (
<Wrapper <Wrapper onSubmit={handleSubmit(onSubmitForm)} {...WrapperProps}>
open={!!WrapperProps?.open}
onSubmit={handleSubmit(onSubmitForm)}
{...WrapperProps}
>
<form onSubmit={handleSubmit(onSubmitForm)}> <form onSubmit={handleSubmit(onSubmitForm)}>
<ContentContainer> <ContentContainer>
<ContentItem> <ContentItem>

View File

@ -151,8 +151,9 @@ export interface DialogProviderProps {
// form dialog // form dialog
export interface FormDialogProps export interface FormDialogProps
extends FormButtonsProps, extends FormButtonsProps,
Omit<MuiDialogProps, "onSubmit">, Omit<MuiDialogProps, "onSubmit" | "open">,
DialogExtraOptions { DialogExtraOptions {
open?: boolean;
title?: string; title?: string;
children?: React.ReactNode; children?: React.ReactNode;
} }