fix: apply feedback updates

This commit is contained in:
yassinedorbozgithub 2025-01-29 08:14:46 +01:00
parent 049ffb7f50
commit dab65b46a9

View File

@ -41,13 +41,11 @@ export function useBroadcastChannel<T extends BroadcastChannelData = string>(
handleMessage?: (event: MessageEvent) => void, handleMessage?: (event: MessageEvent) => void,
handleMessageError?: (event: MessageEvent) => void, handleMessageError?: (event: MessageEvent) => void,
): (data: T) => void { ): (data: T) => void {
const channelRef = React.useRef<BroadcastChannel | null>(null); const channelRef = React.useRef<BroadcastChannel | null>(
typeof window !== "undefined" && "BroadcastChannel" in window
React.useEffect(() => { ? new BroadcastChannel(channelName + "-channel")
if (typeof window !== "undefined" && "BroadcastChannel" in window) { : null,
channelRef.current = new BroadcastChannel(channelName + "-channel"); );
}
}, [channelName]);
useChannelEventListener(channelRef.current, "message", handleMessage); useChannelEventListener(channelRef.current, "message", handleMessage);
useChannelEventListener( useChannelEventListener(
@ -56,10 +54,7 @@ export function useBroadcastChannel<T extends BroadcastChannelData = string>(
handleMessageError, handleMessageError,
); );
return React.useCallback( return (data: T) => channelRef.current?.postMessage(data);
(data: T) => channelRef.current?.postMessage(data),
[channelRef.current],
);
} }
/** /**