From ccd929062375ec0079606a8d610a4ff0b759d156 Mon Sep 17 00:00:00 2001
From: yassinedorbozgithub <yassine.dorboz.2022@gmail.com>
Date: Sat, 12 Apr 2025 05:17:03 +0100
Subject: [PATCH] fix: apply feedback updates

---
 .../src/components/nlp/components/NlpValueForm.tsx     | 10 +++++++++-
 .../components/nlp/components/NlpValueFormDialog.tsx   |  1 +
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/frontend/src/components/nlp/components/NlpValueForm.tsx b/frontend/src/components/nlp/components/NlpValueForm.tsx
index a2094294..a20af55f 100644
--- a/frontend/src/components/nlp/components/NlpValueForm.tsx
+++ b/frontend/src/components/nlp/components/NlpValueForm.tsx
@@ -66,7 +66,13 @@ export const NlpValueForm: FC<ComponentFormProps<NlpValueFormProps>> = ({
       toast.success(t("message.success_save"));
     },
   });
-  const { reset, register, handleSubmit, control } = useForm<
+  const {
+    reset,
+    register,
+    handleSubmit,
+    control,
+    formState: { errors },
+  } = useForm<
     INlpValueAttributes & {
       expressions: string[];
     }
@@ -111,8 +117,10 @@ export const NlpValueForm: FC<ComponentFormProps<NlpValueFormProps>> = ({
           <ContentItem>
             <Input
               label={t("placeholder.nlp_value")}
+              error={!!errors.value}
               required
               autoFocus
+              helperText={errors.value ? errors.value.message : null}
               {...register("value", validationRules.value)}
             />
           </ContentItem>
diff --git a/frontend/src/components/nlp/components/NlpValueFormDialog.tsx b/frontend/src/components/nlp/components/NlpValueFormDialog.tsx
index dbc8c75e..491db2e2 100644
--- a/frontend/src/components/nlp/components/NlpValueFormDialog.tsx
+++ b/frontend/src/components/nlp/components/NlpValueFormDialog.tsx
@@ -18,6 +18,7 @@ export const NlpValueFormDialog = <
 ) => (
   <GenericFormDialog<T>
     Form={NlpValueForm}
+    rowKey="defaultValues"
     addText="title.new_nlp_entity_value"
     editText="title.edit_nlp_value"
     {...props}