From cde4a36294b1b552685a3903cb9dee6bb56c8728 Mon Sep 17 00:00:00 2001 From: yassinedorbozgithub Date: Tue, 3 Dec 2024 17:16:57 +0100 Subject: [PATCH 1/6] Refactor: merge find findPage - findAndPopulate findPageAndPopulate --- api/src/chat/controllers/block.controller.ts | 9 ++------ .../chat/controllers/category.controller.ts | 6 +---- .../context-var.controller.spec.ts | 6 ++--- .../controllers/context-var.controller.ts | 6 +---- .../chat/controllers/label.controller.spec.ts | 11 ++++----- api/src/chat/controllers/label.controller.ts | 10 ++------ .../controllers/message.controller.spec.ts | 8 +++---- .../chat/controllers/message.controller.ts | 10 ++------ .../controllers/subscriber.controller.spec.ts | 14 +++++------ .../chat/controllers/subscriber.controller.ts | 10 ++------ .../content-type.controller.spec.ts | 4 ++-- .../controllers/content-type.controller.ts | 6 +---- api/src/cms/controllers/content.controller.ts | 9 ++------ api/src/cms/controllers/menu.controller.ts | 6 +---- .../controllers/language.controller.spec.ts | 4 ++-- .../i18n/controllers/language.controller.ts | 6 +---- .../translation.controller.spec.ts | 4 ++-- .../controllers/translation.controller.ts | 5 +--- .../nlp/controllers/nlp-entity.controller.ts | 10 ++------ .../nlp/controllers/nlp-sample.controller.ts | 10 ++------ .../nlp/controllers/nlp-value.controller.ts | 10 ++------ .../controllers/setting.controller.spec.ts | 2 ++ .../setting/controllers/setting.controller.ts | 6 ++--- .../controllers/permission.controller.spec.ts | 6 ++--- .../user/controllers/role.controller.spec.ts | 13 ++++------- api/src/user/controllers/role.controller.ts | 10 ++------ api/src/user/controllers/user.controller.ts | 10 ++------ api/src/utils/generics/base-repository.ts | 23 ++++++++++--------- api/src/utils/generics/base-service.ts | 11 +++++---- 29 files changed, 82 insertions(+), 163 deletions(-) diff --git a/api/src/chat/controllers/block.controller.ts b/api/src/chat/controllers/block.controller.ts index 3cc9dc9b..945032f6 100644 --- a/api/src/chat/controllers/block.controller.ts +++ b/api/src/chat/controllers/block.controller.ts @@ -80,14 +80,9 @@ export class BlockController extends BaseController< filters: TFilterQuery, @Query(PageQueryPipe) pageQuery?: PageQueryDto, ): Promise { - if (pageQuery?.limit) { - return this.canPopulate(populate) - ? await this.blockService.findPageAndPopulate(filters, pageQuery) - : await this.blockService.findPage(filters, pageQuery); - } return this.canPopulate(populate) - ? await this.blockService.findAndPopulate(filters, pageQuery?.sort) - : await this.blockService.find(filters, pageQuery?.sort); + ? await this.blockService.findAndPopulate(filters, pageQuery) + : await this.blockService.find(filters, pageQuery); } /** diff --git a/api/src/chat/controllers/category.controller.ts b/api/src/chat/controllers/category.controller.ts index ff4c322a..16a54473 100644 --- a/api/src/chat/controllers/category.controller.ts +++ b/api/src/chat/controllers/category.controller.ts @@ -57,11 +57,7 @@ export class CategoryController extends BaseController { @Query(new SearchFilterPipe({ allowedFields: ['label'] })) filters: TFilterQuery, ) { - if (pageQuery.limit) { - return await this.categoryService.findPage(filters, pageQuery); - } - - return await this.categoryService.find(filters, pageQuery.sort); + return await this.categoryService.find(filters, pageQuery); } /** diff --git a/api/src/chat/controllers/context-var.controller.spec.ts b/api/src/chat/controllers/context-var.controller.spec.ts index a42ef037..6098ac05 100644 --- a/api/src/chat/controllers/context-var.controller.spec.ts +++ b/api/src/chat/controllers/context-var.controller.spec.ts @@ -28,7 +28,7 @@ import { ContextVarUpdateDto, } from '../dto/context-var.dto'; import { ContextVarRepository } from '../repositories/context-var.repository'; -import { ContextVarModel, ContextVar } from '../schemas/context-var.schema'; +import { ContextVar, ContextVarModel } from '../schemas/context-var.schema'; import { ContextVarService } from '../services/context-var.service'; import { ContextVarController } from './context-var.controller'; @@ -80,10 +80,10 @@ describe('ContextVarController', () => { describe('findPage', () => { it('should return an array of contextVars', async () => { const pageQuery = getPageQuery(); - jest.spyOn(contextVarService, 'findPage'); + jest.spyOn(contextVarService, 'find'); const result = await contextVarController.findPage(pageQuery, {}); - expect(contextVarService.findPage).toHaveBeenCalledWith({}, pageQuery); + expect(contextVarService.find).toHaveBeenCalledWith({}, pageQuery); expect(result).toEqualPayload(contextVarFixtures.sort(sortRowsBy)); }); }); diff --git a/api/src/chat/controllers/context-var.controller.ts b/api/src/chat/controllers/context-var.controller.ts index f03358e2..c9234d92 100644 --- a/api/src/chat/controllers/context-var.controller.ts +++ b/api/src/chat/controllers/context-var.controller.ts @@ -60,11 +60,7 @@ export class ContextVarController extends BaseController { @Query(new SearchFilterPipe({ allowedFields: ['label'] })) filters: TFilterQuery, ): Promise { - if (pageQuery.limit) { - return await this.contextVarService.findPage(filters, pageQuery); - } - - return await this.contextVarService.find(filters, pageQuery.sort); + return await this.contextVarService.find(filters, pageQuery); } /** diff --git a/api/src/chat/controllers/label.controller.spec.ts b/api/src/chat/controllers/label.controller.spec.ts index 7eb51ae0..7d8e0b21 100644 --- a/api/src/chat/controllers/label.controller.spec.ts +++ b/api/src/chat/controllers/label.controller.spec.ts @@ -104,13 +104,13 @@ describe('LabelController', () => { describe('findPage', () => { const pageQuery = getPageQuery