UniqAI/hexabot
1
0
Fork 0
mirror of https://github.com/hexastack/hexabot synced 2025-06-26 18:27:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: apply strict null checks updates to the Chat Module

Browse Source
This commit is contained in:
yassinedorbozgithub
2025-01-09 17:58:26 +01:00
parent 4f88370c69
commit 90a7c2f5c2
31 changed files with 302 additions and 241 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
api/src/chat/controllers/subscriber.controller.spec.ts
View File

@@ -48,7 +48,7 @@ describe('SubscriberController', () => {
let subscriberService: SubscriberService;
let labelService: LabelService;
let userService: UserService;
let subscriber: Subscriber;
let subscriber: Subscriber | null;
let allLabels: Label[];
let allSubscribers: Subscriber[];
let allUsers: User[];
@@ -114,38 +114,39 @@ describe('SubscriberController', () => {
describe('findOne', () => {
it('should find one subscriber by id', async () => {
jest.spyOn(subscriberService, 'findOne');
const result = await subscriberService.findOne(subscriber.id);
const result = await subscriberService.findOne(subscriber!.id);
const labelIDs = allLabels
.filter((label) => subscriber.labels.includes(label.id))
.filter((label) => subscriber!.labels.includes(label.id))
.map(({ id }) => id);
expect(subscriberService.findOne).toHaveBeenCalledWith(subscriber.id);
expect(subscriberService.findOne).toHaveBeenCalledWith(subscriber!.id);
expect(result).toEqualPayload({
...subscriberFixtures.find(
({ first_name }) => first_name === subscriber.first_name,
({ first_name }) => first_name === subscriber!.first_name,
),
labels: labelIDs,
assignedTo: allUsers.find(({ id }) => subscriber.assignedTo === id).id,
assignedTo: allUsers.find(({ id }) => subscriber!.assignedTo === id)
?.id,
});
});
it('should find one subscriber by id, and populate its corresponding labels', async () => {
jest.spyOn(subscriberService, 'findOneAndPopulate');
const result = await subscriberController.findOne(subscriber.id, [
const result = await subscriberController.findOne(subscriber!.id, [
'labels',
]);
expect(subscriberService.findOneAndPopulate).toHaveBeenCalledWith(
subscriber.id,
subscriber!.id,
);
expect(result).toEqualPayload({
...subscriberFixtures.find(
({ first_name }) => first_name === subscriber.first_name,
({ first_name }) => first_name === subscriber!.first_name,
),
labels: allLabels.filter((label) =>
subscriber.labels.includes(label.id),
subscriber!.labels.includes(label.id),
),
assignedTo: allUsers.find(({ id }) => subscriber.assignedTo === id),
assignedTo: allUsers.find(({ id }) => subscriber!.assignedTo === id),
});
});
});
@@ -177,7 +178,7 @@ describe('SubscriberController', () => {
({ labels, ...rest }) => ({
...rest,
labels: allLabels.filter((label) => labels.includes(label.id)),
assignedTo: allUsers.find(({ id }) => subscriber.assignedTo === id),
assignedTo: allUsers.find(({ id }) => subscriber!.assignedTo === id),
}),
);