fix(api): apply feedback

This commit is contained in:
yassinedorbozgithub 2025-06-02 09:16:13 +01:00
parent c15c30895f
commit 8c32d9af53
4 changed files with 13 additions and 18 deletions

View File

@ -1,19 +1,16 @@
/* /*
* Copyright © 2024 Hexastack. All rights reserved. * Copyright © 2025 Hexastack. All rights reserved.
* *
* Licensed under the GNU Affero General Public License v3.0 (AGPLv3) with the following additional terms: * Licensed under the GNU Affero General Public License v3.0 (AGPLv3) with the following additional terms:
* 1. The name "Hexabot" is a trademark of Hexastack. You may not use this name in derivative works without express written permission. * 1. The name "Hexabot" is a trademark of Hexastack. You may not use this name in derivative works without express written permission.
* 2. All derivative works must include clear attribution to the original creator and software, Hexastack and Hexabot, in a prominent location (e.g., in the software's "About" section, documentation, and README file). * 2. All derivative works must include clear attribution to the original creator and software, Hexastack and Hexabot, in a prominent location (e.g., in the software's "About" section, documentation, and README file).
*/ */
import { AnySetting, StrictSetting } from '@/setting/schemas/types'; import { ExtensionSetting } from '@/setting/schemas/types';
import { HyphenToUnderscore } from '@/utils/types/extension'; import { HyphenToUnderscore } from '@/utils/types/extension';
export type ChannelName = `${string}-channel`; export type ChannelName = `${string}-channel`;
export type ChannelSetting<N extends string = string> = StrictSetting< export type ChannelSetting<N extends string = string> = ExtensionSetting<{
AnySetting, group: HyphenToUnderscore<N>;
{ }>;
group: HyphenToUnderscore<N>;
}
>;

View File

@ -6,7 +6,7 @@
* 2. All derivative works must include clear attribution to the original creator and software, Hexastack and Hexabot, in a prominent location (e.g., in the software's "About" section, documentation, and README file). * 2. All derivative works must include clear attribution to the original creator and software, Hexastack and Hexabot, in a prominent location (e.g., in the software's "About" section, documentation, and README file).
*/ */
import { AnySetting, StrictSetting } from '@/setting/schemas/types'; import { ExtensionSetting } from '@/setting/schemas/types';
import { HyphenToUnderscore } from '@/utils/types/extension'; import { HyphenToUnderscore } from '@/utils/types/extension';
import BaseHelper from './lib/base-helper'; import BaseHelper from './lib/base-helper';
@ -116,9 +116,7 @@ export type HelperRegistry<H extends BaseHelper = BaseHelper> = Map<
Map<string, H> Map<string, H>
>; >;
export type HelperSetting<N extends HelperName = HelperName> = StrictSetting< export type HelperSetting<N extends HelperName = HelperName> =
AnySetting, ExtensionSetting<{
{
group: HyphenToUnderscore<N>; group: HyphenToUnderscore<N>;
} }>;
>;

View File

@ -10,7 +10,7 @@ import { ChannelEvent } from '@/channel/lib/EventWrapper';
import { BlockCreateDto } from '@/chat/dto/block.dto'; import { BlockCreateDto } from '@/chat/dto/block.dto';
import { Block } from '@/chat/schemas/block.schema'; import { Block } from '@/chat/schemas/block.schema';
import { Conversation } from '@/chat/schemas/conversation.schema'; import { Conversation } from '@/chat/schemas/conversation.schema';
import { AnySetting, StrictSetting } from '@/setting/schemas/types'; import { ExtensionSetting } from '@/setting/schemas/types';
export type PluginName = `${string}-plugin`; export type PluginName = `${string}-plugin`;
@ -23,7 +23,7 @@ export interface CustomBlocks {}
type BlockAttrs = Partial<BlockCreateDto> & { name: string }; type BlockAttrs = Partial<BlockCreateDto> & { name: string };
export type PluginSetting = StrictSetting<AnySetting>; export type PluginSetting = ExtensionSetting;
export type PluginBlockTemplate = Omit< export type PluginBlockTemplate = Omit<
BlockAttrs, BlockAttrs,

View File

@ -131,9 +131,9 @@ export type AnySetting =
export type SettingDict = { [group: string]: Setting[] }; export type SettingDict = { [group: string]: Setting[] };
export type StrictSetting< export type ExtensionSetting<
U,
E extends object = object, E extends object = object,
U extends AnySetting = AnySetting,
K extends keyof BaseSchema = keyof BaseSchema, K extends keyof BaseSchema = keyof BaseSchema,
> = U extends any > = U extends any
? { ? {