From 82d6bc8d49a564328e2ee96bcf8ec39826dc934c Mon Sep 17 00:00:00 2001
From: Mohamed Marrouchi <marrouchi.mohamed@gmail.com>
Date: Tue, 13 May 2025 19:05:50 +0100
Subject: [PATCH] fix: apply PR review feedback

---
 api/src/chat/services/block.service.ts | 14 +++++++-------
 api/src/helper/lib/base-nlp-helper.ts  |  3 +--
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/api/src/chat/services/block.service.ts b/api/src/chat/services/block.service.ts
index 60fddde5..569c75cc 100644
--- a/api/src/chat/services/block.service.ts
+++ b/api/src/chat/services/block.service.ts
@@ -313,20 +313,20 @@ export class BlockService extends BaseService<
 
     // Filter NLP patterns match based on best guessed entities
     return nlpPatterns.filter((patterns: NlpPattern[]) => {
-      return patterns.every((ev: NlpPattern) => {
-        if (ev.match === 'value') {
+      return patterns.every((p: NlpPattern) => {
+        if (p.match === 'value') {
           return entities.find((e) => {
             return (
-              e.entity === ev.entity &&
-              (e.value === ev.value || e.canonicalValue === ev.value)
+              e.entity === p.entity &&
+              (e.value === p.value || e.canonicalValue === p.value)
             );
           });
-        } else if (ev.match === 'entity') {
+        } else if (p.match === 'entity') {
           return entities.find((e) => {
-            return e.entity === ev.entity;
+            return e.entity === p.entity;
           });
         } else {
-          this.logger.warn('Unknown NLP match type', ev);
+          this.logger.warn('Unknown NLP match type', p);
           return false;
         }
       });
diff --git a/api/src/helper/lib/base-nlp-helper.ts b/api/src/helper/lib/base-nlp-helper.ts
index 3b94c3f6..3d3212d2 100644
--- a/api/src/helper/lib/base-nlp-helper.ts
+++ b/api/src/helper/lib/base-nlp-helper.ts
@@ -321,7 +321,7 @@ export default abstract class BaseNlpHelper<
           }
 
           if (nlpValue.metadata?.stripDiacritics) {
-            value = value.normalize('NFD').replace(/[\u0300-\u036f]/g, '');
+            value = value.normalize('NFD').replace(/\p{Diacritic}/gu, '');
           }
 
           return {
@@ -349,7 +349,6 @@ export default abstract class BaseNlpHelper<
    *
    * @param text - The input text from which to extract slot values.
    * @param entities - An array of NlpEntityFull objects, each containing slot values and metadata.
-   * @param lookup - The lookup strategy to use: either `keywords` or `pattern`.
    *
    * @returns An array of `ParseEntity` objects containing the entity name, matched value, position, and confidence.
    */