fix: minor changes

api/src/i18n/services/translation.service.spec.ts

@@ -73,7 +73,7 @@ describe('TranslationService', () => {
             find: jest.fn().mockResolvedValue([
               {
                 translatable: false,
-                global_fallback: 'global_fallback',
+                label: 'global_fallback',
                 fallback_message: ['Global fallback message'],
               },
             ]),
@@ -175,7 +175,6 @@ describe('TranslationService', () => {
         fallback_message: ['Global fallback message'],
       },
     } as Settings);
-
     const strings = await service.getSettingStrings();
     expect(strings).toEqual([]);
   });

api/src/i18n/services/translation.service.ts

@@ -140,8 +140,9 @@ export class TranslationService extends BaseService<Translation> {
     return Object.values(settings)
       .map((group: Record<string, string | string[]>) => Object.entries(group))
       .flat()
-      .filter(([l]) => {
-        return translatableSettings.find(({ label }) => label === l);
+      .filter(([l, value]) => {
+        const found = translatableSettings.find(({ label }) => label === l);
+        return found && !!value;
       })
       .map(([, v]) => v)
       .flat();

api/src/utils/test/fixtures/setting.ts

@@ -20,14 +20,6 @@ export const settingFixtures: SettingCreateDto[] = [
     type: SettingType.text,
     weight: 1,
   },
-  {
-    group: 'contact',
-    label: 'greeting',
-    value: 'hello',
-    type: SettingType.text,
-    weight: 10,
-    translatable: true,
-  },
   {
     group: 'contact',
     label: 'company_name',