From 4bc783ccbe6c11affe3087f222ba4e7291c91b73 Mon Sep 17 00:00:00 2001 From: Aditya Date: Fri, 24 Jan 2025 20:06:50 +0530 Subject: [PATCH 1/2] fix: update return type of findOneByForeignId to include null --- api/src/chat/repositories/subscriber.repository.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/api/src/chat/repositories/subscriber.repository.ts b/api/src/chat/repositories/subscriber.repository.ts index 3950e656..c58fe7e1 100644 --- a/api/src/chat/repositories/subscriber.repository.ts +++ b/api/src/chat/repositories/subscriber.repository.ts @@ -125,10 +125,10 @@ export class SubscriberRepository extends BaseRepository< * * @returns The found subscriber entity. */ - async findOneByForeignId(id: string): Promise { + async findOneByForeignId(id: string): Promise { const query = this.findByForeignIdQuery(id); const [result] = await this.execute(query, Subscriber); - return result; + return result || null; } /** From 29c0912de61544e21c55b609e031593f26af7b73 Mon Sep 17 00:00:00 2001 From: Aditya Date: Mon, 27 Jan 2025 17:47:26 +0530 Subject: [PATCH 2/2] fix: update return type of findOneByForeignId to include null --- api/src/chat/repositories/subscriber.repository.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/src/chat/repositories/subscriber.repository.ts b/api/src/chat/repositories/subscriber.repository.ts index c58fe7e1..fa59ee70 100644 --- a/api/src/chat/repositories/subscriber.repository.ts +++ b/api/src/chat/repositories/subscriber.repository.ts @@ -123,7 +123,7 @@ export class SubscriberRepository extends BaseRepository< * * @param id - The foreign ID of the subscriber. * - * @returns The found subscriber entity. + * @returns The found subscriber entity, or `null` if no subscriber is found. */ async findOneByForeignId(id: string): Promise { const query = this.findByForeignIdQuery(id);