UniqAI/hexabot
1
0
Fork 0
mirror of https://github.com/hexastack/hexabot synced 2025-06-26 18:27:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(api): apply feedback

Browse Source
This commit is contained in:
yassinedorbozgithub 2025-06-17 15:28:11 +01:00
parent 672342ca31
commit 6799f59e7b
2 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
api/src/nlp/repositories/nlp-entity.repository.spec.ts
View File

@ -180,20 +180,20 @@ describe('NlpEntityRepository', () => {
}); });
describe('postCreate', () => { describe('postCreate', () => {
it('should not create and attached a foreign_id to the create nlp entity', async () => { it('should create and attach a foreign_id to the newly created nlp entity', async () => {
nlpEntityRepository.eventEmitter.once( nlpEntityRepository.eventEmitter.once(
'hook:nlpEntity:postCreate', 'hook:nlpEntity:postCreate',
async (...[created]) => { async (...[created]) => {
const spy1 = jest.spyOn(llmNluHelper, 'addEntity'); const helperSpy = jest.spyOn(llmNluHelper, 'addEntity');
const spy2 = jest.spyOn(nlpEntityService, 'updateOne'); jest.spyOn(nlpEntityService, 'updateOne');
await nlpService.handleEntityPostCreate(created); await nlpService.handleEntityPostCreate(created);
expect(spy1).toHaveBeenCalledWith(created); expect(helperSpy).toHaveBeenCalledWith(created);
expect(spy2).toHaveBeenCalledWith( expect(nlpEntityService.updateOne).toHaveBeenCalledWith(
{ {
_id: created._id, _id: created._id,
}, },
{ foreign_id: await spy1.mock.results[0].value }, { foreign_id: await helperSpy.mock.results[0].value },
); );
}, },
); );
@ -210,7 +210,7 @@ describe('NlpEntityRepository', () => {
]); ]);
}); });
it('should not create and attached a foreign_id to the create nlp entity with builtin true', async () => { it('should not create and attach a foreign_id to the newly created nlp entity with builtin set to true', async () => {
nlpEntityRepository.eventEmitter.once( nlpEntityRepository.eventEmitter.once(
'hook:nlpEntity:postCreate', 'hook:nlpEntity:postCreate',
async (...[created]) => { async (...[created]) => {

14
api/src/nlp/repositories/nlp-value.repository.spec.ts
View File

@ -193,20 +193,20 @@ describe('NlpValueRepository', () => {
}); });
describe('postCreate', () => { describe('postCreate', () => {
it('should create and attached a foreign_id to the create nlp value', async () => { it('should create and attach a foreign_id to the newly created nlp value', async () => {
nlpValueRepository.eventEmitter.once( nlpValueRepository.eventEmitter.once(
'hook:nlpValue:postCreate', 'hook:nlpValue:postCreate',
async (...[created]) => { async (...[created]) => {
const spy1 = jest.spyOn(llmNluHelper, 'addValue'); const helperSpy = jest.spyOn(llmNluHelper, 'addValue');
const spy2 = jest.spyOn(nlpValueService, 'updateOne'); jest.spyOn(nlpValueService, 'updateOne');
await nlpService.handleValuePostCreate(created); await nlpService.handleValuePostCreate(created);
expect(spy1).toHaveBeenCalledWith(created); expect(helperSpy).toHaveBeenCalledWith(created);
expect(spy2).toHaveBeenCalledWith( expect(nlpValueService.updateOne).toHaveBeenCalledWith(
{ {
_id: created._id, _id: created._id,
}, },
{ foreign_id: await spy1.mock.results[0].value }, { foreign_id: await helperSpy.mock.results[0].value },
); );
}, },
); );
@ -228,7 +228,7 @@ describe('NlpValueRepository', () => {
]); ]);
}); });
it('should create and attached a foreign_id to the create nlp value with builtin true', async () => { it('should not create and attach a foreign_id to the newly created nlp value with builtin set to true', async () => {
nlpValueRepository.eventEmitter.once( nlpValueRepository.eventEmitter.once(
'hook:nlpValue:postCreate', 'hook:nlpValue:postCreate',
async (...[created]) => { async (...[created]) => {