From 64707c5cf5c8940f3d556e0dda1a8afb02ab8d2d Mon Sep 17 00:00:00 2001 From: yassinedorbozgithub Date: Tue, 4 Feb 2025 15:42:37 +0100 Subject: [PATCH] fix(frontend): add feedback updates --- .../app-components/dialogs/confirm/ConfirmDialogBody.tsx | 8 ++++---- frontend/src/components/categories/CategoryForm.tsx | 2 +- frontend/src/components/categories/index.tsx | 2 +- frontend/src/contexts/dialogs.context.tsx | 4 ---- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/frontend/src/app-components/dialogs/confirm/ConfirmDialogBody.tsx b/frontend/src/app-components/dialogs/confirm/ConfirmDialogBody.tsx index fb7a353b..8396a397 100644 --- a/frontend/src/app-components/dialogs/confirm/ConfirmDialogBody.tsx +++ b/frontend/src/app-components/dialogs/confirm/ConfirmDialogBody.tsx @@ -13,18 +13,18 @@ import { useTranslate } from "@/hooks/useTranslate"; export const ConfirmDialogBody = ({ mode = "click", - itemsNumber = 1, + count = 1, }: { mode?: "selection" | "click"; - itemsNumber?: number; + count?: number; }) => { const { t } = useTranslate(); const dialogBodyText = mode === "selection" - ? itemsNumber === 1 + ? count === 1 ? t("message.item_selected_delete_confirm") : t("message.items_selected_delete_confirm", { - "0": itemsNumber.toString(), + "0": count.toString(), }) : t("message.item_delete_confirm"); diff --git a/frontend/src/components/categories/CategoryForm.tsx b/frontend/src/components/categories/CategoryForm.tsx index 108f6d4f..abeb522c 100644 --- a/frontend/src/components/categories/CategoryForm.tsx +++ b/frontend/src/components/categories/CategoryForm.tsx @@ -52,7 +52,7 @@ export const CategoryForm: FC> = ({ required: t("message.label_is_required"), }, }; - const onSubmitForm = async (params: ICategoryAttributes) => { + const onSubmitForm = (params: ICategoryAttributes) => { if (data) { updateCategory({ id: data.id, params }); } else { diff --git a/frontend/src/components/categories/index.tsx b/frontend/src/components/categories/index.tsx index 02da4c0b..cb968b69 100644 --- a/frontend/src/components/categories/index.tsx +++ b/frontend/src/components/categories/index.tsx @@ -163,7 +163,7 @@ export const Categories = () => { const isConfirmed = await dialogs.confirm( , ); diff --git a/frontend/src/contexts/dialogs.context.tsx b/frontend/src/contexts/dialogs.context.tsx index 0d0ae032..303b0763 100644 --- a/frontend/src/contexts/dialogs.context.tsx +++ b/frontend/src/contexts/dialogs.context.tsx @@ -8,7 +8,6 @@ import { createContext, - FC, useCallback, useId, useMemo, @@ -16,7 +15,6 @@ import { useState, } from "react"; -import { ConfirmDialog, ConfirmDialogProps } from "@/app-components/dialogs"; import { CloseDialog, DialogComponent, @@ -30,7 +28,6 @@ export const DialogsContext = createContext< | { open: OpenDialog; close: CloseDialog; - confirm: FC; } | undefined >(undefined); @@ -124,7 +121,6 @@ function DialogsProvider(props: DialogProviderProps) { () => ({ open: requestDialog, close: closeDialog, - confirm: ConfirmDialog, }), [requestDialog, closeDialog], );