diff --git a/api/src/chat/services/block.service.ts b/api/src/chat/services/block.service.ts index 4483951b..d61333d2 100644 --- a/api/src/chat/services/block.service.ts +++ b/api/src/chat/services/block.service.ts @@ -793,8 +793,6 @@ export class BlockService extends BaseService< * * @param _query - The Mongoose query object used for deletion. * @param criteria - The filter criteria for finding the labels to be deleted. - * - * @returns {Promise} A promise that resolves once the event is emitted. */ @OnEvent('hook:label:preDelete') async handleLabelPreDelete( diff --git a/api/src/chat/services/subscriber.service.ts b/api/src/chat/services/subscriber.service.ts index 883c7dab..9d8457b0 100644 --- a/api/src/chat/services/subscriber.service.ts +++ b/api/src/chat/services/subscriber.service.ts @@ -265,8 +265,6 @@ export class SubscriberService extends BaseService< * * @param _query - The Mongoose query object used for deletion. * @param criteria - The filter criteria for finding the labels to be deleted. - * - * @returns {Promise} A promise that resolves once the event is emitted. */ @OnEvent('hook:label:preDelete') async handleLabelDelete( diff --git a/api/src/nlp/repositories/nlp-entity.repository.spec.ts b/api/src/nlp/repositories/nlp-entity.repository.spec.ts index fee29fc6..8c77bc7b 100644 --- a/api/src/nlp/repositories/nlp-entity.repository.spec.ts +++ b/api/src/nlp/repositories/nlp-entity.repository.spec.ts @@ -123,8 +123,8 @@ describe('NlpEntityRepository', () => { it('should delete a nlp entity', async () => { nlpValueRepository.eventEmitter.once( 'hook:nlpEntity:preDelete', - async (...args) => { - await nlpService.handleEntityDelete(args[0], args[1]); + async (...[query, criteria]) => { + await nlpService.handleEntityDelete(query, criteria); }, ); const intentNlpEntity = await nlpEntityRepository.findOne({ diff --git a/api/src/nlp/repositories/nlp-value.repository.spec.ts b/api/src/nlp/repositories/nlp-value.repository.spec.ts index 98f8db3c..5774407e 100644 --- a/api/src/nlp/repositories/nlp-value.repository.spec.ts +++ b/api/src/nlp/repositories/nlp-value.repository.spec.ts @@ -178,8 +178,8 @@ describe('NlpValueRepository', () => { it('should delete a nlp Value', async () => { nlpValueRepository.eventEmitter.once( 'hook:nlpValue:preDelete', - async (...args) => { - await nlpService.handleValueDelete(args[0], args[1]); + async (...[query, criteria]) => { + await nlpService.handleValueDelete(query, criteria); }, ); const result = await nlpValueRepository.deleteOne(nlpValues[1].id); diff --git a/api/src/nlp/services/nlp.service.ts b/api/src/nlp/services/nlp.service.ts index 0760b8bc..728c56c5 100644 --- a/api/src/nlp/services/nlp.service.ts +++ b/api/src/nlp/services/nlp.service.ts @@ -123,12 +123,16 @@ export class NlpService { } /** - * Handles the event triggered when an NLP entity is deleted. Synchronizes the deletion with the external NLP provider. + * Before deleting a `nlpEntity`, this method deletes the related `nlpValue` and `nlpSampleEntity`. Synchronizes the deletion with the external NLP provider * - * @param entity - The NLP entity to be deleted. + * @param _query - The Mongoose query object used for deletion. + * @param criteria - The filter criteria for finding the nlpEntities to be deleted. */ @OnEvent('hook:nlpEntity:preDelete') - async handleEntityDelete(_query: unknown, criteria: TFilterQuery) { + async handleEntityDelete( + _query: unknown, + criteria: TFilterQuery, + ): Promise { if (criteria._id) { await this.nlpValueService.deleteMany({ entity: criteria._id }); await this.nlpSampleEntityService.deleteMany({ entity: criteria._id }); @@ -216,12 +220,16 @@ export class NlpService { } /** - * Handles the event triggered when an NLP value is deleted. Synchronizes the deletion with the external NLP provider. + * Before deleting a `nlpValue`, this method deletes the related `nlpSampleEntity`. Synchronizes the deletion with the external NLP provider * - * @param value - The NLP value to be deleted. + * @param _query - The Mongoose query object used for deletion. + * @param criteria - The filter criteria for finding the nlpValues to be deleted. */ @OnEvent('hook:nlpValue:preDelete') - async handleValueDelete(_query: unknown, criteria: TFilterQuery) { + async handleValueDelete( + _query: unknown, + criteria: TFilterQuery, + ): Promise { if (criteria._id) { await this.nlpSampleEntityService.deleteMany({ value: criteria._id,