UniqAI/hexabot
1
0
Fork 0
mirror of https://github.com/hexastack/hexabot synced 2025-06-26 18:27:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #1110 from Hexastack/1109-issue---onevent-methods-remove-unused-returns

Browse Source 
fix(api): remove unused returns
This commit is contained in:
Med Marrouchi 2025-06-11 09:59:55 +01:00 committed by GitHub
commit 4f59fbaeb5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
api/src/extensions/channels/web/base-web-channel.ts
View File

@ -126,10 +126,10 @@ export default abstract class BaseWebChannelHandler<
try { try {
const menu = await this.menuService.getTree(); const menu = await this.menuService.getTree();
return client.emit('settings', { menu, ...settings }); client.emit('settings', { menu, ...settings });
} catch (err) { } catch (err) {
this.logger.warn('Unable to retrieve menu ', err); this.logger.warn('Unable to retrieve menu ', err);
return client.emit('settings', settings); client.emit('settings', settings);
} }
} catch (err) { } catch (err) {
this.logger.error('Unable to initiate websocket connection', err); this.logger.error('Unable to initiate websocket connection', err);

9
api/src/nlp/services/nlp.service.ts
View File

@ -65,7 +65,6 @@ export class NlpService {
* Handles the event triggered when a new NLP entity is created. Synchronizes the entity with the external NLP provider. * Handles the event triggered when a new NLP entity is created. Synchronizes the entity with the external NLP provider.
* *
* @param entity - The NLP entity to be created. * @param entity - The NLP entity to be created.
* @returns The updated entity after synchronization.
*/ */
@OnEvent('hook:nlpEntity:create') @OnEvent('hook:nlpEntity:create')
async handleEntityCreate(entity: NlpEntityDocument) { async handleEntityCreate(entity: NlpEntityDocument) {
@ -74,7 +73,7 @@ export class NlpService {
const helper = await this.helperService.getDefaultHelper(HelperType.NLU); const helper = await this.helperService.getDefaultHelper(HelperType.NLU);
const foreignId = await helper.addEntity(entity); const foreignId = await helper.addEntity(entity);
this.logger.debug('New entity successfully synced!', foreignId); this.logger.debug('New entity successfully synced!', foreignId);
return await this.nlpEntityService.updateOne( await this.nlpEntityService.updateOne(
{ _id: entity._id }, { _id: entity._id },
{ {
foreign_id: foreignId, foreign_id: foreignId,
@ -82,7 +81,6 @@ export class NlpService {
); );
} catch (err) { } catch (err) {
this.logger.error('Unable to sync a new entity', err); this.logger.error('Unable to sync a new entity', err);
return entity;
} }
} }
@ -129,8 +127,6 @@ export class NlpService {
* Handles the event triggered when a new NLP value is created. Synchronizes the value with the external NLP provider. * Handles the event triggered when a new NLP value is created. Synchronizes the value with the external NLP provider.
* *
* @param value - The NLP value to be created. * @param value - The NLP value to be created.
*
* @returns The updated value after synchronization.
*/ */
@OnEvent('hook:nlpValue:create') @OnEvent('hook:nlpValue:create')
async handleValueCreate(value: NlpValueDocument) { async handleValueCreate(value: NlpValueDocument) {
@ -139,7 +135,7 @@ export class NlpService {
const helper = await this.helperService.getDefaultNluHelper(); const helper = await this.helperService.getDefaultNluHelper();
const foreignId = await helper.addValue(value); const foreignId = await helper.addValue(value);
this.logger.debug('New value successfully synced!', foreignId); this.logger.debug('New value successfully synced!', foreignId);
return await this.nlpValueService.updateOne( await this.nlpValueService.updateOne(
{ _id: value._id }, { _id: value._id },
{ {
foreign_id: foreignId, foreign_id: foreignId,
@ -147,7 +143,6 @@ export class NlpService {
); );
} catch (err) { } catch (err) {
this.logger.error('Unable to sync a new value', err); this.logger.error('Unable to sync a new value', err);
return value;
} }
} }