From 1492b7cdeb0f03871cd25ccd8c6ca6e9eda33853 Mon Sep 17 00:00:00 2001 From: yassinedorbozgithub Date: Wed, 29 Jan 2025 11:17:53 +0100 Subject: [PATCH] fix: close channel on unmount --- frontend/src/hooks/useBroadcastChannel.ts | 5 ++++- widget/src/hooks/useBroadcastChannel.ts | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/frontend/src/hooks/useBroadcastChannel.ts b/frontend/src/hooks/useBroadcastChannel.ts index 32172c31..8e718996 100644 --- a/frontend/src/hooks/useBroadcastChannel.ts +++ b/frontend/src/hooks/useBroadcastChannel.ts @@ -101,6 +101,9 @@ function useChannelEventListener( channel.addEventListener(event, callback); - return () => channel.removeEventListener(event, callback); + return () => { + channel.close(); + channel.removeEventListener(event, callback); + }; }, [channel, event]); } diff --git a/widget/src/hooks/useBroadcastChannel.ts b/widget/src/hooks/useBroadcastChannel.ts index 32172c31..8e718996 100644 --- a/widget/src/hooks/useBroadcastChannel.ts +++ b/widget/src/hooks/useBroadcastChannel.ts @@ -101,6 +101,9 @@ function useChannelEventListener( channel.addEventListener(event, callback); - return () => channel.removeEventListener(event, callback); + return () => { + channel.close(); + channel.removeEventListener(event, callback); + }; }, [channel, event]); }