fix(api): optimize helper injection

This commit is contained in:
yassinedorbozgithub 2025-06-12 14:54:56 +01:00
parent 44efa5b31c
commit 1468da3d54
2 changed files with 13 additions and 46 deletions

View File

@ -14,7 +14,6 @@ import { HelperService } from '@/helper/helper.service';
import { LanguageRepository } from '@/i18n/repositories/language.repository'; import { LanguageRepository } from '@/i18n/repositories/language.repository';
import { LanguageModel } from '@/i18n/schemas/language.schema'; import { LanguageModel } from '@/i18n/schemas/language.schema';
import { LanguageService } from '@/i18n/services/language.service'; import { LanguageService } from '@/i18n/services/language.service';
import { LoggerService } from '@/logger/logger.service';
import { SettingRepository } from '@/setting/repositories/setting.repository'; import { SettingRepository } from '@/setting/repositories/setting.repository';
import { SettingModel } from '@/setting/schemas/setting.schema'; import { SettingModel } from '@/setting/schemas/setting.schema';
import { SettingSeeder } from '@/setting/seeds/setting.seed'; import { SettingSeeder } from '@/setting/seeds/setting.seed';
@ -49,12 +48,10 @@ describe('NlpEntityRepository', () => {
let firstNameNlpEntity: NlpEntity | null; let firstNameNlpEntity: NlpEntity | null;
let nlpService: NlpService; let nlpService: NlpService;
let helperService: HelperService; let helperService: HelperService;
let languageService: LanguageService; let llmNluHelper: LlmNluHelper;
let settingService: SettingService;
let nlpEntityService: NlpEntityService;
beforeAll(async () => { beforeAll(async () => {
const { getMocks, resolveMocks } = await buildTestingMocks({ const { getMocks } = await buildTestingMocks({
imports: [ imports: [
rootMongooseTestModule(installNlpValueFixtures), rootMongooseTestModule(installNlpValueFixtures),
MongooseModule.forFeature([ MongooseModule.forFeature([
@ -102,6 +99,7 @@ describe('NlpEntityRepository', () => {
LanguageRepository, LanguageRepository,
SettingRepository, SettingRepository,
SettingSeeder, SettingSeeder,
LlmNluHelper,
], ],
}); });
@ -110,33 +108,18 @@ describe('NlpEntityRepository', () => {
nlpValueRepository, nlpValueRepository,
nlpService, nlpService,
helperService, helperService,
settingService, llmNluHelper,
languageService,
nlpEntityService,
] = await getMocks([ ] = await getMocks([
NlpEntityRepository, NlpEntityRepository,
NlpValueRepository, NlpValueRepository,
NlpService, NlpService,
HelperService, HelperService,
SettingService, LlmNluHelper,
LanguageService,
NlpEntityService,
]); ]);
firstNameNlpEntity = await nlpEntityRepository.findOne({ firstNameNlpEntity = await nlpEntityRepository.findOne({
name: 'firstname', name: 'firstname',
}); });
helperService.register(llmNluHelper);
const [loggerService] = await resolveMocks([LoggerService]);
helperService.register(
new LlmNluHelper(
settingService,
helperService,
loggerService,
languageService,
nlpEntityService,
),
);
}); });
afterAll(closeInMongodConnection); afterAll(closeInMongodConnection);

View File

@ -55,12 +55,10 @@ describe('NlpValueRepository', () => {
let nlpValues: NlpValue[]; let nlpValues: NlpValue[];
let nlpService: NlpService; let nlpService: NlpService;
let helperService: HelperService; let helperService: HelperService;
let languageService: LanguageService; let llmNluHelper: LlmNluHelper;
let settingService: SettingService;
let nlpEntityService: NlpEntityService;
beforeAll(async () => { beforeAll(async () => {
const { getMocks, resolveMocks } = await buildTestingMocks({ const { getMocks } = await buildTestingMocks({
imports: [ imports: [
rootMongooseTestModule(installNlpSampleEntityFixtures), rootMongooseTestModule(installNlpSampleEntityFixtures),
MongooseModule.forFeature([ MongooseModule.forFeature([
@ -109,39 +107,25 @@ describe('NlpValueRepository', () => {
}, },
SettingRepository, SettingRepository,
SettingSeeder, SettingSeeder,
LlmNluHelper,
], ],
}); });
[ [
nlpValueRepository, nlpValueRepository,
nlpSampleEntityRepository, nlpSampleEntityRepository,
nlpService, nlpService,
helperService, helperService,
settingService, llmNluHelper,
languageService,
nlpEntityService,
] = await getMocks([ ] = await getMocks([
NlpValueRepository, NlpValueRepository,
NlpSampleEntityRepository, NlpSampleEntityRepository,
NlpService, NlpService,
HelperService, HelperService,
SettingService, LlmNluHelper,
LanguageService,
NlpEntityService,
]); ]);
nlpValues = await nlpValueRepository.findAll(); nlpValues = await nlpValueRepository.findAll();
helperService.register(llmNluHelper);
const [loggerService] = await resolveMocks([LoggerService]);
helperService.register(
new LlmNluHelper(
settingService,
helperService,
loggerService,
languageService,
nlpEntityService,
),
);
}); });
afterAll(closeInMongodConnection); afterAll(closeInMongodConnection);