UniqAI/hexabot
1
0
Fork 0
mirror of https://github.com/hexastack/hexabot synced 2024-11-24 04:53:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(api): Insecure randomness

Browse Source
This commit is contained in:
yassinedorbozgithub 2024-09-30 06:32:43 +01:00
parent b735d5ebd1
commit 00fa4316be
3 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
api/src/chat/services/block.service.ts
View File

@ -21,6 +21,7 @@ import { PluginType } from '@/plugins/types';
import { Settings } from '@/setting/schemas/types'; import { Settings } from '@/setting/schemas/types';
import { SettingService } from '@/setting/services/setting.service'; import { SettingService } from '@/setting/services/setting.service';
import { BaseService } from '@/utils/generics/base-service'; import { BaseService } from '@/utils/generics/base-service';
import { getRadom } from '@/utils/helpers/safeRandom';
import { BlockRepository } from '../repositories/block.repository'; import { BlockRepository } from '../repositories/block.repository';
import { Block, BlockFull, BlockPopulate } from '../schemas/block.schema'; import { Block, BlockFull, BlockPopulate } from '../schemas/block.schema';
@ -394,7 +395,7 @@ export class BlockService extends BaseService<Block, BlockPopulate, BlockFull> {
*/ */
getRandom<T>(array: T[]): T { getRandom<T>(array: T[]): T {
return Array.isArray(array) return Array.isArray(array)
? array[Math.floor(Math.random() * array.length)] ? array[Math.floor(getRadom() * array.length)]
: array; : array;
} }

3
api/src/user/controllers/auth.controller.spec.ts
View File

@ -27,6 +27,7 @@ import { LanguageModel } from '@/i18n/schemas/language.schema';
import { I18nService } from '@/i18n/services/i18n.service'; import { I18nService } from '@/i18n/services/i18n.service';
import { LanguageService } from '@/i18n/services/language.service'; import { LanguageService } from '@/i18n/services/language.service';
import { LoggerService } from '@/logger/logger.service'; import { LoggerService } from '@/logger/logger.service';
import { getRadom } from '@/utils/helpers/safeRandom';
import { installUserFixtures } from '@/utils/test/fixtures/user'; import { installUserFixtures } from '@/utils/test/fixtures/user';
import { import {
closeInMongodConnection, closeInMongodConnection,
@ -126,7 +127,7 @@ describe('AuthController', () => {
role = await roleService.findOne({}); role = await roleService.findOne({});
baseUser = { baseUser = {
email: 'test@testing.com', email: 'test@testing.com',
password: Math.random().toString(), password: getRadom().toString(),
username: 'test', username: 'test',
first_name: 'test', first_name: 'test',
last_name: 'test', last_name: 'test',

15
api/src/utils/helpers/safeRandom.ts Normal file
View File

@ -0,0 +1,15 @@
/*
* Copyright © 2024 Hexastack. All rights reserved.
*
* Licensed under the GNU Affero General Public License v3.0 (AGPLv3) with the following additional terms:
* 1. The name "Hexabot" is a trademark of Hexastack. You may not use this name in derivative works without express written permission.
* 2. All derivative works must include clear attribution to the original creator and software, Hexastack and Hexabot, in a prominent location (e.g., in the software's "About" section, documentation, and README file).
*/
/**
* Return a cryptographically secure random value between 0 and 1 is desired
*
* @returns A cryptographically secure random value between 0 and 1 is desired
*/
export const getRadom = (): number =>
window.crypto.getRandomValues(new Uint32Array(1))[0] * Math.pow(2, -32);