From 13f856f9596064ce8aa7f27e88edc546db706935 Mon Sep 17 00:00:00 2001 From: bkerbl Date: Wed, 12 Jul 2023 12:10:03 +0200 Subject: [PATCH 1/5] Clarification --- README.md | 4 ++-- full_eval.py | 4 ++-- scene/gaussian_model.py | 2 ++ 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 4f1200d..f31fe92 100644 --- a/README.md +++ b/README.md @@ -301,12 +301,12 @@ cmake --build build --target install ``` #### Ubuntu 20.04 -Backwards compatibility with Focal Fossa is not fully tested, but building SIBR should still work by first invoking +Backwards compatibility with Focal Fossa is not fully tested, but building SIBR should still invoking ```shell git checkout fossa_compatibility git submodule update --init ``` -and then continuing with the steps for Ubuntu 22.04. +in ```SIBR_viewers``` and then continuing with the steps for Ubuntu 22.04. ### Navigation in SIBR Viewers The SIBR interface provides several methods of navigating the scene. By default, you will be started with an FPS navigator, which you can control with ```W, A, S, D, Q, E``` for camera translation and ```I, K, J, L, U, O``` for rotation. Alternatively, you may want to use a Trackball-style navigator (select from the floating menu). You can also snap to a camera from the data set with the ```Snap to``` button or find the closest camera with ```Snap to closest```. The floating menues also allow you to change the navigation speed. You can use the ```Scaling Modifier``` to control the size of the displayed Gaussians, or show the initial point cloud. diff --git a/full_eval.py b/full_eval.py index d174ef8..672ee12 100644 --- a/full_eval.py +++ b/full_eval.py @@ -12,7 +12,7 @@ import os from argparse import ArgumentParser -mipnerf360_outdoor_scenes = ["bicycle", "flowers", "garden", "stump", "treehill"] +mipnerf360_outdoor_scenes = ["flowers", "garden", "stump", "treehill"] mipnerf360_indoor_scenes = ["room", "counter", "kitchen", "bonsai"] tanks_and_temples_scenes = ["truck", "train"] deep_blending_scenes = ["drjohnson", "playroom"] @@ -37,7 +37,7 @@ if not args.skip_training or not args.skip_rendering: args = parser.parse_args() if not args.skip_training: - common_args = " --quiet --eval --test_iterations -1" + common_args = " --eval --save_iterations -1" for scene in mipnerf360_outdoor_scenes: source = args.mipnerf360 + "/" + scene os.system("python train.py -s " + source + " -i images_4 -m " + args.output_path + "/" + scene + common_args) diff --git a/scene/gaussian_model.py b/scene/gaussian_model.py index 20a81d4..f50a4b2 100644 --- a/scene/gaussian_model.py +++ b/scene/gaussian_model.py @@ -84,7 +84,9 @@ class GaussianModel: self.active_sh_degree += 1 def create_from_pcd(self, pcd : BasicPointCloud, spatial_lr_scale : float): + spatial_lr_scale = 5 self.spatial_lr_scale = spatial_lr_scale + #print(spatial_lr_scale) fused_point_cloud = torch.tensor(np.asarray(pcd.points)).float().cuda() fused_color = RGB2SH(torch.tensor(np.asarray(pcd.colors)).float().cuda()) features = torch.zeros((fused_color.shape[0], 3, (self.max_sh_degree + 1) ** 2)).float().cuda() From f43f71b9fb622487c702c6639d8fa746576d2ff2 Mon Sep 17 00:00:00 2001 From: bkerbl Date: Wed, 12 Jul 2023 12:10:47 +0200 Subject: [PATCH 2/5] Clarification --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index f31fe92..91b4cf4 100644 --- a/README.md +++ b/README.md @@ -304,7 +304,6 @@ cmake --build build --target install Backwards compatibility with Focal Fossa is not fully tested, but building SIBR should still invoking ```shell git checkout fossa_compatibility -git submodule update --init ``` in ```SIBR_viewers``` and then continuing with the steps for Ubuntu 22.04. From 51705d4cb21943e9f7f445dedda5a4a2825fda7a Mon Sep 17 00:00:00 2001 From: bkerbl Date: Wed, 12 Jul 2023 12:11:57 +0200 Subject: [PATCH 3/5] Clarification --- README.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/README.md b/README.md index 91b4cf4..59eed1e 100644 --- a/README.md +++ b/README.md @@ -301,11 +301,10 @@ cmake --build build --target install ``` #### Ubuntu 20.04 -Backwards compatibility with Focal Fossa is not fully tested, but building SIBR should still invoking +Backwards compatibility with Focal Fossa is not fully tested, but building SIBR with CMake should still work after invoking ```shell git checkout fossa_compatibility ``` -in ```SIBR_viewers``` and then continuing with the steps for Ubuntu 22.04. ### Navigation in SIBR Viewers The SIBR interface provides several methods of navigating the scene. By default, you will be started with an FPS navigator, which you can control with ```W, A, S, D, Q, E``` for camera translation and ```I, K, J, L, U, O``` for rotation. Alternatively, you may want to use a Trackball-style navigator (select from the floating menu). You can also snap to a camera from the data set with the ```Snap to``` button or find the closest camera with ```Snap to closest```. The floating menues also allow you to change the navigation speed. You can use the ```Scaling Modifier``` to control the size of the displayed Gaussians, or show the initial point cloud. From b7031f116f688f896c384359e731d3e5f6014e21 Mon Sep 17 00:00:00 2001 From: Bernhard Kerbl Date: Wed, 12 Jul 2023 12:03:48 +0200 Subject: [PATCH 4/5] Bump viewer version --- SIBR_viewers | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SIBR_viewers b/SIBR_viewers index 29dd2f3..549b0c2 160000 --- a/SIBR_viewers +++ b/SIBR_viewers @@ -1 +1 @@ -Subproject commit 29dd2f3a5dc866664b8e0f04bce34dc81e5e6088 +Subproject commit 549b0c2d2c82e186cd5d705b11c53ff5e27b14e5 From 6f1e3ec83a4fa238e78db06bcac0de77356be82a Mon Sep 17 00:00:00 2001 From: bkerbl Date: Wed, 12 Jul 2023 12:14:22 +0200 Subject: [PATCH 5/5] Undo spatial lr removal --- SIBR_viewers | 2 +- full_eval.py | 4 ++-- scene/gaussian_model.py | 2 -- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/SIBR_viewers b/SIBR_viewers index 549b0c2..29dd2f3 160000 --- a/SIBR_viewers +++ b/SIBR_viewers @@ -1 +1 @@ -Subproject commit 549b0c2d2c82e186cd5d705b11c53ff5e27b14e5 +Subproject commit 29dd2f3a5dc866664b8e0f04bce34dc81e5e6088 diff --git a/full_eval.py b/full_eval.py index 672ee12..d174ef8 100644 --- a/full_eval.py +++ b/full_eval.py @@ -12,7 +12,7 @@ import os from argparse import ArgumentParser -mipnerf360_outdoor_scenes = ["flowers", "garden", "stump", "treehill"] +mipnerf360_outdoor_scenes = ["bicycle", "flowers", "garden", "stump", "treehill"] mipnerf360_indoor_scenes = ["room", "counter", "kitchen", "bonsai"] tanks_and_temples_scenes = ["truck", "train"] deep_blending_scenes = ["drjohnson", "playroom"] @@ -37,7 +37,7 @@ if not args.skip_training or not args.skip_rendering: args = parser.parse_args() if not args.skip_training: - common_args = " --eval --save_iterations -1" + common_args = " --quiet --eval --test_iterations -1" for scene in mipnerf360_outdoor_scenes: source = args.mipnerf360 + "/" + scene os.system("python train.py -s " + source + " -i images_4 -m " + args.output_path + "/" + scene + common_args) diff --git a/scene/gaussian_model.py b/scene/gaussian_model.py index f50a4b2..20a81d4 100644 --- a/scene/gaussian_model.py +++ b/scene/gaussian_model.py @@ -84,9 +84,7 @@ class GaussianModel: self.active_sh_degree += 1 def create_from_pcd(self, pcd : BasicPointCloud, spatial_lr_scale : float): - spatial_lr_scale = 5 self.spatial_lr_scale = spatial_lr_scale - #print(spatial_lr_scale) fused_point_cloud = torch.tensor(np.asarray(pcd.points)).float().cuda() fused_color = RGB2SH(torch.tensor(np.asarray(pcd.colors)).float().cuda()) features = torch.zeros((fused_color.shape[0], 3, (self.max_sh_degree + 1) ** 2)).float().cuda()