From 23fa6f22177880470bfa86c2cfb31ca876c6ab8f Mon Sep 17 00:00:00 2001 From: Brian Hackett Date: Tue, 4 Mar 2025 07:22:42 -0800 Subject: [PATCH] Assorted fixes around approve changes UI (#45) --- app/components/chat/ApproveChange.tsx | 24 +- app/components/chat/BaseChat.tsx | 281 ++++++++++++++---------- app/components/chat/Chat.client.tsx | 2 +- app/components/chat/Messages.client.tsx | 109 +++------ app/lib/replay/Problems.ts | 2 +- app/routes/problem.$id.tsx | 32 ++- 6 files changed, 237 insertions(+), 213 deletions(-) diff --git a/app/components/chat/ApproveChange.tsx b/app/components/chat/ApproveChange.tsx index a15ba08d..b1cb7f11 100644 --- a/app/components/chat/ApproveChange.tsx +++ b/app/components/chat/ApproveChange.tsx @@ -9,17 +9,19 @@ export interface RejectChangeData { } interface ApproveChangeProps { + rejectFormOpen: boolean; + setRejectFormOpen: (rejectFormOpen: boolean) => void; onApprove: () => void; onReject: (data: RejectChangeData) => void; } -const ApproveChange: React.FC = ({ onApprove, onReject }) => { +const ApproveChange: React.FC = ({ rejectFormOpen, setRejectFormOpen, onApprove, onReject }) => { const textareaRef = useRef(null); - const [hasRejected, setHasRejected] = useState(false); const [shareProject, setShareProject] = useState(false); - if (hasRejected) { + if (rejectFormOpen) { const performReject = (retry: boolean) => { + setRejectFormOpen(false); const explanation = textareaRef.current?.value ?? ''; onReject({ explanation, @@ -32,7 +34,7 @@ const ApproveChange: React.FC = ({ onApprove, onReject }) => <>