Telegram-Market/telegram-shop
1
1
Fork 0
Code Issues 40 Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Обернуть покупку в транзакцию (race condition) #75

New Issue
Open
opened 2026-06-17 19:41:27 +00:00 by NW · 0 comments
NW commented 2026-06-17 19:41:27 +00:00
Owner
Copy Link

Проблема

purchaseService.js:45-108 — баланс проверяется и списывается без BEGIN TRANSACTION. При параллельных покупках возможен double-spend.

Решение

  • Обернуть createPurchase в BEGIN IMMEDIATE TRANSACTION / COMMIT / ROLLBACK
  • Проверка остатка на складе в той же транзакции
  • Использовать UPDATE ... WHERE quantity_in_stock >= ? для атомарного списания
  • Добавить тест на параллельные покупки

Приоритет: КРИТИЧЕСКИЙ

## Проблема `purchaseService.js:45-108` — баланс проверяется и списывается без `BEGIN TRANSACTION`. При параллельных покупках возможен double-spend. ## Решение - [ ] Обернуть createPurchase в `BEGIN IMMEDIATE TRANSACTION` / `COMMIT` / `ROLLBACK` - [ ] Проверка остатка на складе в той же транзакции - [ ] Использовать `UPDATE ... WHERE quantity_in_stock >= ?` для атомарного списания - [ ] Добавить тест на параллельные покупки ## Приоритет: КРИТИЧЕСКИЙ
NW added this to the Phase 1: Security & Secrets Management milestone 2026-06-17 19:41:27 +00:00
NW added the priority::criticaltype::bugphase::1 labels 2026-06-17 19:41:27 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
phase::1
Phase 1: Security
 phase::1
Phase 1
 phase::1
Phase 1
 phase::2
Phase 2: Architecture
 phase::2
Phase 2
 phase::3
Phase 3: Admin API
 phase::3
Phase 3
 phase::4
Phase 4: Web UI
 phase::4
Phase 4
 phase::5
Phase 5: Quality
 phase::5
Phase 5
 priority::critical
Critical priority
 priority::critical
Critical priority
 priority::high
High priority
 priority::high
High priority
 priority::medium
Medium priority
 priority::medium
Medium priority
 type::bug
Bug fix
 type::bug
Bug
 type::feature
New feature
 type::feature
Feature
 type::infra
Infrastructure
 type::infra
Infrastructure
 type::refactor
Code refactoring
 type::refactor
Refactoring
 type::security
Security issue
 type::security
Security
 type::testing
Testing
 type::testing
Testing
No Label phase::1 priority::critical type::bug
Milestone
No items
No Milestone Phase 1: Security & Secrets Management
Projects
Clear projects
No project
Assignees
Clear assignees
NW
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Telegram-Market/telegram-shop#75
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?