refactor(arch): replace if/else router with Map-based dispatcher (#53)

- index.js: 394→69 lines (82% reduction)
- callbackRouter.js (36 lines): Map-based dispatch with exact + prefix matching
  - Longest-prefix-first for specificity
  - Logs warning for unregistered callbacks
- messageRouter.js (27 lines): Ordered input handlers + text command Map
- routes.js (345 lines): All 59 callback routes + 9 text commands + 7 input handlers
  - Exact routes: 19 (add_wallet, back_to_balance, etc.)
  - Prefix routes: 40 (generate_wallet_, view_product_, etc.)
  - Admin text commands with isAdmin guard
  - Special cases: view_transaction_history_ page extraction
  - Input handler order preserved (location → category → import → edit → dump → bonus)
This commit is contained in:
NW
2026-06-22 01:16:34 +01:00
parent f8123e42bb
commit d0b26dae25
4 changed files with 420 additions and 337 deletions

View File

@@ -0,0 +1,36 @@
class CallbackRouter {
constructor() {
this.exactRoutes = new Map();
this.prefixRoutes = new Map();
}
registerExact(action, handler) {
this.exactRoutes.set(action, handler);
}
registerPrefix(prefix, handler) {
this.prefixRoutes.set(prefix, handler);
}
async dispatch(callbackQuery) {
const action = callbackQuery.data;
const exactHandler = this.exactRoutes.get(action);
if (exactHandler) {
await exactHandler(callbackQuery);
return;
}
const prefixes = [...this.prefixRoutes.keys()].sort((a, b) => b.length - a.length);
for (const prefix of prefixes) {
if (action.startsWith(prefix)) {
await this.prefixRoutes.get(prefix)(callbackQuery);
return;
}
}
console.warn(`No handler for callback: ${action}`);
}
}
export default new CallbackRouter();

View File

@@ -0,0 +1,27 @@
class MessageRouter {
constructor() {
this.inputHandlers = [];
this.textHandlers = new Map();
}
registerInput(handler) {
this.inputHandlers.push(handler);
}
registerText(text, handler) {
this.textHandlers.set(text, handler);
}
async dispatch(msg) {
for (const handler of this.inputHandlers) {
if (await handler(msg)) return;
}
if (msg.text && this.textHandlers.has(msg.text)) {
await this.textHandlers.get(msg.text)(msg);
return;
}
}
}
export default new MessageRouter();

345
src/router/routes.js Normal file
View File

@@ -0,0 +1,345 @@
import callbackRouter from './callbackRouter.js';
import messageRouter from './messageRouter.js';
import { isAdmin } from '../middleware/auth.js';
import userHandler from '../handlers/userHandlers/userHandler.js';
import userPurchaseHandler from '../handlers/userHandlers/userPurchaseHandler.js';
import userLocationHandler from '../handlers/userHandlers/userLocationHandler.js';
import userProductHandler from '../handlers/userHandlers/userProductHandler.js';
import userWalletsHandler from '../handlers/userHandlers/wallet/index.js';
import userDeletionHandler from '../handlers/userHandlers/userDeletionHandler.js';
import adminHandler from '../handlers/adminHandlers/adminHandler.js';
import adminUserLocationHandler from '../handlers/adminHandlers/adminUserLocationHandler.js';
import adminDumpHandler from '../handlers/adminHandlers/adminDumpHandler.js';
import adminLocationHandler from '../handlers/adminHandlers/adminLocationHandler.js';
import productHandler from '../handlers/adminHandlers/product/index.js';
import adminWalletsHandler from '../handlers/adminHandlers/adminWalletsHandler.js';
import adminUserHandler from '../handlers/adminHandlers/adminUserHandler.js';
const logDebug = (action, functionName) => {
console.log(`[DEBUG] Button Press: ${action}`);
console.log(`[DEBUG] Calling Function: ${functionName}`);
};
export function registerRoutes() {
// === Message Input Handlers (order matters — checked first) ===
messageRouter.registerInput(adminLocationHandler.handleLocationInput.bind(adminLocationHandler));
messageRouter.registerInput(productHandler.handleCategoryInput.bind(productHandler));
messageRouter.registerInput(productHandler.handleProductImport.bind(productHandler));
messageRouter.registerInput(productHandler.handleProductEditImport.bind(productHandler));
messageRouter.registerInput(adminDumpHandler.handleDumpImport.bind(adminDumpHandler));
messageRouter.registerInput(adminUserHandler.handleBonusBalanceInput.bind(adminUserHandler));
messageRouter.registerInput(productHandler.handleCategoryUpdate.bind(productHandler));
// === Text Commands ===
messageRouter.registerText('📦 Products', async (msg) => {
logDebug(msg.text, 'showProducts');
await userProductHandler.showProducts(msg);
});
messageRouter.registerText('👤 Profile', async (msg) => {
logDebug(msg.text, 'showProfile');
await userHandler.showProfile(msg);
});
messageRouter.registerText('💰 Wallets', async (msg) => {
logDebug(msg.text, 'showBalance');
await userWalletsHandler.showBalance(msg);
});
messageRouter.registerText('🛍 Purchases', async (msg) => {
logDebug(msg.text, 'showPurchases');
await userPurchaseHandler.showPurchases(msg);
});
messageRouter.registerText('📦 Manage Products', async (msg) => {
if (!isAdmin(msg.from.id)) return;
logDebug(msg.text, 'handleProductManagement');
await productHandler.handleProductManagement(msg);
});
messageRouter.registerText('👥 Manage Users', async (msg) => {
if (!isAdmin(msg.from.id)) return;
logDebug(msg.text, 'handleUserList');
await adminUserHandler.handleUserList(msg);
});
messageRouter.registerText('📍 Manage Locations', async (msg) => {
if (!isAdmin(msg.from.id)) return;
logDebug(msg.text, 'handleViewLocations');
await adminLocationHandler.handleViewLocations(msg);
});
messageRouter.registerText('💾 Database Backup', async (msg) => {
if (!isAdmin(msg.from.id)) return;
logDebug(msg.text, 'handleDump');
await adminDumpHandler.handleDump(msg);
});
messageRouter.registerText('💰 Manage Wallets', async (msg) => {
if (!isAdmin(msg.from.id)) return;
logDebug(msg.text, 'handleWalletManagement');
await adminWalletsHandler.handleWalletManagement(msg);
});
// === Exact Callback Routes ===
callbackRouter.registerExact('set_location', async (cq) => {
logDebug(cq.data, 'handleSetLocation');
await userLocationHandler.handleSetLocation(cq);
});
callbackRouter.registerExact('back_to_profile', async (cq) => {
logDebug(cq.data, 'handleBackToProfile');
await userHandler.handleBackToProfile(cq);
});
callbackRouter.registerExact('back_to_balance', async (cq) => {
logDebug(cq.data, 'handleBackToBalance');
await userWalletsHandler.handleBackToBalance(cq);
});
callbackRouter.registerExact('delete_account', async (cq) => {
logDebug(cq.data, 'handleDeleteAccount');
await userDeletionHandler.handleDeleteAccount(cq);
});
callbackRouter.registerExact('confirm_delete_account', async (cq) => {
logDebug(cq.data, 'handleConfirmDelete');
await userDeletionHandler.handleConfirmDelete(cq);
});
callbackRouter.registerExact('add_wallet', async (cq) => {
logDebug(cq.data, 'handleAddWallet');
await userWalletsHandler.handleAddWallet(cq);
});
callbackRouter.registerExact('top_up_wallet', async (cq) => {
logDebug(cq.data, 'handleTopUpWallet');
await userWalletsHandler.handleTopUpWallet(cq);
});
callbackRouter.registerExact('wallet_history', async (cq) => {
logDebug(cq.data, 'handleWalletHistory');
await userWalletsHandler.handleWalletHistory(cq);
});
callbackRouter.registerExact('view_archived_wallets', async (cq) => {
logDebug(cq.data, 'handleViewArchivedWallets');
await userWalletsHandler.handleViewArchivedWallets(cq);
});
callbackRouter.registerExact('refresh_balance', async (cq) => {
logDebug(cq.data, 'handleRefreshBalance');
await userWalletsHandler.handleRefreshBalance(cq);
});
callbackRouter.registerExact('shop_start', async (cq) => {
logDebug(cq.data, 'showProducts');
await userProductHandler.showProducts(cq.message);
});
callbackRouter.registerExact('add_location', async (cq) => {
logDebug(cq.data, 'handleAddLocation');
await adminLocationHandler.handleAddLocation(cq);
});
callbackRouter.registerExact('view_locations', async (cq) => {
logDebug(cq.data, 'handleViewLocations');
await adminLocationHandler.handleViewLocations(cq);
});
callbackRouter.registerExact('view_ip', async (cq) => {
logDebug(cq.data, 'handleViewIP');
await adminLocationHandler.handleViewIP(cq);
});
callbackRouter.registerExact('delete_location', async (cq) => {
logDebug(cq.data, 'handleDeleteLocation');
await adminLocationHandler.handleDeleteLocation(cq);
});
callbackRouter.registerExact('admin_menu', async (cq) => {
logDebug(cq.data, 'backToMenu');
await adminLocationHandler.backToMenu(cq);
});
callbackRouter.registerExact('manage_products', async (cq) => {
logDebug(cq.data, 'handleProductManagement');
await productHandler.handleProductManagement(cq);
});
callbackRouter.registerExact('export_database', async (cq) => {
logDebug(cq.data, 'handleExportDatabase');
await adminDumpHandler.handleExportDatabase(cq);
});
callbackRouter.registerExact('import_database', async (cq) => {
logDebug(cq.data, 'handleImportDatabase');
await adminDumpHandler.handleImportDatabase(cq);
});
callbackRouter.registerExact('back_to_wallet_types', async (cq) => {
logDebug(cq.data, 'handleBackToWalletTypes');
await adminWalletsHandler.handleBackToWalletTypes(cq);
});
// === Prefix Callback Routes ===
callbackRouter.registerPrefix('set_country_', async (cq) => {
logDebug(cq.data, 'handleSetCountry');
await userLocationHandler.handleSetCountry(cq);
});
callbackRouter.registerPrefix('set_city_', async (cq) => {
logDebug(cq.data, 'handleSetCity');
await userLocationHandler.handleSetCity(cq);
});
callbackRouter.registerPrefix('set_district_', async (cq) => {
logDebug(cq.data, 'handleSetDistrict');
await userLocationHandler.handleSetDistrict(cq);
});
callbackRouter.registerPrefix('generate_wallet_', async (cq) => {
logDebug(cq.data, 'handleGenerateWallet');
await userWalletsHandler.handleGenerateWallet(cq);
});
callbackRouter.registerPrefix('shop_country_', async (cq) => {
logDebug(cq.data, 'handleCountrySelection');
await userProductHandler.handleCountrySelection(cq);
});
callbackRouter.registerPrefix('shop_city_', async (cq) => {
logDebug(cq.data, 'handleCitySelection');
await userProductHandler.handleCitySelection(cq);
});
callbackRouter.registerPrefix('shop_district_', async (cq) => {
logDebug(cq.data, 'handleDistrictSelection');
await userProductHandler.handleDistrictSelection(cq);
});
callbackRouter.registerPrefix('shop_category_', async (cq) => {
logDebug(cq.data, 'handleCategorySelection');
await userProductHandler.handleCategorySelection(cq);
});
callbackRouter.registerPrefix('shop_product_', async (cq) => {
logDebug(cq.data, 'handleProductSelection');
await userProductHandler.handleProductSelection(cq);
});
callbackRouter.registerPrefix('increase_quantity_', async (cq) => {
logDebug(cq.data, 'handleIncreaseQuantity');
await userProductHandler.handleIncreaseQuantity(cq);
});
callbackRouter.registerPrefix('decrease_quantity_', async (cq) => {
logDebug(cq.data, 'handleDecreaseQuantity');
await userProductHandler.handleDecreaseQuantity(cq);
});
callbackRouter.registerPrefix('buy_product_', async (cq) => {
logDebug(cq.data, 'handleBuyProduct');
await userProductHandler.handleBuyProduct(cq);
});
callbackRouter.registerPrefix('pay_with_', async (cq) => {
logDebug(cq.data, 'handlePay');
await userProductHandler.handlePay(cq);
});
callbackRouter.registerPrefix('list_purchases_', async (cq) => {
logDebug(cq.data, 'handlePurchaseListPage');
await userPurchaseHandler.handlePurchaseListPage(cq);
});
callbackRouter.registerPrefix('view_purchase_', async (cq) => {
logDebug(cq.data, 'viewPurchase');
await userPurchaseHandler.viewPurchase(cq);
});
callbackRouter.registerPrefix('confirm_received_', async (cq) => {
logDebug(cq.data, 'handleConfirmReceived');
await userPurchaseHandler.handleConfirmReceived(cq);
});
callbackRouter.registerPrefix('confirm_delete_location_', async (cq) => {
logDebug(cq.data, 'handleConfirmDelete');
await adminLocationHandler.handleConfirmDelete(cq);
});
callbackRouter.registerPrefix('prod_country_', async (cq) => {
logDebug(cq.data, 'handleCountrySelection');
await productHandler.handleCountrySelection(cq);
});
callbackRouter.registerPrefix('prod_city_', async (cq) => {
logDebug(cq.data, 'handleCitySelection');
await productHandler.handleCitySelection(cq);
});
callbackRouter.registerPrefix('prod_district_', async (cq) => {
logDebug(cq.data, 'handleDistrictSelection');
await productHandler.handleDistrictSelection(cq);
});
callbackRouter.registerPrefix('add_category_', async (cq) => {
logDebug(cq.data, 'handleAddCategory');
await productHandler.handleAddCategory(cq);
});
callbackRouter.registerPrefix('edit_category_', async (cq) => {
logDebug(cq.data, 'handleEditCategory');
await productHandler.handleEditCategory(cq);
});
callbackRouter.registerPrefix('prod_category_', async (cq) => {
logDebug(cq.data, 'handleCategorySelection');
await productHandler.handleCategorySelection(cq);
});
callbackRouter.registerPrefix('list_products_', async (cq) => {
logDebug(cq.data, 'handleProductListPage');
await productHandler.handleProductListPage(cq);
});
callbackRouter.registerPrefix('add_product_', async (cq) => {
logDebug(cq.data, 'handleAddProduct');
await productHandler.handleAddProduct(cq);
});
callbackRouter.registerPrefix('view_product_', async (cq) => {
logDebug(cq.data, 'handleViewProduct');
await productHandler.handleViewProduct(cq);
});
callbackRouter.registerPrefix('edit_product_', async (cq) => {
logDebug(cq.data, 'handleProductEdit');
await productHandler.handleProductEdit(cq);
});
callbackRouter.registerPrefix('delete_product_', async (cq) => {
logDebug(cq.data, 'handleProductDelete');
await productHandler.handleProductDelete(cq);
});
callbackRouter.registerPrefix('confirm_delete_product_', async (cq) => {
logDebug(cq.data, 'handleConfirmDelete');
await productHandler.handleConfirmDelete(cq);
});
callbackRouter.registerPrefix('view_user_', async (cq) => {
logDebug(cq.data, 'handleViewUser');
await adminUserHandler.handleViewUser(cq);
});
callbackRouter.registerPrefix('list_users_', async (cq) => {
logDebug(cq.data, 'handleUserListPage');
await adminUserHandler.handleUserListPage(cq);
});
callbackRouter.registerPrefix('delete_user_', async (cq) => {
logDebug(cq.data, 'handleDeleteUser');
await adminUserHandler.handleDeleteUser(cq);
});
callbackRouter.registerPrefix('block_user_', async (cq) => {
logDebug(cq.data, 'handleBlockUser');
await adminUserHandler.handleBlockUser(cq);
});
callbackRouter.registerPrefix('confirm_delete_user_', async (cq) => {
logDebug(cq.data, 'handleConfirmDelete');
await adminUserHandler.handleConfirmDelete(cq);
});
callbackRouter.registerPrefix('confirm_block_user_', async (cq) => {
logDebug(cq.data, 'handleConfirmBlock');
await adminUserHandler.handleConfirmBlock(cq);
});
callbackRouter.registerPrefix('edit_user_balance_', async (cq) => {
logDebug(cq.data, 'handleEditUserBalance');
await adminUserHandler.handleEditUserBalance(cq);
});
callbackRouter.registerPrefix('edit_user_location_', async (cq) => {
logDebug(cq.data, 'handleEditUserLocation');
await adminUserLocationHandler.handleEditUserLocation(cq);
});
callbackRouter.registerPrefix('edit_user_country_', async (cq) => {
logDebug(cq.data, 'handleEditUserCountry');
await adminUserLocationHandler.handleEditUserCountry(cq);
});
callbackRouter.registerPrefix('edit_user_city_', async (cq) => {
logDebug(cq.data, 'handleEditUserCity');
await adminUserLocationHandler.handleEditUserCity(cq);
});
callbackRouter.registerPrefix('edit_user_district_', async (cq) => {
logDebug(cq.data, 'handleEditUserDistrict');
await adminUserLocationHandler.handleEditUserDistrict(cq);
});
callbackRouter.registerPrefix('wallet_type_', async (cq) => {
logDebug(cq.data, 'handleWalletTypeSelection');
await adminWalletsHandler.handleWalletTypeSelection(cq);
});
callbackRouter.registerPrefix('check_balance_', async (cq) => {
logDebug(cq.data, 'handleCheckCommissionBalance');
await adminWalletsHandler.handleCheckCommissionBalance(cq);
});
callbackRouter.registerPrefix('prev_page_', async (cq) => {
logDebug(cq.data, 'handlePagination');
await adminWalletsHandler.handlePagination(cq);
});
callbackRouter.registerPrefix('next_page_', async (cq) => {
logDebug(cq.data, 'handlePagination');
await adminWalletsHandler.handlePagination(cq);
});
callbackRouter.registerPrefix('export_csv_', async (cq) => {
logDebug(cq.data, 'handleExportCSV');
await adminWalletsHandler.handleExportCSV(cq);
});
callbackRouter.registerPrefix('view_transaction_history_', async (cq) => {
logDebug(cq.data, 'handleTransactionHistory');
const page = parseInt(cq.data.split('_').pop());
await userWalletsHandler.handleTransactionHistory(cq, page);
});
}