refac: model preset handling behaviour

backend/open_webui/apps/webui/models/models.py

@@ -238,7 +238,7 @@ class ModelsTable:
                 result = (
                     db.query(Model)
                     .filter_by(id=id)
-                    .update(model.model_dump(exclude={"id"}, exclude_none=True))
+                    .update(model.model_dump(exclude={"id"}))
                 )
                 db.commit()
 

backend/open_webui/main.py

@@ -948,7 +948,7 @@ async def get_all_models():
     models = await get_all_base_models()
 
     # If there are no models, return an empty list
-    if len([model for model in models if model["owned_by"] != "arena"]) == 0:
+    if len([model for model in models if not model.get("arena", False)]) == 0:
         return []
 
     global_action_ids = [
@@ -975,7 +975,7 @@ async def get_all_models():
                         action_ids.extend(model["info"]["meta"].get("actionIds", []))
 
                     model["action_ids"] = action_ids
-        else:
+        elif custom_model.id not in [model["id"] for model in models]:
             owned_by = "openai"
             pipe = None
             action_ids = []
@@ -997,7 +997,7 @@ async def get_all_models():
 
             models.append(
                 {
-                    "id": f"open-webui.{custom_model.id}",
+                    "id": f"{custom_model.id}",
                     "name": custom_model.name,
                     "object": "model",
                     "created": custom_model.created_at,
@@ -1164,10 +1164,6 @@ async def generate_chat_completions(
                 "selected_model_id": selected_model_id,
             }
 
-    if model_id.startswith("open-webui."):
-        model_id = model_id[len("open-webui.") :]
-        form_data["model"] = model_id
-
     if model.get("pipe"):
         # Below does not require bypass_filter because this is the only route the uses this function and it is already bypassing the filter
         return await generate_function_chat_completion(form_data, user=user)

src/lib/components/admin/Settings.svelte

@@ -327,7 +327,7 @@
 		</button>
 	</div>
 
-	<div class="flex-1 mt-3 lg:mt-0 overflow-y-scroll">
+	<div class="flex-1 mt-3 lg:mt-0 overflow-y-scroll pr-1 scrollbar-hidden">
 		{#if selectedTab === 'general'}
 			<General
 				saveHandler={async () => {

src/lib/components/admin/Settings/Models.svelte

@@ -20,12 +20,20 @@
 	import Switch from '$lib/components/common/Switch.svelte';
 	import Spinner from '$lib/components/common/Spinner.svelte';
 
+	import ModelEditor from '$lib/components/workspace/Models/ModelEditor.svelte';
+
 	let importFiles;
 	let modelsImportInputElement: HTMLInputElement;
 
 	let models = null;
+
+	let workspaceModels = null;
+	let baseModels = null;
+
 	let filteredModels = [];
 
+	let selectedModelId = null;
+
 	$: if (models) {
 		filteredModels = models.filter(
 			(m) => searchValue === '' || m.name.toLowerCase().includes(searchValue.toLowerCase())
@@ -42,31 +50,68 @@
 	};
 
 	const init = async () => {
-		const workspaceModels = await getBaseModels(localStorage.token);
+		workspaceModels = await getBaseModels(localStorage.token);
-		const allModels = await getModels(localStorage.token, true);
+		baseModels = await getModels(localStorage.token, true);
 
-		models = allModels
+		models = baseModels.map((m) => {
-			.filter((m) => !(m?.preset ?? false))
-			.map((m) => {
 			const workspaceModel = workspaceModels.find((wm) => wm.id === m.id);
 
 			if (workspaceModel) {
 				return workspaceModel;
 			} else {
 				return {
-						...m,
+					id: m.id,
+					name: m.name,
 					is_active: true
 				};
 			}
 		});
 	};
 
+	const upsertModelHandler = async (model) => {
+		model.base_model_id = null;
+
+		if (models.find((m) => m.id === model.id)) {
+			await updateModelById(localStorage.token, model.id, model).catch((error) => {
+				return null;
+			});
+		} else {
+			await createNewModel(localStorage.token, model).catch((error) => {
+				return null;
+			});
+		}
+
+		await init();
+	};
+
+	const toggleModelHandler = async (model) => {
+		if (!Object.keys(model).includes('base_model_id')) {
+			await createNewModel(localStorage.token, {
+				id: model.id,
+				name: model.name,
+				base_model_id: null,
+				meta: {},
+				params: {},
+				is_active: model.is_active
+			}).catch((error) => {
+				return null;
+			});
+
+			await init();
+		} else {
+			await toggleModelById(localStorage.token, model.id);
+		}
+
+		_models.set(await getModels(localStorage.token));
+	};
+
 	onMount(async () => {
 		init();
 	});
 </script>
 
 {#if models !== null}
+	{#if selectedModelId === null}
 		<div class="flex flex-col gap-1 mt-1.5 mb-2">
 			<div class="flex justify-between items-center">
 				<div class="flex items-center md:self-center text-xl font-medium px-0.5">
@@ -93,14 +138,18 @@
 		</div>
 
 		<div class=" my-2 mb-5" id="model-list">
+			{#if models.length > 0}
 				{#each filteredModels as model (model.id)}
 					<div
 						class=" flex space-x-4 cursor-pointer w-full px-3 py-2 dark:hover:bg-white/5 hover:bg-black/5 rounded-lg transition"
 						id="model-item-{model.id}"
 					>
-				<a
+						<button
-					class=" flex flex-1 space-x-3.5 cursor-pointer w-full"
+							class=" flex flex-1 text-left space-x-3.5 cursor-pointer w-full"
-					href={`/?models=open-webui.${encodeURIComponent(model.id)}`}
+							type="button"
+							on:click={() => {
+								selectedModelId = model.id;
+							}}
 						>
 							<div class=" self-center w-8">
 								<div
@@ -128,13 +177,14 @@
 									{model?.meta?.description ?? model.id}
 								</div>
 							</div>
-				</a>
+						</button>
 						<div class="flex flex-row gap-0.5 items-center self-center">
-					{#if $user?.role === 'admin' || model.user_id === $user?.id}
+							<button
-						<a
 								class="self-center w-fit text-sm px-2 py-2 dark:text-gray-300 dark:hover:text-white hover:bg-black/5 dark:hover:bg-white/5 rounded-xl"
 								type="button"
-							href={`/workspace/models/edit?id=${encodeURIComponent(model.id)}`}
+								on:click={() => {
+									selectedModelId = model.id;
+								}}
 							>
 								<svg
 									xmlns="http://www.w3.org/2000/svg"
@@ -150,8 +200,7 @@
 										d="m16.862 4.487 1.687-1.688a1.875 1.875 0 1 1 2.652 2.652L6.832 19.82a4.5 4.5 0 0 1-1.897 1.13l-2.685.8.8-2.685a4.5 4.5 0 0 1 1.13-1.897L16.863 4.487Zm0 0L19.5 7.125"
 									/>
 								</svg>
-						</a>
+							</button>
-					{/if}
 
 							<div class="ml-1">
 								<Tooltip
@@ -159,9 +208,8 @@
 								>
 									<Switch
 										bind:state={model.is_active}
-								on:change={async (e) => {
+										on:change={async () => {
-									toggleModelById(localStorage.token, model.id);
+											toggleModelHandler(model);
-									_models.set(await getModels(localStorage.token));
 										}}
 									/>
 								</Tooltip>
@@ -169,6 +217,13 @@
 						</div>
 					</div>
 				{/each}
+			{:else}
+				<div class="flex flex-col items-center justify-center w-full h-20">
+					<div class="text-gray-500 dark:text-gray-400 text-xs">
+						{$i18n.t('No models found')}
+					</div>
+				</div>
+			{/if}
 		</div>
 
 		{#if $user?.role === 'admin'}
@@ -190,17 +245,15 @@
 								console.log(savedModels);
 
 								for (const model of savedModels) {
-								if (model?.info ?? false) {
+									if (Object.keys(model).includes('base_model_id')) {
-									if ($_models.find((m) => m.id === model.id)) {
+										if (model.base_model_id === null) {
-										await updateModelById(localStorage.token, model.id, model.info).catch(
+											upsertModelHandler(model);
-											(error) => {
-												return null;
 										}
-										);
 									} else {
-										await createNewModel(localStorage.token, model.info).catch((error) => {
+										if (model?.info ?? false) {
-											return null;
+											if (model.info.base_model_id === null) {
-										});
+												upsertModelHandler(model.info);
+											}
 										}
 									}
 								}
@@ -219,7 +272,9 @@
 							modelsImportInputElement.click();
 						}}
 					>
-					<div class=" self-center mr-2 font-medium line-clamp-1">{$i18n.t('Import Presets')}</div>
+						<div class=" self-center mr-2 font-medium line-clamp-1">
+							{$i18n.t('Import Presets')}
+						</div>
 
 						<div class=" self-center">
 							<svg
@@ -240,10 +295,12 @@
 					<button
 						class="flex text-xs items-center space-x-1 px-3 py-1.5 rounded-xl bg-gray-50 hover:bg-gray-100 dark:bg-gray-800 dark:hover:bg-gray-700 dark:text-gray-200 transition"
 						on:click={async () => {
-						downloadModels($_models);
+							downloadModels(models);
 						}}
 					>
-					<div class=" self-center mr-2 font-medium line-clamp-1">{$i18n.t('Export Presets')}</div>
+						<div class=" self-center mr-2 font-medium line-clamp-1">
+							{$i18n.t('Export Presets')}
+						</div>
 
 						<div class=" self-center">
 							<svg
@@ -263,6 +320,21 @@
 				</div>
 			</div>
 		{/if}
+	{:else}
+		<ModelEditor
+			edit
+			model={models.find((m) => m.id === selectedModelId)}
+			preset={false}
+			onSubmit={(model) => {
+				console.log(model);
+				upsertModelHandler(model);
+				selectedModelId = null;
+			}}
+			onBack={() => {
+				selectedModelId = null;
+			}}
+		/>
+	{/if}
 {:else}
 	<div class=" h-full w-full flex justify-center items-center">
 		<Spinner />

src/lib/components/workspace/Knowledge.svelte

@@ -10,15 +10,10 @@
 	const i18n = getContext('i18n');
 
 	import { WEBUI_NAME, knowledge } from '$lib/stores';
-
 	import { getKnowledgeItems, deleteKnowledgeById } from '$lib/apis/knowledge';
 
-	import { blobToFile, transformFileName } from '$lib/utils';
-
 	import { goto } from '$app/navigation';
-	import Tooltip from '../common/Tooltip.svelte';
+
-	import GarbageBin from '../icons/GarbageBin.svelte';
-	import Pencil from '../icons/Pencil.svelte';
 	import DeleteConfirmDialog from '../common/ConfirmDialog.svelte';
 	import ItemMenu from './Knowledge/ItemMenu.svelte';
 	import Badge from '../common/Badge.svelte';

src/lib/components/workspace/Models/ModelEditor.svelte

@@ -1,8 +1,4 @@
 <script lang="ts">
-	import { v4 as uuidv4 } from 'uuid';
-	import { toast } from 'svelte-sonner';
-	import { goto } from '$app/navigation';
-
 	import { onMount, getContext, tick } from 'svelte';
 	import { models, tools, functions, knowledge as knowledgeCollections } from '$lib/stores';
 
@@ -22,8 +18,11 @@
 	const i18n = getContext('i18n');
 
 	export let onSubmit: Function;
+	export let onBack: null | Function = null;
+
 	export let model = null;
 	export let edit = false;
+
 	export let preset = true;
 
 	let loading = false;
@@ -234,6 +233,31 @@
 </script>
 
 {#if loaded}
+	{#if onBack}
+		<button
+			class="flex space-x-1"
+			on:click={() => {
+				onBack();
+			}}
+		>
+			<div class=" self-center">
+				<svg
+					xmlns="http://www.w3.org/2000/svg"
+					viewBox="0 0 20 20"
+					fill="currentColor"
+					class="h-4 w-4"
+				>
+					<path
+						fill-rule="evenodd"
+						d="M17 10a.75.75 0 01-.75.75H5.612l4.158 3.96a.75.75 0 11-1.04 1.08l-5.5-5.25a.75.75 0 010-1.08l5.5-5.25a.75.75 0 111.04 1.08L5.612 9.25H16.25A.75.75 0 0117 10z"
+						clip-rule="evenodd"
+					/>
+				</svg>
+			</div>
+			<div class=" self-center text-sm font-medium">{'Back'}</div>
+		</button>
+	{/if}
+
 	<div class="w-full max-h-full flex justify-center">
 		<input
 			bind:this={filesInputElement}
@@ -302,7 +326,7 @@
 			}}
 		/>
 
-		{#if !edit || model}
+		{#if !edit || (edit && model)}
 			<form
 				class="flex flex-col md:flex-row w-full gap-3 md:gap-6"
 				on:submit|preventDefault={() => {

src/lib/components/workspace/common/AccessControl.svelte

@@ -1,4 +1,6 @@
 <script lang="ts">
+	import Tooltip from '$lib/components/common/Tooltip.svelte';
+	import Plus from '$lib/components/icons/Plus.svelte';
 	import { getContext, onMount } from 'svelte';
 	const i18n = getContext('i18n');
 
@@ -104,6 +106,16 @@
 							bind:value={query}
 							placeholder={$i18n.t('Add user or groups')}
 						/>
+						<div>
+							<Tooltip content={$i18n.t('Add User/Group')}>
+								<button
+									class=" p-2 rounded-xl hover:bg-gray-100 dark:bg-gray-900 dark:hover:bg-gray-850 transition font-medium text-sm flex items-center space-x-1"
+									on:click={() => {}}
+								>
+									<Plus className="size-3.5" />
+								</button>
+							</Tooltip>
+						</div>
 					</div>
 				</div>
 			</div>