refac: feedback

This commit is contained in:
Timothy J. Baek
2024-10-22 22:55:34 -07:00
parent bc95e62600
commit ce85400817
10 changed files with 753 additions and 132 deletions

View File

@@ -2,19 +2,24 @@
import { onMount, getContext } from 'svelte';
import { models } from '$lib/stores';
import GarbageBin from '../icons/GarbageBin.svelte';
import FeedbackMenu from './Evaluations/FeedbackMenu.svelte';
import EllipsisHorizontal from '../icons/EllipsisHorizontal.svelte';
import { getAllFeedbacks } from '$lib/apis/evaluations';
const i18n = getContext('i18n');
let rankedModels = [];
let feedbacks = [];
let loaded = false;
onMount(() => {
loaded = true;
onMount(async () => {
feedbacks = await getAllFeedbacks(localStorage.token);
rankedModels = $models
.filter((m) => m?.owned_by !== 'arena' && (m?.info?.meta?.hidden ?? false) !== true)
.map((model) => {
return {
...model,
ranking: '-',
rating: '-',
stats: {
won: '-',
@@ -34,11 +39,13 @@
// If both ratings are '-', sort alphabetically (by 'name')
return a.name.localeCompare(b.name);
});
loaded = true;
});
</script>
{#if loaded}
<div class="mt-0.5 mb-3 gap-1 flex flex-col md:flex-row justify-between">
<div class="mt-0.5 mb-2 gap-1 flex flex-col md:flex-row justify-between">
<div class="flex md:self-center text-lg font-medium px-0.5">
{$i18n.t('Leaderboard')}
@@ -52,75 +59,164 @@
<div
class="scrollbar-hidden relative whitespace-nowrap overflow-x-auto max-w-full rounded pt-0.5"
>
<table
class="w-full text-sm text-left text-gray-500 dark:text-gray-400 table-auto max-w-full rounded"
>
<thead
class="text-xs text-gray-700 uppercase bg-gray-50 dark:bg-gray-850 dark:text-gray-400 -translate-y-0.5"
{#if (rankedModels ?? []).length === 0}
<div class="text-center text-xs text-gray-500 dark:text-gray-400 py-1">
{$i18n.t('No models found')}
</div>
{:else}
<table
class="w-full text-sm text-left text-gray-500 dark:text-gray-400 table-auto max-w-full rounded"
>
<tr class="">
<th scope="col" class="px-3 py-1.5 cursor-pointer select-none">
{$i18n.t('Model')}
</th>
<th scope="col" class="px-3 py-1.5 text-right cursor-pointer select-none">
{$i18n.t('Rating')}
</th>
<th scope="col" class="px-3 py-1.5 text-right cursor-pointer select-none w-fit">
{$i18n.t('Won')}
</th>
<thead
class="text-xs text-gray-700 uppercase bg-gray-50 dark:bg-gray-850 dark:text-gray-400 -translate-y-0.5"
>
<tr class="">
<th scope="col" class="px-3 py-1.5 cursor-pointer select-none w-3">
{$i18n.t('RK')}
</th>
<th scope="col" class="px-3 py-1.5 cursor-pointer select-none">
{$i18n.t('Model')}
</th>
<th scope="col" class="px-3 py-1.5 text-right cursor-pointer select-none w-fit">
{$i18n.t('Rating')}
</th>
<th scope="col" class="px-3 py-1.5 text-right cursor-pointer select-none w-fit">
{$i18n.t('Won')}
</th>
<th scope="col" class="px-3 py-1.5 text-right cursor-pointer select-none w-fit">
{$i18n.t('Draw')}
</th>
<th scope="col" class="px-3 py-1.5 text-right cursor-pointer select-none w-fit">
{$i18n.t('Lost')}
</th>
</tr>
</thead>
<tbody class="">
{#each rankedModels as model (model.id)}
<tr class="bg-white dark:bg-gray-900 dark:border-gray-850 text-xs">
<td class="px-3 py-1 flex flex-col justify-center">
<div class="flex items-center gap-2">
<div class="flex-shrink-0">
<img
src={model?.info?.meta?.profile_image_url ?? '/favicon.png'}
alt={model.name}
class="size-6 rounded-full object-cover shrink-0"
/>
</div>
<div class="font-medium text-gray-600 dark:text-gray-400 pr-4">
{model.name}
</div>
</div>
</td>
<td class="px-3 py-1 text-right font-medium text-gray-900 dark:text-white w-max">
{model.rating}
</td>
<td class=" px-3 py-1 text-right font-semibold text-green-500"> {model.stats.won} </td>
<td class=" px-3 py-1 text-right font-semibold">
{model.stats.draw}
</td>
<td class="px-3 py-1 text-right font-semibold text-red-500">
{model.stats.lost}
</td>
<th scope="col" class="px-3 py-1.5 text-right cursor-pointer select-none w-fit">
{$i18n.t('Draw')}
</th>
<th scope="col" class="px-3 py-1.5 text-right cursor-pointer select-none w-fit">
{$i18n.t('Lost')}
</th>
</tr>
{/each}
</tbody>
</table>
</thead>
<tbody class="">
{#each rankedModels as model (model.id)}
<tr class="bg-white dark:bg-gray-900 dark:border-gray-850 text-xs">
<td class="px-3 py-1.5 text-left font-medium text-gray-900 dark:text-white w-fit">
<div class=" line-clamp-1">
{model.ranking}
</div>
</td>
<td class="px-3 py-1.5 flex flex-col justify-center">
<div class="flex items-center gap-2">
<div class="flex-shrink-0">
<img
src={model?.info?.meta?.profile_image_url ?? '/favicon.png'}
alt={model.name}
class="size-5 rounded-full object-cover shrink-0"
/>
</div>
<div class="font-medium text-gray-800 dark:text-gray-200 pr-4">
{model.name}
</div>
</div>
</td>
<td class="px-3 py-1.5 text-right font-medium text-gray-900 dark:text-white w-max">
{model.rating}
</td>
<td class=" px-3 py-1.5 text-right font-semibold text-green-500">
{model.stats.won}
</td>
<td class=" px-3 py-1.5 text-right font-semibold">
{model.stats.draw}
</td>
<td class="px-3 py-1.5 text-right font-semibold text-red-500">
{model.stats.lost}
</td>
</tr>
{/each}
</tbody>
</table>
{/if}
</div>
<div class="pb-4"></div>
<div class="mt-0.5 mb-3 gap-1 flex flex-col md:flex-row justify-between">
<div class="mt-0.5 mb-2 gap-1 flex flex-col md:flex-row justify-between">
<div class="flex md:self-center text-lg font-medium px-0.5">
{$i18n.t('Rating History')}
{$i18n.t('Feedback History')}
</div>
</div>
<div
class="scrollbar-hidden relative whitespace-nowrap overflow-x-auto max-w-full rounded pt-0.5"
>
{#if (feedbacks ?? []).length === 0}
<div class="text-center text-xs text-gray-500 dark:text-gray-400 py-1">
{$i18n.t('No feedbacks found')}
</div>
{:else}
<table
class="w-full text-sm text-left text-gray-500 dark:text-gray-400 table-auto max-w-full rounded"
>
<thead
class="text-xs text-gray-700 uppercase bg-gray-50 dark:bg-gray-850 dark:text-gray-400 -translate-y-0.5"
>
<tr class="">
<th scope="col" class="px-3 py-1.5 cursor-pointer select-none">
{$i18n.t('Models')}
</th>
<th scope="col" class="px-3 py-1.5 text-right cursor-pointer select-none w-fit">
{$i18n.t('Result')}
</th>
<th scope="col" class="px-3 py-1.5 text-right cursor-pointer select-none w-0">
{$i18n.t('User')}
</th>
<th scope="col" class="px-3 py-1.5 text-right cursor-pointer select-none w-0">
{$i18n.t('Created At')}
</th>
<th scope="col" class="px-3 py-1.5 text-right cursor-pointer select-none w-0"> </th>
</tr>
</thead>
<tbody class="">
{#each feedbacks as feedback (feedback.id)}
<tr class="bg-white dark:bg-gray-900 dark:border-gray-850 text-xs">
<td class="px-3 py-1 flex flex-col">
<div class="flex flex-col items-start gap-1">
<div class="font-medium text-gray-600 dark:text-gray-400">
{model.name}
</div>
<div class="font-medium text-gray-600 dark:text-gray-400">
{model.name}
</div>
</div>
</td>
<td class="px-3 py-1 text-right font-medium text-gray-900 dark:text-white w-max">
{model.rating}
</td>
<td class=" px-3 py-1 text-right font-semibold"> {model.stats.won} </td>
<td class=" px-3 py-1 text-right font-semibold">
{model.stats.draw}
</td>
<td class=" px-3 py-1 text-right font-semibold">
<FeedbackMenu>
<button
class="self-center w-fit text-sm p-1.5 dark:text-gray-300 dark:hover:text-white hover:bg-black/5 dark:hover:bg-white/5 rounded-xl"
>
<EllipsisHorizontal />
</button>
</FeedbackMenu>
</td>
</tr>
{/each}
</tbody>
</table>
{/if}
</div>
<div class="pb-8"></div>
{/if}

View File

@@ -0,0 +1,46 @@
<script lang="ts">
import { DropdownMenu } from 'bits-ui';
import { flyAndScale } from '$lib/utils/transitions';
import { getContext, createEventDispatcher } from 'svelte';
import fileSaver from 'file-saver';
const { saveAs } = fileSaver;
const dispatch = createEventDispatcher();
const i18n = getContext('i18n');
import Dropdown from '$lib/components/common/Dropdown.svelte';
import GarbageBin from '$lib/components/icons/GarbageBin.svelte';
import Pencil from '$lib/components/icons/Pencil.svelte';
import Tooltip from '$lib/components/common/Tooltip.svelte';
import Download from '$lib/components/icons/Download.svelte';
let show = false;
</script>
<Dropdown bind:show on:change={(e) => {}}>
<Tooltip content={$i18n.t('More')}>
<slot />
</Tooltip>
<div slot="content">
<DropdownMenu.Content
class="w-full max-w-[150px] rounded-xl px-1 py-1.5 z-50 bg-white dark:bg-gray-850 dark:text-white shadow-lg"
sideOffset={-2}
side="bottom"
align="start"
transition={flyAndScale}
>
<DropdownMenu.Item
class="flex gap-2 items-center px-3 py-1.5 text-sm cursor-pointer hover:bg-gray-50 dark:hover:bg-gray-800 rounded-md"
on:click={() => {
dispatch('delete');
show = false;
}}
>
<GarbageBin strokeWidth="2" />
<div class="flex items-center">{$i18n.t('Delete')}</div>
</DropdownMenu.Item>
</DropdownMenu.Content>
</div>
</Dropdown>

View File

@@ -66,6 +66,7 @@
/>
{:else if (history.messages[history.messages[messageId].parentId]?.models?.length ?? 1) === 1}
<ResponseMessage
{chatId}
{history}
{messageId}
isLastMessage={messageId === history.currentId}

View File

@@ -200,6 +200,7 @@
{#key history.currentId}
{#if message}
<ResponseMessage
{chatId}
{history}
messageId={_messageId}
isLastMessage={true}

View File

@@ -40,6 +40,8 @@
import type { Writable } from 'svelte/store';
import type { i18n as i18nType } from 'i18next';
import ContentRenderer from './ContentRenderer.svelte';
import { createNewFeedback, getFeedbackById, updateFeedbackById } from '$lib/apis/evaluations';
import { getChatById } from '$lib/apis/chats';
interface MessageType {
id: string;
@@ -92,6 +94,7 @@
annotation?: { type: string; rating: number };
}
export let chatId = '';
export let history;
export let messageId;
@@ -330,6 +333,80 @@
generatingImage = false;
};
const feedbackHandler = async (
rating: number | null = null,
annotation: object | null = null
) => {
console.log('Feedback', rating, annotation);
const updatedMessage = {
...message,
annotation: {
...(message?.annotation ?? {}),
...(rating !== null ? { rating: rating } : {}),
...(annotation ? annotation : {})
}
};
const chat = await getChatById(localStorage.token, chatId).catch((error) => {
toast.error(error);
});
if (!chat) {
return;
}
let feedbackItem = {
type: 'rating',
data: {
...(updatedMessage?.annotation ? updatedMessage.annotation : {}),
model_id: message?.selectedModelId ?? message.model,
...(history.messages[message.parentId].childrenIds.length > 1
? {
sibling_model_ids: history.messages[message.parentId].childrenIds
.filter((id) => id !== message.id)
.map((id) => history.messages[id]?.selectedModelId ?? history.messages[id].model)
}
: {})
},
meta: {
arena: message ? message.arena : false,
message_id: message.id,
chat_id: chatId
},
snapshot: {
chat: chat
}
};
let feedback = null;
if (message?.feedbackId) {
feedback = await updateFeedbackById(
localStorage.token,
message.feedbackId,
feedbackItem
).catch((error) => {
toast.error(error);
});
} else {
feedback = await createNewFeedback(localStorage.token, feedbackItem).catch((error) => {
toast.error(error);
});
if (feedback) {
updatedMessage.feedbackId = feedback.id;
}
}
console.log(updatedMessage);
dispatch('save', updatedMessage);
await tick();
if (!annotation) {
showRateComment = true;
}
};
$: if (!edit) {
(async () => {
await tick();
@@ -880,12 +957,13 @@
<button
class="{isLastMessage
? 'visible'
: 'invisible group-hover:visible'} p-1.5 hover:bg-black/5 dark:hover:bg-white/5 rounded-lg {(message
?.annotation?.rating ?? null) === 1
: 'invisible group-hover:visible'} p-1.5 hover:bg-black/5 dark:hover:bg-white/5 rounded-lg {(
message?.annotation?.rating ?? ''
).toString() === '1'
? 'bg-gray-100 dark:bg-gray-800'
: ''} dark:hover:text-white hover:text-black transition"
on:click={async () => {
await rateMessage(message.id, 1);
await feedbackHandler(1);
(model?.actions ?? [])
.filter((action) => action?.__webui__ ?? false)
@@ -901,7 +979,6 @@
});
});
showRateComment = true;
window.setTimeout(() => {
document
.getElementById(`message-feedback-${message.id}`)
@@ -930,12 +1007,13 @@
<button
class="{isLastMessage
? 'visible'
: 'invisible group-hover:visible'} p-1.5 hover:bg-black/5 dark:hover:bg-white/5 rounded-lg {(message
?.annotation?.rating ?? null) === -1
: 'invisible group-hover:visible'} p-1.5 hover:bg-black/5 dark:hover:bg-white/5 rounded-lg {(
message?.annotation?.rating ?? ''
).toString() === '-1'
? 'bg-gray-100 dark:bg-gray-800'
: ''} dark:hover:text-white hover:text-black transition"
on:click={async () => {
await rateMessage(message.id, -1);
await feedbackHandler(-1);
(model?.actions ?? [])
.filter((action) => action?.__webui__ ?? false)
@@ -951,7 +1029,6 @@
});
});
showRateComment = true;
window.setTimeout(() => {
document
.getElementById(`message-feedback-${message.id}`)
@@ -1103,15 +1180,12 @@
<RateComment
bind:message
bind:show={showRateComment}
on:save={(e) => {
dispatch('save', {
...message,
annotation: {
...message.annotation,
comment: e.detail.comment,
reason: e.detail.reason
}
on:save={async (e) => {
await feedbackHandler(null, {
comment: e.detail.comment,
reason: e.detail.reason
});
(model?.actions ?? [])
.filter((action) => action?.__webui__ ?? false)
.forEach((action) => {