From 48637893b1f6ef95e00086d75a3d5ccf6d747acb Mon Sep 17 00:00:00 2001 From: Timothy Jaeryang Baek Date: Sat, 19 Apr 2025 04:09:46 -0700 Subject: [PATCH] fix: scroll on branch change w/ multi response chat --- src/lib/components/chat/Chat.svelte | 8 +++++--- .../chat/Messages/MultiResponseMessages.svelte | 15 ++++++++------- src/lib/components/chat/Settings/Interface.svelte | 2 +- 3 files changed, 14 insertions(+), 11 deletions(-) diff --git a/src/lib/components/chat/Chat.svelte b/src/lib/components/chat/Chat.svelte index fb9faa247..b0f806452 100644 --- a/src/lib/components/chat/Chat.svelte +++ b/src/lib/components/chat/Chat.svelte @@ -236,9 +236,11 @@ await tick(); await tick(); - const messageElement = document.getElementById(`message-${message.id}`); - if (messageElement) { - messageElement.scrollIntoView({ behavior: 'smooth' }); + if ($settings?.scrollOnBranchChange ?? true) { + const messageElement = document.getElementById(`message-${message.id}`); + if (messageElement) { + messageElement.scrollIntoView({ behavior: 'smooth' }); + } } await tick(); diff --git a/src/lib/components/chat/Messages/MultiResponseMessages.svelte b/src/lib/components/chat/Messages/MultiResponseMessages.svelte index c46be0e83..cfa43cdb1 100644 --- a/src/lib/components/chat/Messages/MultiResponseMessages.svelte +++ b/src/lib/components/chat/Messages/MultiResponseMessages.svelte @@ -200,9 +200,11 @@ await initHandler(); await tick(); - const messageElement = document.getElementById(`message-${messageId}`); - if (messageElement) { - messageElement.scrollIntoView({ block: 'start' }); + if ($settings?.scrollOnBranchChange ?? true) { + const messageElement = document.getElementById(`message-${messageId}`); + if (messageElement) { + messageElement.scrollIntoView({ block: 'start' }); + } } }); @@ -238,10 +240,9 @@ messageChildrenIds = history.messages[currentMessageId].childrenIds; } history.currentId = currentMessageId; - - await tick(); - await updateChat(); - triggerScroll(); + // await tick(); + // await updateChat(); + // triggerScroll(); } }} > diff --git a/src/lib/components/chat/Settings/Interface.svelte b/src/lib/components/chat/Settings/Interface.svelte index c6298173a..45399e616 100644 --- a/src/lib/components/chat/Settings/Interface.svelte +++ b/src/lib/components/chat/Settings/Interface.svelte @@ -855,7 +855,7 @@
- {$i18n.t('Scroll to bottom when switching between branches')} + {$i18n.t('Scroll On Branch Change')}