From ab94017e3a5c2c2f7582cf1f716387824861e09c Mon Sep 17 00:00:00 2001 From: Elkana Bardugo Date: Mon, 17 Feb 2025 21:27:05 +0200 Subject: [PATCH 1/6] Auto text direction (fix for RTL) in most cases MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit to test it use the prompt: "write please a sample headers (level 1,2,3), text (bold/italic), list, numbered list, quetes, table, code write each example in hebrew dont output markdown in code block" need to be fixed: * Redundant border properties in quotes: Removed border-left as border-inline-start properly handles both LTR/RTL and by this prevents double borders in RTL layouts * table header have `text-align: left` instead of start e.g. text-align and direction is not the save thing the text direction is ok. the `dir="auto"` is fixing the direction שמג the text-align by default is set by the direction, if it set manually is should be start/end to respect the direction attribute --- .../chat/Messages/Markdown/MarkdownTokens.svelte | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte b/src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte index 8a3d22f73..32a4b9e87 100644 --- a/src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte +++ b/src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte @@ -169,14 +169,14 @@ {:else if token.type === 'blockquote'} -
+
{:else if token.type === 'list'} {#if token.ordered}
    {#each token.items as item, itemIdx} -
  1. +
  2. {#if item?.task} {#each token.items as item, itemIdx} -
  3. +
  4. {#if item?.task} {:else if token.type === 'paragraph'} -

    +

    {:else if token.type === 'text'} {#if top} -

    +

    {#if token.tokens} {:else} From b73b8343d58e9a29c4b6c4f991cb4015e4c8d966 Mon Sep 17 00:00:00 2001 From: Elkana Bardugo Date: Mon, 17 Feb 2025 21:40:11 +0200 Subject: [PATCH 2/6] fix table header align on rtl --- src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte b/src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte index 32a4b9e87..8dab96cf2 100644 --- a/src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte +++ b/src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte @@ -118,7 +118,7 @@ class="!px-3 !py-1.5 cursor-pointer border border-gray-50 dark:border-gray-850" style={token.align[headerIdx] ? '' : `text-align: ${token.align[headerIdx]}`} > -

    +
    Date: Mon, 17 Feb 2025 21:57:47 +0200 Subject: [PATCH 3/6] fix blockquote border line direction in RTL --- src/app.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/app.css b/src/app.css index dadfda78f..6e6d1d8b1 100644 --- a/src/app.css +++ b/src/app.css @@ -53,11 +53,11 @@ math { } .markdown-prose { - @apply prose dark:prose-invert prose-blockquote:border-gray-100 prose-blockquote:dark:border-gray-800 prose-blockquote:border-l-2 prose-blockquote:not-italic prose-blockquote:font-normal prose-headings:font-semibold prose-hr:my-4 prose-hr:border-gray-100 prose-hr:dark:border-gray-800 prose-p:my-0 prose-img:my-1 prose-headings:my-1 prose-pre:my-0 prose-table:my-0 prose-blockquote:my-0 prose-ul:-my-0 prose-ol:-my-0 prose-li:-my-0 whitespace-pre-line; + @apply prose dark:prose-invert prose-blockquote:border-s-gray-100 prose-blockquote:dark:border-gray-800 prose-blockquote:border-s-2 prose-blockquote:not-italic prose-blockquote:font-normal prose-headings:font-semibold prose-hr:my-4 prose-hr:border-gray-100 prose-hr:dark:border-gray-800 prose-p:my-0 prose-img:my-1 prose-headings:my-1 prose-pre:my-0 prose-table:my-0 prose-blockquote:my-0 prose-ul:-my-0 prose-ol:-my-0 prose-li:-my-0 whitespace-pre-line; } .markdown-prose-xs { - @apply text-xs prose dark:prose-invert prose-blockquote:border-gray-100 prose-blockquote:dark:border-gray-800 prose-blockquote:border-l-2 prose-blockquote:not-italic prose-blockquote:font-normal prose-headings:font-semibold prose-hr:my-0 prose-hr:border-gray-100 prose-hr:dark:border-gray-800 prose-p:my-0 prose-img:my-1 prose-headings:my-1 prose-pre:my-0 prose-table:my-0 prose-blockquote:my-0 prose-ul:-my-0 prose-ol:-my-0 prose-li:-my-0 whitespace-pre-line; + @apply text-xs prose dark:prose-invert prose-blockquote:border-s-gray-100 prose-blockquote:dark:border-gray-800 prose-blockquote:border-s-2 prose-blockquote:not-italic prose-blockquote:font-normal prose-headings:font-semibold prose-hr:my-0 prose-hr:border-gray-100 prose-hr:dark:border-gray-800 prose-p:my-0 prose-img:my-1 prose-headings:my-1 prose-pre:my-0 prose-table:my-0 prose-blockquote:my-0 prose-ul:-my-0 prose-ol:-my-0 prose-li:-my-0 whitespace-pre-line; } .markdown a { From 0888ddde7ccb201dae493c13378b7987ccbfa3fc Mon Sep 17 00:00:00 2001 From: Elkana Bardugo Date: Mon, 17 Feb 2025 22:03:03 +0200 Subject: [PATCH 4/6] Fix card title direction and alignment (for RTL) --- src/lib/components/layout/Sidebar/ChatItem.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/components/layout/Sidebar/ChatItem.svelte b/src/lib/components/layout/Sidebar/ChatItem.svelte index 1e9224093..7088fbd88 100644 --- a/src/lib/components/layout/Sidebar/ChatItem.svelte +++ b/src/lib/components/layout/Sidebar/ChatItem.svelte @@ -274,7 +274,7 @@ draggable="false" >
    -
    +
    {title}
    From d26569f63660629d9a596b058cdcb73fce90e079 Mon Sep 17 00:00:00 2001 From: Elkana Bardugo Date: Mon, 17 Feb 2025 22:42:37 +0200 Subject: [PATCH 5/6] Update ChatItem.svelte: Revert text-align for download button in rtl prevent button overriding because the menu button is in absolute position and it doesn't have start/end properties --- src/lib/components/layout/Sidebar/ChatItem.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/components/layout/Sidebar/ChatItem.svelte b/src/lib/components/layout/Sidebar/ChatItem.svelte index 2acf29045..c622b2732 100644 --- a/src/lib/components/layout/Sidebar/ChatItem.svelte +++ b/src/lib/components/layout/Sidebar/ChatItem.svelte @@ -274,7 +274,7 @@ draggable="false" >
    -
    +
    {title}
    From 8d149348a02d79a5f4f9aaea6fc44623d665f115 Mon Sep 17 00:00:00 2001 From: Elkana Bardugo Date: Mon, 17 Feb 2025 22:43:34 +0200 Subject: [PATCH 6/6] Update MarkdownTokens.svelte: Revert text-align for download button in rtl prevent button overriding because the download button is in absolute position and it doesn't have start/end properties --- src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte b/src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte index e0aa4dd2e..36cac4d17 100644 --- a/src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte +++ b/src/lib/components/chat/Messages/Markdown/MarkdownTokens.svelte @@ -118,7 +118,7 @@ class="px-3! py-1.5! cursor-pointer border border-gray-100 dark:border-gray-850" style={token.align[headerIdx] ? '' : `text-align: ${token.align[headerIdx]}`} > -
    +