fix: send notification

backend/open_webui/models/users.py

@@ -220,7 +220,7 @@ class UsersTable:
         filter: Optional[dict] = None,
         skip: Optional[int] = None,
         limit: Optional[int] = None,
-    ) -> UserListResponse:
+    ) -> dict:
         with get_db() as db:
             query = db.query(User)
 

backend/open_webui/routers/channels.py

@@ -200,14 +200,11 @@ async def send_notification(name, webui_url, channel, message, active_user_ids):
     users = get_users_with_access("read", channel.access_control)
 
     for user in users:
-        if user.id in active_user_ids:
-            continue
-        else:
+        if user.id not in active_user_ids:
             if user.settings:
                 webhook_url = user.settings.ui.get("notifications", {}).get(
                     "webhook_url", None
                 )
-
                 if webhook_url:
                     await post_webhook(
                         name,
@@ -221,6 +218,8 @@ async def send_notification(name, webui_url, channel, message, active_user_ids):
                         },
                     )
 
+    return True
+
 
 @router.post("/{id}/messages/post", response_model=Optional[MessageModel])
 async def post_new_message(
@@ -305,14 +304,16 @@ async def post_new_message(
 
             active_user_ids = get_user_ids_from_room(f"channel:{channel.id}")
 
-            background_tasks.add_task(
-                send_notification,
-                request.app.state.WEBUI_NAME,
-                request.app.state.config.WEBUI_URL,
-                channel,
-                message,
-                active_user_ids,
-            )
+            async def background_handler():
+                await send_notification(
+                    request.app.state.WEBUI_NAME,
+                    request.app.state.config.WEBUI_URL,
+                    channel,
+                    message,
+                    active_user_ids,
+                )
+
+            background_tasks.add_task(background_handler)
 
         return MessageModel(**message.model_dump())
     except Exception as e:

backend/open_webui/utils/access_control.py

@@ -130,9 +130,10 @@ def has_access(
 # Get all users with access to a resource
 def get_users_with_access(
     type: str = "write", access_control: Optional[dict] = None
-) -> List[UserModel]:
+) -> list[UserModel]:
     if access_control is None:
-        return Users.get_users()
+        result = Users.get_users()
+        return result.get("users", [])
 
     permission_access = access_control.get(type, {})
     permitted_group_ids = permission_access.get("group_ids", [])