From d522369bed42b0eb951fce403373602c4ec447da Mon Sep 17 00:00:00 2001 From: Chocobozzz Date: Wed, 28 Dec 2022 15:15:44 +0100 Subject: [PATCH] Prevent sending log error to server on 404 --- client/src/app/core/rest/rest-extractor.service.ts | 6 +++++- client/src/root-helpers/logger.ts | 8 ++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/client/src/app/core/rest/rest-extractor.service.ts b/client/src/app/core/rest/rest-extractor.service.ts index de3f2bfff..daed7f178 100644 --- a/client/src/app/core/rest/rest-extractor.service.ts +++ b/client/src/app/core/rest/rest-extractor.service.ts @@ -87,7 +87,11 @@ export class RestExtractor { if (err.status !== undefined) { const errorMessage = this.buildServerErrorMessage(err) - logger.error(`Backend returned code ${err.status}, errorMessage is: ${errorMessage}`) + + const message = `Backend returned code ${err.status}, errorMessage is: ${errorMessage}` + + if (err.status === HttpStatusCode.NOT_FOUND_404) logger.clientError(message) + else logger.error(message) return errorMessage } diff --git a/client/src/root-helpers/logger.ts b/client/src/root-helpers/logger.ts index d1fdf73aa..618be62cd 100644 --- a/client/src/root-helpers/logger.ts +++ b/client/src/root-helpers/logger.ts @@ -27,6 +27,10 @@ class Logger { warn (message: LoggerMessage, meta?: LoggerMeta) { this.runHooks('warn', message, meta) + this.clientWarn(message, meta) + } + + clientWarn (message: LoggerMessage, meta?: LoggerMeta) { if (meta) console.warn(message, meta) else console.warn(message) } @@ -34,6 +38,10 @@ class Logger { error (message: LoggerMessage, meta?: LoggerMeta) { this.runHooks('error', message, meta) + this.clientError(message, meta) + } + + clientError (message: LoggerMessage, meta?: LoggerMeta) { if (meta) console.error(message, meta) else console.error(message) }