Dokploy/dokploy
1
0
Fork 0
mirror of https://github.com/Dokploy/dokploy synced 2025-06-26 18:27:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor temporary directory creation in web server backup: replace static path with dynamic temp directory using mkdtemp for improved file management and isolation during backup operations.

Browse Source
This commit is contained in:
Mauricio Siu
2025-03-29 23:27:13 -06:00
parent 16bfc09202
commit f20c73cdee
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/server/src/utils/backups/web-server.ts
View File

@@ -3,6 +3,9 @@ import { execAsync } from "../process/execAsync";
import { getS3Credentials } from "./utils"; import { getS3Credentials } from "./utils";
import { findDestinationById } from "@dokploy/server/services/destination"; import { findDestinationById } from "@dokploy/server/services/destination";
import { IS_CLOUD, paths } from "@dokploy/server/constants"; import { IS_CLOUD, paths } from "@dokploy/server/constants";
import { mkdtemp } from "node:fs/promises";
import { join } from "node:path";
import { tmpdir } from "node:os";
export const runWebServerBackup = async (backup: BackupSchedule) => { export const runWebServerBackup = async (backup: BackupSchedule) => {
try { try {
@@ -13,7 +16,7 @@ export const runWebServerBackup = async (backup: BackupSchedule) => {
const rcloneFlags = getS3Credentials(destination); const rcloneFlags = getS3Credentials(destination);
const timestamp = new Date().toISOString().replace(/[:.]/g, "-"); const timestamp = new Date().toISOString().replace(/[:.]/g, "-");
const { BASE_PATH } = paths(); const { BASE_PATH } = paths();
const tempDir = `${BASE_PATH}/temp-backup-${timestamp}`; const tempDir = await mkdtemp(join(tmpdir(), "dokploy-backup-"));
const backupFileName = `webserver-backup-${timestamp}.zip`; const backupFileName = `webserver-backup-${timestamp}.zip`;
const s3Path = `:s3:${destination.bucket}/${backup.prefix}${backupFileName}`; const s3Path = `:s3:${destination.bucket}/${backup.prefix}${backupFileName}`;