mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
b13586ff8e
Codex round 1 CBR-003: several docs still described compaction as an `agent/request` waterfall concern, and the implemented compaction RFC claimed "No changes to dsh-session or dsh-invariants" while the diff changed both. - Package READMEs / JSDoc (agent, agent-loop, system-prompt, compact, compact-basic): compaction now lives on the serial `agent/pre-step` seam (fired after turn/start, before step/start); the structural guard is tool-pairing balance (`isToolPairingBalanced`), not step-alignment; the convergence bound is strict (`>=` rejects). - architecture.md / core-data-structures/compaction.md: same seam + predicate + dispatch-mode updates; regenerated cordis catalog. - Implemented compaction RFC, updated in place to describe shipped reality: the seam is `agent/pre-step` (@mode serial) fired before step/start; alignment is surface tool-pairing balance; the convergence invariant rejects `>=`; and the "no dsh-session/dsh-invariants changes" claim is corrected — dsh-session gains the tool-pairing predicate and dsh-invariants drops its `start <= end` replace assertion (a positional replace makes start > end normal).
dsh-system-prompt
System prompt assembly registry. Plugins contribute ordered text sections and tool-schema providers; the agent loop calls assemble() once per step.
Service: SystemPrompt (ctx key: systemPrompt)
Public API
ctx.systemPrompt.section(section: PromptSection): () => voidContribute a section. Disposed with the calling fiber.ctx.systemPrompt.tools(provider: () => ToolSchema[]): () => voidContribute tool schemas (evaluated at each assembly). Disposed with the calling fiber.ctx.systemPrompt.assemble(): Promise<PromptAssembly>Assemble the current prompt. Runs through thesystem-prompt/assemblewaterfall.
Events
| Event | Mode | Purpose |
|---|---|---|
system-prompt/assemble |
waterfall | Mutate/extend the assembly before it reaches the model |
system-prompt/change |
emit | A section or tool provider was registered or unregistered |
Key types
PromptSection—{ name, order, text: string | (() => string) }. Sections are concatenated in ascendingorder.PromptAssembly—{ sections: PromptSection[], tools: ToolSchema[] }. Tool schemas are part of the assembly by design: "what the model is told it can do" is one coherent thing, even though adapters transmit schemas as a separate wire field.renderPrompt(assembly)— joins section texts with blank lines.
Merge-extensible: plugins can declare extra fields on PromptAssembly via declaration merging.
Extension points
- Section providers: AGENTS.md reader, cwd notifier, persona config, etc.
- Tool schema providers:
ToolRegistryregisters itself as a tool provider automatically. - The
system-prompt/assemblewaterfall: mutate or replace the assembly (system-prompt configurability, dynamic tool filtering).
What is NOT here
- Any hardcoded prompt text — every section comes from plugins.
- Prompt compaction (belongs on the
agent/pre-stepseam indsh-agent).