mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
ee4cad3ada
The bridge now holds each session's `AgentHandle` disposer in its `SessionRecord` and runs it on teardown (client disconnect or fiber dispose) instead of the old `abort()` + `whenIdle()` drain that left agents registered. A bare client disconnect now leaves NO registered agent and NO session-store entry — not an idled-but-still-registered one. The queue-aware `cancel()` inside the disposer also closes the former pre-step best-effort window (a turn about to start is dropped), so teardown reaches true quiescence. The `session/load`-races-teardown leak is fixed: if the bridge closed while `resume()` was pending, the just-resumed handle is disposed before throwing, so it leaves no orphan (it has no SessionRecord, so quiesce() never sees it). Tests: the disconnect test now asserts (through the SAME memoized teardown) that the agent is unregistered AND its session removed; a durability test re-loads the persisted log after dispose and asserts the closing turn/end is on disk (guards the teardown-order contract); a sibling-isolation test proves one handle's dispose() leaves other agents untouched. Docs: agent / agent-loop / acp READMEs, architecture.md, and the stale in-code quiesce() ownership comment updated to the per-agent disposal model; the now-resolved TODO(rfc010-agent-disposal) / TODO(rfc010-cancel-prestep) teardown notes removed.
70 lines
3.0 KiB
TypeScript
70 lines
3.0 KiB
TypeScript
import { mkdtemp, rm } from 'node:fs/promises'
|
|
import { tmpdir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
import { afterEach, describe, expect, it } from 'vitest'
|
|
import type { Context } from 'cordis'
|
|
import type { ReactLoopAgent } from '@deepseek-ai/dsh-agent-loop'
|
|
import { codingHarness, finalText, SYSTEM_PROMPT, waitForIdle } from './harness.ts'
|
|
|
|
/**
|
|
* Proves durable conversation continuity end-to-end: run 1 tells the REAL model
|
|
* a fact and persists the turn to JSONL; run 2 is a fresh harness (new Context,
|
|
* same `.sessions` root) that RESUMES the persisted session id and asks the
|
|
* model to recall the fact. The recall can only come from the rehydrated event
|
|
* log — a fresh session would have no idea. Key-gated like the other e2es.
|
|
*/
|
|
|
|
const SECRET = 'plum-galaxy-1791'
|
|
const SESSION_ID = 'resume-e2e-session'
|
|
|
|
let ctx: Context | undefined
|
|
let root: string | undefined
|
|
|
|
afterEach(async () => {
|
|
// Dispose even on failure/retry: agent-loop teardown stops the loop and the
|
|
// JSONL backend flushes; then drop the on-disk session log.
|
|
await ctx?.fiber.dispose()
|
|
ctx = undefined
|
|
if (root !== undefined) await rm(root, { recursive: true, force: true })
|
|
root = undefined
|
|
})
|
|
|
|
describe.skipIf(!process.env.DEEPSEEK_API_KEY)('resume: continue a persisted session across processes', () => {
|
|
it('recalls a fact stored in a prior, separately-disposed session', async () => {
|
|
root = await mkdtemp(join(tmpdir(), 'dsh-resume-e2e-'))
|
|
|
|
// Run 1: a fresh agent on a KNOWN session id learns a secret, then we
|
|
// dispose the whole context (simulating process exit) so only the JSONL
|
|
// log on disk survives.
|
|
ctx = await codingHarness(process.cwd(), root)
|
|
const first = ctx.agents.create({
|
|
agentId: 'resume-1',
|
|
sessionId: SESSION_ID,
|
|
agentOptions: { model: 'deepseek-v4-flash', systemPrompt: SYSTEM_PROMPT },
|
|
}).agent as ReactLoopAgent
|
|
first.send([{ type: 'text', text: `Remember this code for later: ${SECRET}. Just acknowledge it.` }])
|
|
await waitForIdle(ctx, first)
|
|
await ctx.fiber.dispose()
|
|
ctx = undefined
|
|
|
|
// Run 2: a brand-new context over the SAME root resumes the persisted
|
|
// session. The loaded event log seeds the live session, so the model sees
|
|
// run 1's exchange as conversation history.
|
|
ctx = await codingHarness(process.cwd(), root)
|
|
const resumed = (await ctx.agents.resume({
|
|
agentId: 'resume-2',
|
|
resumeSessionId: SESSION_ID,
|
|
agentOptions: { model: 'deepseek-v4-flash', systemPrompt: SYSTEM_PROMPT },
|
|
})).agent as ReactLoopAgent
|
|
expect(resumed.session.id).toBe(SESSION_ID)
|
|
// The prior user turn is in the rehydrated log before the model is asked.
|
|
expect(JSON.stringify(resumed.session.deriveMessages())).toContain(SECRET)
|
|
|
|
resumed.send([{ type: 'text', text: 'What was the code I asked you to remember? Reply with just the code.' }])
|
|
await waitForIdle(ctx, resumed)
|
|
|
|
// The model recalls it — only possible from the resumed history.
|
|
expect(finalText([...resumed.session.events])).toContain(SECRET)
|
|
}, 180_000)
|
|
})
|