mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
fb9636db44
Implements the RFC 010 MVP: a new `@deepseek-ai/dsh-acp` package bridges the harness agent to the Agent Client Protocol (JSON-RPC 2.0 over newline-delimited stdio), so Zed and other ACP editors can drive the coding agent — streaming render, tool-call display, and resumable sessions via `session/load`. - packages/acp: AgentSideConnection wiring; initialize/newSession/loadSession/ prompt/cancel; a total TurnEndReason→StopReason codec; settle-once with a fallback chain (agent/turn-end → logged turn/end → idle); single-session guard; cwd-must-equal-launch-dir validation; load replays from the persisted event log (assistant/chunk→agent_message_chunk, tool/call/result→tool_call*). - agent: add Agent.whenIdle() quiescence signal to the interface; LoopAgent implements it (resolves on the first running→idle/disposed transition). The bridge awaits it on disposal so teardown reaches quiescence, not just abort. - examples: extract the shared provider/tool core into examples/base.yml; coding-agent nest-includes it; new examples/acp-agent serves the agent over ACP with JSONL persistence and no stdout logger (stdout is the protocol). - Permission gate deferred (TODO(rfc010-permission-gate)): tools run with the executor's full authority; only the Agent→sessionId ownership seam is laid down. Cancel is best-effort for a not-yet-started queued turn (TODO(rfc010-cancel-prestep)). RFC 010 stays `proposed`. - Docs: package README + Zed snippet; client-driver cookbook section; root and packages layout/commands; RFC 010 implementation-status note. 48 bridge tests + whenIdle coverage; 100% per-file coverage; e2e boots the example as a subprocess and verifies a written file on disk (key-gated, with a no-key stdout-purity check).
66 lines
2.8 KiB
TypeScript
66 lines
2.8 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import type { TurnEndReason } from '@deepseek-ai/dsh-session'
|
|
import type { ContentBlock as AcpContentBlock } from '@agentclientprotocol/sdk'
|
|
import {
|
|
acpPromptToText,
|
|
harnessBlockToAcpContent,
|
|
promptHasUnsupportedContent,
|
|
turnEndToStopReason,
|
|
} from '../src/codec.ts'
|
|
|
|
describe('turnEndToStopReason', () => {
|
|
// The SDK rejects an unknown stopReason, so this must be total over every
|
|
// TurnEndReason kind and always produce a legal wire value.
|
|
it('maps every known TurnEndReason kind to a legal StopReason', () => {
|
|
expect(turnEndToStopReason({ kind: 'completed' })).toBe('end_turn')
|
|
expect(turnEndToStopReason({ kind: 'max-tokens' })).toBe('max_tokens')
|
|
expect(turnEndToStopReason({ kind: 'aborted', reason: 'x' })).toBe('cancelled')
|
|
expect(turnEndToStopReason({ kind: 'disposed' })).toBe('cancelled')
|
|
expect(turnEndToStopReason({ kind: 'error', message: 'boom' })).toBe('end_turn')
|
|
})
|
|
|
|
it('falls back to end_turn for an unknown (merge-extensible) future kind', () => {
|
|
// A plugin-added TurnEndReason variant the bridge does not yet know about
|
|
// must still produce a legal wire value, not throw into the SDK.
|
|
const future = { kind: 'refusal' } as unknown as TurnEndReason
|
|
expect(turnEndToStopReason(future)).toBe('end_turn')
|
|
})
|
|
})
|
|
|
|
describe('harnessBlockToAcpContent', () => {
|
|
it('maps a text block to ACP text content', () => {
|
|
expect(harnessBlockToAcpContent({ type: 'text', text: 'hi' })).toEqual({ type: 'text', text: 'hi' })
|
|
})
|
|
|
|
it('returns undefined for non-text blocks (reasoning/tool/image)', () => {
|
|
expect(harnessBlockToAcpContent({ type: 'reasoning', text: 'think' })).toBeUndefined()
|
|
expect(harnessBlockToAcpContent({ type: 'image', url: 'https://x/y.png', mimeType: 'image/png' })).toBeUndefined()
|
|
})
|
|
})
|
|
|
|
describe('acpPromptToText', () => {
|
|
it('concatenates text blocks and ignores non-text', () => {
|
|
const prompt: AcpContentBlock[] = [
|
|
{ type: 'text', text: 'hello ' },
|
|
{ type: 'resource_link', uri: 'file:///x', name: 'x' },
|
|
{ type: 'text', text: 'world' },
|
|
]
|
|
expect(acpPromptToText(prompt)).toBe('hello world')
|
|
})
|
|
|
|
it('returns empty string for a prompt with no text blocks', () => {
|
|
expect(acpPromptToText([{ type: 'resource_link', uri: 'file:///x', name: 'x' }])).toBe('')
|
|
})
|
|
})
|
|
|
|
describe('promptHasUnsupportedContent', () => {
|
|
it('detects image and audio blocks', () => {
|
|
expect(promptHasUnsupportedContent([{ type: 'image', mimeType: 'image/png', data: 'AA==' }])).toBe(true)
|
|
expect(promptHasUnsupportedContent([{ type: 'audio', mimeType: 'audio/wav', data: 'AA==' }])).toBe(true)
|
|
})
|
|
|
|
it('passes a text-only prompt', () => {
|
|
expect(promptHasUnsupportedContent([{ type: 'text', text: 'hi' }])).toBe(false)
|
|
})
|
|
})
|