Tianyi Cui 436305b1c2 fix review findings: correct teardown framing (dispose, not cancel+whenIdle) ...

Codex's second pass caught that the prior doc fix swapped one wrong primitive
for another: framing teardown as cancel()+whenIdle() (or awaiting
agent.whenIdle() on disposal) is still wrong. whenIdle() only OBSERVES
quiescence; cancel() only stops queued/in-flight work. Neither unregisters the
agent or detaches the session. Real teardown is AgentHandle.dispose(), whose
disposer does `stop(); await agent.done` — stop the loop, await its exit, and
unregister (packages/core/agent-loop/src/index.ts:271). Copying the old framing
would reintroduce the orphaned-agent/session leak the AgentHandle seam exists
to prevent.

- docs/architecture.md: whenIdle() is a non-owner quiescence-observation hook,
  explicitly NOT teardown; teardown is `await AgentHandle.dispose()`.
- docs/cookbook/extension-cookbook.md (prose + the ts comment): tear agents
  down via AgentHandle.dispose(), not agent.whenIdle().
- docs/rfc/proposed/feature/2026-06-14-acp-agent-client-protocol.md: the
  lifecycle/disposal paragraph routes teardown through the handle's dispose().

2026-06-21 09:37:52 +08:00

..

adding-a-package.md

Fix doc cross-links for the hierarchy; add package-path + shape gates

2026-06-20 23:12:14 +08:00

adding-a-tool.md

Fix doc cross-links for the hierarchy; add package-path + shape gates

2026-06-20 23:12:14 +08:00

adding-a-vendored-package.md

docs(rfc): classify RFCs by kind via path-encoded subdirectories

2026-06-20 22:29:45 +08:00

adding-an-llm-adapter.md

Fix doc cross-links for the hierarchy; add package-path + shape gates

2026-06-20 23:12:14 +08:00

extension-cookbook.md

fix review findings: correct teardown framing (dispose, not cancel+whenIdle)

2026-06-21 09:37:52 +08:00