mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
e2628442fa
Review follow-up on the residual the previous commit accepted — and the acceptance was wrong, because the fix is clean: in Code Mode the SDK section IS the soft surface (the wire carries only run_code), section text resolves in assemble's base, and renderToolsSdk is an exported pure renderer. The outermost wrapper therefore re-renders tools:sdk from the same visibility predicate the wire filter applies (allowlist, exit-IFF-plan, minus run_code mirroring the registry's own exclusion): a plan-mode program is documented exactly the callable bindings — read and the exit, never the denied write. The default mode leaves the section untouched (absence of policy), both pinned by tests. The soft layer's promise — the model is never encouraged toward a tool the gate denies — now holds in Code Mode too; the only remaining prompt-honesty residual is a prepend-after-load assemble listener, where the gate still covers execution.
mode/ — session-mode policy family
Session modes: named, logged, per-agent policy states, with plan mode as the first shipped definition. A single product package — there is no interface/implementation seam here, because a mode's variable parts are config values (allowlist, section text), not swappable implementations.
| Package | Role | ctx key |
|---|---|---|
mode/ |
mode/set vocabulary + fold, the ctx.modes service (list/get/set with the turn-boundary flush), the soft layer (assemble filter + mode:policy section), the hard layer (tools/pre-execute deny-by-default gate), and the model-facing exit_plan_mode review tool |
ctx.modes |
The mode in force is a pure function of the session log (SessionEventMap['mode/set'], last one wins), so resume and fork restore it with no extra machinery; the default mode is the absence of policy, keeping the plugin invisible until a mode is set. UIs read flips off session/event: the stdio app exposes /mode, the ACP bridge maps the vocabulary to the session-mode picker. RFC: plan mode.