mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
de9d618f0c
Review hardening (the finding's ordering premise did not hold — see the PR thread — but its failure-path kernel did): onBoundary cleared the pending intent BEFORE appending the mode/set, so a backend rejecting that one write lost the switch forever while the picker kept showing it optimistically. The intent is now cleared only after the append lands; a failed flush stays parked and the next healthy boundary converges the log with the picker. The containment test extends to pin the re-park and the retry. The bridge's re-notify keeps deriving from the logged event's value — now documented in place: the service holds ONE coalesced pending slot (every flush reads the latest selection, so a stale flush cannot exist), and for any other writer the logged value is the truth the picker should track, in log order.
mode/ — session-mode policy family
Session modes: named, logged, per-agent policy states, with plan mode as the first shipped definition. A single product package — there is no interface/implementation seam here, because a mode's variable parts are config values (allowlist, section text), not swappable implementations.
| Package | Role | ctx key |
|---|---|---|
mode/ |
mode/set vocabulary + fold, the ctx.modes service (list/get/set with the turn-boundary flush), the soft layer (assemble filter + mode:policy section), the hard layer (tools/pre-execute deny-by-default gate), and the model-facing exit_plan_mode review tool |
ctx.modes |
The mode in force is a pure function of the session log (SessionEventMap['mode/set'], last one wins), so resume and fork restore it with no extra machinery; the default mode is the absence of policy, keeping the plugin invisible until a mode is set. UIs read flips off session/event: the stdio app exposes /mode, the ACP bridge maps the vocabulary to the session-mode picker. RFC: plan mode.