mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
9db3ce7313
Codex review, with its own probes, showed the RFC overclaimed: the disable patch carried no name assertion despite the text crediting one, and an id rename is not fail-loud — the skipped patch's warning needs a logger the replay app deliberately lacks, and the resulting keyless adapter entry fails inside its fiber without reaching the unhandled-rejection guard (verified by a subprocess probe of the real installFailLoud + boot composition). The overlay now asserts name: dsh-llm-deepseek on the patch (a reused id can never disable the wrong plugin), and the RFC records the honest residual: an id rename degrades to config rot with replay output still correct (llm-replay owns the stream short-circuit), plus the insert-collision last-wins fact.
34 lines
1.8 KiB
YAML
34 lines
1.8 KiB
YAML
# Snapshot-test REPLAY overlay: the SAME app tree as cordis.yml, derived from
|
|
# it by an include — the one difference is the model backend. A keyless replay
|
|
# run cannot boot the real adapter (llm-deepseek's apply() throws without
|
|
# DEEPSEEK_API_KEY), so the include patches the live tree at load time: the
|
|
# llm-deepseek entry is disabled by id, and the llm-replay entry (which serves
|
|
# a recorded session JSONL — no API key, no network) is inserted. Every other
|
|
# entry — the app, the bash executor, the fs/subagent/todo tools, both hook
|
|
# bridges, the system prompt — IS the live tree, so replay exercises exactly
|
|
# what ships and an app-shape change lands once, in cordis.yml.
|
|
#
|
|
# The dsh-acp-agent bin selects this file for DSH_SNAPSHOT=replay. The replay
|
|
# fixture path comes from $DSH_SNAPSHOT_FILE (and an optional
|
|
# $DSH_SNAPSHOT_OVERRIDE sidecar), set by the snapshot harness. stdout stays
|
|
# reserved for the ACP JSON-RPC protocol (the app package loads no stdout
|
|
# logger). Patches apply when the include loads the file — a one-shot replay
|
|
# boot, so the load-time-only patch semantics are exactly enough.
|
|
- id: base
|
|
name: '@cordisjs/plugin-include'
|
|
config:
|
|
path: ./cordis.yml
|
|
patches:
|
|
# The name is an assertion, not an override: the include skips the patch
|
|
# (warning if a logger exists) when the id points at a different plugin,
|
|
# so this can never disable the wrong entry. If cordis.yml ever RENAMES
|
|
# the id, the patch degrades to a skip — replay output stays correct
|
|
# (llm-replay still short-circuits the stream) but the stale patch and a
|
|
# futile keyless adapter entry linger until review catches them.
|
|
- id: llm-deepseek
|
|
name: '@deepseek-ai/dsh-llm-deepseek'
|
|
disabled: true
|
|
- insert:
|
|
- id: llm-replay
|
|
name: '@deepseek-ai/dsh-llm-replay'
|