mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
Address the review bot's five genuinely-new findings on the current code: - disposal now discards any still-pending inbox items before the loop exits, so every enqueued id gets a terminal lifecycle event. - injection (next-step/no-wakeup) validates its payload up front, before opening the idle one-shot turn, honoring 'invalid input throws before any append'; and rejects attached contexts (which belong only to inbox messages) rather than silently dropping them. - agentMessage() freezes the agent/inbox/* payload so a listener cannot mutate the shared correlation object mid-dispatch. - refresh the package READMEs (compact, goal, guard, hook-protocol, plan-mode, time-context, workspace-context) that still referenced the removed context/message event, with the source-based user/message distinction. The up-front injection validation makes two finally branches unreachable (v8-ignored as the turn-enclosure backstop). Adds regression tests for disposal discard, context rejection, up-front validation, and the frozen payload; per-file coverage stays 100%.
140 lines
5.1 KiB
TypeScript
140 lines
5.1 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import { AgentMessageId } from '@deepseek-ai/dsh-agent'
|
|
import { Inbox, agentMessage } from '../src/inbox.ts'
|
|
|
|
function message(text: string) {
|
|
return { id: AgentMessageId(text), content: [{ type: 'text' as const, text }], source: { kind: 'user' as const }, contexts: [], wakeup: true }
|
|
}
|
|
|
|
describe('agentMessage', () => {
|
|
it('returns a frozen payload so a listener cannot mutate it for later listeners', () => {
|
|
const payload = agentMessage(message('m'), false)
|
|
expect(Object.isFrozen(payload)).toBe(true)
|
|
expect(() => { (payload as { id: string }).id = 'mutated' }).toThrow()
|
|
expect(payload.id).toBe(AgentMessageId('m'))
|
|
})
|
|
})
|
|
|
|
function resolverPair() {
|
|
let r!: () => void
|
|
const p = new Promise<void>((resolve) => { r = resolve })
|
|
return { promise: p, resolve: r }
|
|
}
|
|
|
|
describe('Inbox', () => {
|
|
it('dequeues one queued message at a time in FIFO order', () => {
|
|
const inbox = new Inbox()
|
|
inbox.enqueue(message('first'))
|
|
inbox.enqueue(message('second'))
|
|
expect(inbox.hasQueued).toBe(true)
|
|
|
|
expect(inbox.dequeueQueued()?.content[0]).toMatchObject({ text: 'first' })
|
|
expect(inbox.hasQueued).toBe(true)
|
|
expect(inbox.dequeueQueued()?.content[0]).toMatchObject({ text: 'second' })
|
|
expect(inbox.hasQueued).toBe(false)
|
|
expect(inbox.dequeueQueued()).toBeUndefined()
|
|
})
|
|
|
|
it('enqueue(msg, false) queues without waking a parked waiter', async () => {
|
|
const inbox = new Inbox()
|
|
let woke = false
|
|
const waiter = inbox.waitForQueued(new Promise(() => {})).then(() => { woke = true })
|
|
inbox.enqueue(message('quiet'), false)
|
|
// The item is queued, but the parked waiter was not resolved by it.
|
|
expect(inbox.hasQueued).toBe(true)
|
|
await Promise.resolve()
|
|
expect(woke).toBe(false)
|
|
// A later waking enqueue resolves the same waiter.
|
|
inbox.enqueue(message('loud'))
|
|
await waiter
|
|
expect(woke).toBe(true)
|
|
})
|
|
|
|
it('pending() snapshots queued then steering without removing them', () => {
|
|
const inbox = new Inbox()
|
|
inbox.enqueue(message('q'))
|
|
inbox.steer(message('s'))
|
|
const pending = inbox.pending()
|
|
expect(pending.map(p => p.steering)).toEqual([false, true])
|
|
// Snapshot does not drain the FIFOs.
|
|
expect(inbox.hasQueued).toBe(true)
|
|
expect(inbox.hasSteering).toBe(true)
|
|
})
|
|
|
|
it('pushes and drains steering messages separately from queued', () => {
|
|
const inbox = new Inbox()
|
|
inbox.steer(message('steer'))
|
|
expect(inbox.hasQueued).toBe(false)
|
|
expect(inbox.hasSteering).toBe(true)
|
|
|
|
const steering = inbox.drainSteering()
|
|
expect(steering).toHaveLength(1)
|
|
expect(inbox.hasSteering).toBe(false)
|
|
})
|
|
|
|
it('waitForQueued returns immediately when a queued message is already present', async () => {
|
|
const inbox = new Inbox()
|
|
inbox.enqueue(message('ready'))
|
|
|
|
const started = Date.now()
|
|
await inbox.waitForQueued(new Promise(() => {})) // never-resolving cancel
|
|
expect(Date.now() - started).toBeLessThan(50)
|
|
})
|
|
|
|
it('waitForQueued resolves when a message is enqueued', async () => {
|
|
const inbox = new Inbox()
|
|
const waiter = inbox.waitForQueued(new Promise(() => {})) // never-resolving cancel
|
|
// enqueue after starting the wait
|
|
setTimeout(() => { inbox.enqueue(message('wake')) }, 5)
|
|
await waiter
|
|
})
|
|
|
|
it('waitForQueued resolves when the cancel promise resolves', async () => {
|
|
const inbox = new Inbox()
|
|
const { promise, resolve } = resolverPair()
|
|
const waiter = inbox.waitForQueued(promise)
|
|
resolve()
|
|
await waiter
|
|
})
|
|
|
|
it('waitForQueued overwrites the previous wakeup callback (only the latest waiter is notified)', async () => {
|
|
const inbox = new Inbox()
|
|
const { promise: p1, resolve: r1 } = resolverPair()
|
|
|
|
void inbox.waitForQueued(new Promise(() => {})) // first call, never resolved
|
|
void inbox.waitForQueued(p1) // second call overwrites wakeup
|
|
|
|
// Cancelling the latest waiter clears the shared callback; enqueue must neither
|
|
// wake the stale waiter nor fail on the cleared callback.
|
|
r1()
|
|
await p1
|
|
|
|
inbox.enqueue(message('hey'))
|
|
})
|
|
|
|
it('clears wakeup in finally handler when enqueue resolves', async () => {
|
|
const inbox = new Inbox()
|
|
void inbox.waitForQueued(new Promise(() => {})) // never-resolving cancel
|
|
// The wakeup is set. Now trigger it via enqueue → wakeup() calls resolve,
|
|
// promise resolves, finally clears wakeup because wakeup === resolve.
|
|
inbox.enqueue(message('wake'))
|
|
// No explicit await needed — enqueue is synchronous, and the microtask
|
|
// (finally) runs. The key coverage hit is finally with wakeup === resolve.
|
|
})
|
|
|
|
it('finally handler does not clear wakeup when a different waiter overwrote it', async () => {
|
|
// A stale waiter's finally must not clear the replacement waiter.
|
|
const inbox = new Inbox()
|
|
const { promise: c1, resolve: r1 } = resolverPair()
|
|
|
|
void inbox.waitForQueued(c1) // wakeup = resolve1, c1.then(resolve1)
|
|
void inbox.waitForQueued(new Promise(() => {})) // wakeup = resolve2, cancel never resolves
|
|
|
|
r1()
|
|
await c1
|
|
|
|
// The replacement remains registered and is resolved by enqueue.
|
|
inbox.enqueue(message('hey'))
|
|
})
|
|
})
|