mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
2be60b9a22
The session event vocabulary carried two standalone trace-only events that
were not load-bearing as separate records. Fold their facts into nearby
load-bearing events and delete the standalone variants.
- Token usage now rides on `assistant/message` as an optional `usage` field —
the assembled model output and its accounting travel together. The loop folds
`assembler.usage` onto the append instead of emitting a separate `usage`
event.
- The max-tokens path is the no-data-loss host: a step cut off with usage but
EMPTY content (e.g. only a dropped tool call) previously emitted a standalone
`usage`; it now records an empty-content `assistant/message { content: [],
usage }`. `deriveMessages()` skips empty-content assistant messages, so the
usage host never injects a spurious content-less assistant turn into the
provider transcript. A step with neither content nor usage appends nothing.
- An operational error's step number now rides on `turn/end.reason` for
`kind: 'error'` (`{ kind: 'error', step, message, code? }`) — the durable
turn outcome ACP and resume already consume. `failTurn` sets the reason
directly (no separate session `error` event). `agent/error` + logging are
unchanged for live diagnostics.
- No format-version bump: pre-release, no persisted data, so per the format
policy there is nothing to migrate or reject (the RFC's "refresh the format
version" criterion over-reached). `version` stays 1.
- ACP fixtures + goldens re-recorded (keyless replay): dropped standalone
usage/error lines, usage folded onto assistant/message, error step on
turn/end.reason.
RFC moved proposed -> implemented with an implementation note recording the two
scope refinements.
68 lines
3.1 KiB
TypeScript
68 lines
3.1 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import type { TurnEndReason } from '@deepseek-ai/dsh-session'
|
|
import type { ContentBlock as AcpContentBlock } from '@agentclientprotocol/sdk'
|
|
import {
|
|
acpPromptToText,
|
|
harnessBlockToAcpContent,
|
|
promptHasUnsupportedContent,
|
|
turnEndToStopReason,
|
|
} from '../src/codec.ts'
|
|
|
|
describe('turnEndToStopReason', () => {
|
|
// The SDK rejects an unknown stopReason, so this must be total over every
|
|
// TurnEndReason kind and always produce a legal wire value.
|
|
it('maps every known TurnEndReason kind to a legal StopReason', () => {
|
|
expect(turnEndToStopReason({ kind: 'completed' })).toBe('end_turn')
|
|
expect(turnEndToStopReason({ kind: 'max-tokens' })).toBe('max_tokens')
|
|
expect(turnEndToStopReason({ kind: 'aborted', reason: 'x' })).toBe('cancelled')
|
|
expect(turnEndToStopReason({ kind: 'disposed' })).toBe('cancelled')
|
|
expect(turnEndToStopReason({ kind: 'error', step: 1, message: 'boom' })).toBe('end_turn')
|
|
})
|
|
|
|
it('falls back to end_turn for an unknown (merge-extensible) future kind', () => {
|
|
// A plugin-added TurnEndReason variant the bridge does not yet know about
|
|
// must still produce a legal wire value, not throw into the SDK.
|
|
const future = { kind: 'refusal' } as unknown as TurnEndReason
|
|
expect(turnEndToStopReason(future)).toBe('end_turn')
|
|
})
|
|
})
|
|
|
|
describe('harnessBlockToAcpContent', () => {
|
|
it('maps a text block to ACP text content', () => {
|
|
expect(harnessBlockToAcpContent({ type: 'text', text: 'hi' })).toEqual({ type: 'text', text: 'hi' })
|
|
})
|
|
|
|
it('returns undefined for non-text blocks (reasoning/tool/image)', () => {
|
|
expect(harnessBlockToAcpContent({ type: 'reasoning', text: 'think' })).toBeUndefined()
|
|
expect(harnessBlockToAcpContent({ type: 'image', url: 'https://x/y.png', mimeType: 'image/png' })).toBeUndefined()
|
|
})
|
|
})
|
|
|
|
describe('acpPromptToText', () => {
|
|
it('concatenates text blocks and renders resource links explicitly', () => {
|
|
const prompt: AcpContentBlock[] = [
|
|
{ type: 'text', text: 'hello ' },
|
|
{ type: 'resource_link', uri: 'file:///x', name: 'x' },
|
|
{ type: 'text', text: 'world' },
|
|
]
|
|
expect(acpPromptToText(prompt)).toBe('hello \n[resource_link name="x" uri="file:///x"]\nworld')
|
|
})
|
|
|
|
it('returns empty string for a prompt with no text blocks', () => {
|
|
expect(acpPromptToText([{ type: 'image', mimeType: 'image/png', data: 'AA==' }])).toBe('')
|
|
})
|
|
})
|
|
|
|
describe('promptHasUnsupportedContent', () => {
|
|
it('detects image, audio, and embedded resource blocks', () => {
|
|
expect(promptHasUnsupportedContent([{ type: 'image', mimeType: 'image/png', data: 'AA==' }])).toBe(true)
|
|
expect(promptHasUnsupportedContent([{ type: 'audio', mimeType: 'audio/wav', data: 'AA==' }])).toBe(true)
|
|
expect(promptHasUnsupportedContent([{ type: 'resource', resource: { uri: 'file:///x', text: 'x' } }])).toBe(true)
|
|
})
|
|
|
|
it('passes baseline text and resource_link prompt blocks', () => {
|
|
expect(promptHasUnsupportedContent([{ type: 'text', text: 'hi' }])).toBe(false)
|
|
expect(promptHasUnsupportedContent([{ type: 'resource_link', uri: 'file:///x', name: 'x' }])).toBe(false)
|
|
})
|
|
})
|