mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
e0f20088d8
Implements docs/rfc/implemented/feature/2026-07-09-bash-backed-grep-glob- discovery.md: model-facing glob/grep in a new @deepseek-ai/dsh-tool-fs-search package, executing fixed ripgrep templates through ctx.bash.resolve/run — not ctx.fs provider methods — so filesystem backends stay free of a search contract and sandboxed/remote executors substitute cleanly. The tools never call ctx.bash.start(); the tool layer owns quoting (one singleQuote safety boundary), rg --json parsing, ItemRetainer/TextRetainer retention, and the first tool-owned ctx.spillFiles.saveText() handoff (item-level retention the generic post-execute spill policy cannot recover). RFC amendments on the way to implemented/: a shared src/search-core.ts (the SEARCH_* vocabulary + bash-run/raw-spill/spill plumbing was byte-identical across both tools — the missed-extraction smell), and a snapshot-gap note: wiring the acp-agent tree changes the assembled prompt, so goldens need a keyed re-record; the spill notice text is pinned by unit tests instead and only the coding-agent example ships the tools for now.
51 lines
2.4 KiB
TypeScript
51 lines
2.4 KiB
TypeScript
/**
|
|
* Real-load-path guard for @deepseek-ai/dsh-tool-fs-search. `tool-fs-search` is
|
|
* a NAMESPACE plugin with `inject` — so a stray `export default apply` would
|
|
* make the cordis Loader's `unwrapExports` (`exports.default ?? exports`)
|
|
* collapse the module to the bare `apply` function, DROPPING `inject`. The
|
|
* plugin would then read `ctx.bash` without having injected it and throw
|
|
* `cannot get property … without inject` the moment it loads (postmortem 0001).
|
|
*
|
|
* A hand-built `ctx.plugin({ apply, inject })` mount CANNOT catch that — it
|
|
* bypasses `unwrapExports`. So this test unwraps the module through the REAL
|
|
* `Loader.prototype.unwrapExports` and mounts the result over a bash executor,
|
|
* exercising the exact path the Loader uses. Prove the guard bites: add
|
|
* `export default apply` to `src/index.ts`, watch this go red, revert.
|
|
*/
|
|
|
|
import { describe, expect, it } from 'vitest'
|
|
import { Context } from 'cordis'
|
|
import Loader from '@cordisjs/plugin-loader'
|
|
import SystemPrompt from '@deepseek-ai/dsh-system-prompt'
|
|
import ToolRegistry from '@deepseek-ai/dsh-tools'
|
|
import { LocalBashExecutor } from '@deepseek-ai/dsh-bash-local'
|
|
import * as toolFsSearch from '@deepseek-ai/dsh-tool-fs-search'
|
|
|
|
describe('dsh-tool-fs-search real-load-path guard', () => {
|
|
it('has no default export and keeps name/inject/Config through unwrapExports', () => {
|
|
expect('default' in toolFsSearch).toBe(false)
|
|
|
|
const loader = Object.create(Loader.prototype) as Loader
|
|
const unwrapped = loader.unwrapExports(toolFsSearch) as Record<string, unknown>
|
|
expect(unwrapped).toBe(toolFsSearch)
|
|
expect(unwrapped.name).toBe('tool-fs-search')
|
|
expect(unwrapped.inject).toEqual(['tools', 'systemPrompt', 'bash'])
|
|
expect(typeof unwrapped.Config).toBe('function')
|
|
expect(typeof unwrapped.apply).toBe('function')
|
|
})
|
|
|
|
it('boots over ctx.bash through the unwrapped module without an inject error', async () => {
|
|
const ctx = new Context()
|
|
await ctx.plugin(SystemPrompt)
|
|
await ctx.plugin(ToolRegistry)
|
|
await ctx.plugin(LocalBashExecutor, {})
|
|
|
|
const loader = Object.create(Loader.prototype) as Loader
|
|
const unwrapped = loader.unwrapExports(toolFsSearch) as Parameters<Context['plugin']>[0]
|
|
// A collapsed export shape (dropped inject) would throw "without inject" here.
|
|
const fiber = await ctx.plugin(unwrapped)
|
|
expect(ctx.tools.schemas().map(s => s.name)).toEqual(expect.arrayContaining(['glob', 'grep']))
|
|
await fiber.dispose()
|
|
})
|
|
})
|