mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
d6231007af
Both Workspace surfaces offered "Open local folder…" and "Create a new
workspace" for one outcome. The browse occupant already carries its own
New folder affordance, so picking a directory covered creating one; the
name dialog only added a second vocabulary and a create target the
operator could neither see nor choose.
The surviving entry is named after the outcome — "Add workspace…" — and a
menu now appears only where there is something to choose between: with no
Workspace listed (the add-only sidebar header, or an empty hero list) the
anchor gesture raises the directory flow directly instead of a one-row
popover. An empty list counts as final only after the list baseline lands,
and a composition with no directory-flow occupant hides the sidebar button
rather than offering a dead one.
WorkspaceCreateFlow becomes WorkspacePickFlow (createOnly -> addOnly) and
the injected createWorkspace narrows to { path }. The host's
workspace.create({ name }) branch and `dsh web --workspace-root` lost their
last product consumer; both are marked at the call site for a follow-up.
109 lines
5.1 KiB
TypeScript
109 lines
5.1 KiB
TypeScript
// Web e2e scenario: every visible permission picker gates Full access behind
|
||
// the same locale-aware, in-page risk confirmation. Zero model calls: the
|
||
// scenario boots the shipped Web composition and exercises the real
|
||
// permission projection, client command path, HTTP RPC, and pushed update.
|
||
import { mkdirSync } from 'node:fs'
|
||
import { fileURLToPath } from 'node:url'
|
||
import { join } from 'node:path'
|
||
import type { Browser, Page } from 'playwright'
|
||
import { chromium } from 'playwright'
|
||
import { afterAll, beforeAll, describe, expect, it, onTestFailed } from 'vitest'
|
||
import {
|
||
assertFixtureInventory, captureStableAria, compareOrRefreshGolden,
|
||
launchWebScaffold, watchConsole, webSnapshotMode, type WebScaffold,
|
||
} from './scaffold.ts'
|
||
import { saveFailureShot } from './support.ts'
|
||
|
||
/**
|
||
* connectFreshWorkspace twin over the product default Chinese locale (the
|
||
* shared helper's anchors assume the English page every other scenario
|
||
* boots; this scenario deliberately keeps zh, so the localized picker
|
||
* copy is the anchor set).
|
||
*/
|
||
async function connectFreshWorkspaceZh(page: Page, root: string, name = 'workspace'): Promise<void> {
|
||
mkdirSync(join(root, name), { recursive: true })
|
||
await page.getByRole('button', { name: '选择工作区' }).click()
|
||
const dialog = page.getByRole('dialog', { name: '选择工作区目录' })
|
||
await dialog.waitFor({ timeout: 10_000 })
|
||
await dialog.getByRole('button', { name: '编辑路径' }).click()
|
||
const pathInput = dialog.getByRole('textbox', { name: '编辑路径' })
|
||
await pathInput.fill(join(root, name))
|
||
await pathInput.press('Enter')
|
||
await dialog.getByRole('button', { name: '打开', exact: true }).click()
|
||
await page.locator('textarea:enabled[placeholder="描述你想要构建的内容"]')
|
||
.waitFor({ timeout: 15_000 })
|
||
}
|
||
|
||
const SNAPSHOT_DIR = fileURLToPath(new URL('./snapshots/access-confirmation', import.meta.url))
|
||
const UI_EXPECTED = join(SNAPSHOT_DIR, 'ui.expected.md')
|
||
const MODE = webSnapshotMode()
|
||
|
||
describe('web e2e: Full access confirmation', () => {
|
||
let scaffold: WebScaffold
|
||
let browser: Browser
|
||
let page: Page
|
||
let tripwire: ReturnType<typeof watchConsole>
|
||
|
||
beforeAll(async () => {
|
||
scaffold = await launchWebScaffold({})
|
||
// CI uses Playwright's pinned browser. A developer may point this one
|
||
// scenario at an installed Chromium when the matching browser download
|
||
// is temporarily unavailable.
|
||
const executablePath = process.env.DSH_PLAYWRIGHT_EXECUTABLE_PATH
|
||
browser = await chromium.launch(executablePath === undefined ? {} : { executablePath })
|
||
// Keep the product default Chinese locale: the golden pins the actual
|
||
// registered dictionary rather than a test-local translation callback.
|
||
page = await browser.newPage({ viewport: { width: 1680, height: 1000 } })
|
||
tripwire = watchConsole(page)
|
||
await page.goto(scaffold.baseUrl, { waitUntil: 'load' })
|
||
await page.waitForSelector('[class*="frame"]', { timeout: 30_000 })
|
||
await connectFreshWorkspaceZh(page, scaffold.workspaceCwd)
|
||
}, 120_000)
|
||
|
||
afterAll(async () => {
|
||
await browser?.close()
|
||
await scaffold?.close()
|
||
})
|
||
|
||
it('requires acknowledgement before the composer picker can enable Full access', async () => {
|
||
onTestFailed(() => saveFailureShot(page, 'web-e2e-full-access-confirmation'))
|
||
const access = page.locator('button[aria-label^="访问模式"]').first()
|
||
await access.waitFor({ timeout: 10_000 })
|
||
|
||
// Normalize the starting preset through the real command path. The
|
||
// shipped web config may already start at Full access.
|
||
if ((await access.getAttribute('aria-label'))?.endsWith('Full access') === true) {
|
||
await access.click()
|
||
await page.getByRole('menuitem', { name: 'Workspace Write' }).click()
|
||
await expect.poll(() => access.getAttribute('aria-label'), { timeout: 10_000 })
|
||
.toBe('访问模式，当前：Workspace Write')
|
||
}
|
||
|
||
await access.click()
|
||
await page.getByRole('menuitem', { name: 'Full access' }).click()
|
||
const dialog = page.getByRole('dialog', { name: '确认启用 Full access？' })
|
||
await dialog.waitFor({ timeout: 10_000 })
|
||
const enable = dialog.getByRole('button', { name: '启用 Full access' })
|
||
expect(await enable.isDisabled()).toBe(true)
|
||
|
||
// The modal is in this page's body (not a native/new window) and escapes
|
||
// the sticky composer's stacking context.
|
||
expect(await dialog.evaluate(node => node.parentElement?.parentElement === document.body)).toBe(true)
|
||
const snapshot = await captureStableAria(page, '[role="dialog"]', scaffold.workspaceCwd)
|
||
await compareOrRefreshGolden(UI_EXPECTED, snapshot, MODE)
|
||
|
||
await dialog.getByRole('checkbox', { name: '我已了解风险，并愿意继续' }).check()
|
||
expect(await enable.isEnabled()).toBe(true)
|
||
await enable.click()
|
||
await expect.poll(() => access.getAttribute('aria-label'), { timeout: 10_000 })
|
||
.toBe('访问模式，当前：Full access')
|
||
expect(await dialog.count()).toBe(0)
|
||
expect(tripwire.pageErrors).toEqual([])
|
||
}, 60_000)
|
||
|
||
it('keeps its snapshot inventory closed', async () => {
|
||
expect(tripwire.warnings).toEqual([])
|
||
await assertFixtureInventory(SNAPSHOT_DIR, ['ui.expected.md'])
|
||
})
|
||
})
|