mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
9f996be8e3
Five findings from the #939 review, each reproduced before being fixed. **Configuration reads are as privileged as writes.** `settings.describe` returns every exposed namespace's configuration and `credentials.describe` reports whether an arbitrary environment-variable name is configured and from where — reconnaissance no anonymous caller should have. Both join PRIVILEGED_METHODS, so the whole configuration plane is loopback-only until real authentication exists; `trustedHosts` was never authentication. The model catalog stays reachable: it carries no endpoints or key state, and a LAN client's model picker legitimately needs it. Asserted over a real HTTP server, because the Host header a browser actually sends is what decides this. **The proxy serves only namespaces a registered model provider addresses.** The settings seam is general — any plugin may register one — but the Web configuration plane is the model-provider surface. Without the gate, every future `settings.register()` would silently become remotely readable and writable configuration. An unregistered namespace and an unexposed one answer identically, so no caller can enumerate the registry one probe at a time. **Path-addressed writes replace the redacted-document rebuild.** The editor reads the REDACTED descriptor, so rebuilding a section from it and replacing wholesale deleted every literal secret the wire never returned — reproduced as `{baseURL, reasoning}` in, stored `apiKey` gone out. `settings.mutate` applies set/unset ops to the section as it stands at the front of the seam's write queue, and the client names only fields it can see, so an unseen secret is untouched by construction rather than by care. P2s in the same pass: `llm/adapters-updated` now contains async listener rejections (an uncontained one escaped as unhandledRejection, contradicting the documented "observer failures are contained"); llm-deepseek's retry-policy swap uses the atomic `registration.replace` instead of dispose-then-register, which published `[]` then `["deepseek-official"]` so an observer saw the provider disappear and come back; and a transport rejection no longer strands the page in `loading` or a card in `busy`, with removal failures surfaced on the page banner instead of swallowed.
69 lines
2.9 KiB
TypeScript
69 lines
2.9 KiB
TypeScript
/**
|
|
* settings domain zod schemas (names derived from map keys: settingsDescribeRequestSchema /
|
|
* settingsDescribeValueSchema / settingsUpdate* / settingsReplace*).
|
|
*/
|
|
|
|
import { z } from 'zod'
|
|
import type { RequestPayload, ResponseValue } from './rpc-map.ts'
|
|
import type { Wire } from './rpc.schema.ts'
|
|
import type { SettingsNamespaceView, SettingsPathOpView, SettingsSecretView } from './settings.ts'
|
|
|
|
/** One redacted secret slot. */
|
|
export const settingsSecretViewSchema = z.object({
|
|
path: z.array(z.string()),
|
|
set: z.boolean(),
|
|
}) satisfies z.ZodType<Wire<SettingsSecretView>>
|
|
|
|
/** SettingsNamespaceView row of settings.describe and the write responses. */
|
|
export const settingsNamespaceViewSchema = z.object({
|
|
ns: z.string().min(1),
|
|
schema: z.unknown(),
|
|
value: z.unknown(),
|
|
base: z.unknown().optional(),
|
|
user: z.unknown().optional(),
|
|
applies: z.union([z.literal('live'), z.literal('restart')]),
|
|
secrets: z.array(settingsSecretViewSchema),
|
|
}) satisfies z.ZodType<Wire<SettingsNamespaceView>>
|
|
|
|
/** settings.describe request payload. */
|
|
export const settingsDescribeRequestSchema = z.object({}) satisfies z.ZodType<Wire<RequestPayload<'settings.describe'>>>
|
|
|
|
/** settings.describe response value. */
|
|
export const settingsDescribeValueSchema = z.object({
|
|
writable: z.boolean(),
|
|
namespaces: z.array(settingsNamespaceViewSchema),
|
|
}) satisfies z.ZodType<Wire<ResponseValue<'settings.describe'>>>
|
|
|
|
/** settings.update request payload. */
|
|
export const settingsUpdateRequestSchema = z.object({
|
|
ns: z.string().min(1),
|
|
patch: z.record(z.string(), z.unknown()),
|
|
}) satisfies z.ZodType<Wire<RequestPayload<'settings.update'>>>
|
|
|
|
/** settings.update response value: the namespace's new redacted view. */
|
|
export const settingsUpdateValueSchema = settingsNamespaceViewSchema satisfies z.ZodType<Wire<ResponseValue<'settings.update'>>>
|
|
|
|
/** settings.replace request payload. */
|
|
export const settingsReplaceRequestSchema = z.object({
|
|
ns: z.string().min(1),
|
|
section: z.record(z.string(), z.unknown()),
|
|
}) satisfies z.ZodType<Wire<RequestPayload<'settings.replace'>>>
|
|
|
|
/** One path-addressed edit of settings.mutate. */
|
|
export const settingsPathOpSchema = z.discriminatedUnion('op', [
|
|
z.object({ op: z.literal('set'), path: z.array(z.string()), value: z.unknown() }),
|
|
z.object({ op: z.literal('unset'), path: z.array(z.string()) }),
|
|
]) as unknown as z.ZodType<Wire<SettingsPathOpView>>
|
|
|
|
/** settings.mutate request payload. */
|
|
export const settingsMutateRequestSchema = z.object({
|
|
ns: z.string().min(1),
|
|
ops: z.array(settingsPathOpSchema),
|
|
}) satisfies z.ZodType<Wire<RequestPayload<'settings.mutate'>>>
|
|
|
|
/** settings.mutate response value: the namespace's new redacted view. */
|
|
export const settingsMutateValueSchema = settingsNamespaceViewSchema satisfies z.ZodType<Wire<ResponseValue<'settings.mutate'>>>
|
|
|
|
/** settings.replace response value. */
|
|
export const settingsReplaceValueSchema = settingsNamespaceViewSchema satisfies z.ZodType<Wire<ResponseValue<'settings.replace'>>>
|