mirror of https://github.com/deepseek-ai/deepseek-harness synced 2026-08-15 21:04:50 +00:00

Files

Tianyi Cui 7c5133488a refactor(core): every registry register-method returns the exact effect disposer

The exact-disposer fix (5fbac8be B1) repaired agents.register but left the
same wrapper (return () => void dispose()) at seven sibling sites:
tools.register, tools.restrict, systemPrompt.section/tools/variable,
agents.setFactory, and subagents.registerProvider. A wrapper makes correct
composite usage unrepresentable — the exact disposer cannot be recovered, so
a generator effect yielding it leaves the inner effect disposing as a
CONCURRENT SIBLING on owner unload, silently reproducing B1's ordering
corruption. The exact disposer serves both usages (composite-nestable AND
fire-and-forget callable); all seven now return it, typed
() => Promise<void> | void, with the convention pinned by a discriminating
test: an async-link composite probe that passes with the exact disposer and
observes the sibling unregistration firing mid-drain with a wrapper.

Re-auditing also surfaced that B1 itself SHIPPED a full-lint failure: it
changed register()'s return type without updating cross-file consumers
(agent.spec.ts dispose() statements, tool-bash's disposer list), which the
staged-scoped pre-commit lint never saw — pnpm run lint was red at HEAD.
Those three sites and this change's own fallout are fixed together: tests
now await disposers (stronger — they observe the full unwind), sync
paths void them, and the two annotation sites carry the honest union type.
agents.register's README line had drifted the same way (B1 updated the
JSDoc, not the README) — all seven README signatures now match; services
catalog regenerated.

2026-07-09 13:05:44 +08:00

bash

Gate JSDoc completeness on every package export

2026-07-06 22:09:30 +08:00

bash-local

Gate JSDoc completeness on every package export

2026-07-06 22:09:30 +08:00

tool-bash

refactor(core): every registry register-method returns the exact effect disposer

2026-07-09 13:05:44 +08:00

README.md

Document the package hierarchy and finalize the RFC

2026-06-20 23:25:33 +08:00

README.md

bash/ — bash capability family

The canonical three-package capability seam (see capability seams): an abstract executor interface, a concrete local implementation, and the model-facing tool that consumes it. All product packages.

Package	Role	ctx key
`bash/`	Abstract bash executor seam (interface + vocabulary)	`ctx.bash`
`bash-local/`	Local-subprocess `BashExecutor` implementation	(registers `ctx.bash`)
`tool-bash/`	Model-facing `bash`/`bash_output`/`bash_kill` tool schemas	(registers on `ctx.tools`)

The interface lives at bash/bash/. A sandboxed executor would replace bash-local without touching the interface or the tool — the split is what makes that possible.