mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
7a2dff8b11
Four ds-review-bot findings: - examples/tui-agent composed dsh-mode without the now-required modes.plan.section, so the TUI leaf failed at Loader startup (the keyless smoke only asserts the banner and missed it); graft the same deployment plan instructions the ACP leaf carries. - The prompt-submit and turn-continuation flushes ran before next(), so a session/set_mode arriving while a downstream async listener (the shipped hooks listeners' shape) awaited applied one request late; both listeners now prepend and flush after next(), matching the request-error wrapper, with a regression test pinning the ordering. - An HMR unload during the exit_plan_mode review let a later approval write into the disposed service and claim an exit whose flush could never land; the execute path now checks the fiber lifetime after the await and fails the call (the mode stays plan; the model re-presents). - resolveConfig accepted empty/untrimmed mode names that list()/ACP then advertised while the package invariant rejected their selection, desynchronizing the picker; names are validated non-empty and trimmed at load, the same shape the invariant enforces.