mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
efee449cfe
A crash can leave a durable log whose final turn never closed. The old
behavior truncated everything after the last turn/end as a "crash tail".
But a single turn can be HUGE in a long-horizon task (many steps, large
tool output), so truncating it silently destroys real, durably-written
work — truncating a turn is wrong.
New crash recovery (ADR 0018): load() PRESERVES the interrupted turn's
events and CLOSES the orphaned turn by durably appending synthetic
boundary events — a step/end if a step was open, then a turn/end carrying
the new merge-extensible TurnEndReason {kind:'interrupted'}. load()
returns the balanced log, so a resumed session is immediately usable. Only
a never-fully-written TORN tail fragment is discarded; corruption in the
committed region is still unloadable.
- dsh-session: TurnEndReason {kind:'interrupted'} + shared
interruptedTurnClosers() repair helper.
- JSONL backend: scanLog preserves the longest contiguous prefix
(including a partial final turn); loadCore truncates a torn fragment and
durably writes the closers, returning the balanced log.
- runPersistenceContract gains a crash-recovery test (both backends + mock).
- Docs: ADR 0018/0017, architecture.md, package READMEs.
Also (review #33): RFC 013 records the "move event vocabulary to Zod"
question (merge-extensible maps → runtime schema registry) + blast radius;
deferred, not done here.
1.9 KiB
1.9 KiB
RFCs
Proposals for substantial future work — reviewed before implementation, unlike ADRs (which record decisions already made). Each RFC groups a related set of ideas from the quality/robustness proposal (2026-06-11); statuses move proposed → accepted → implemented (then usually graduate to an ADR).
| # | Title | Status |
|---|---|---|
| 001 | Property-based testing for protocol-shaped code | implemented |
| 002 | Mutation testing as the coverage counterweight | proposed |
| 003 | Deterministic tests + replay invariant fixture + race stress | proposed |
| 004 | Architectural rules: dependency-cruiser, adapter conformance kit | proposed |
| 005 | Runtime arg validation, structured error taxonomy, dev-mode invariants | implemented |
| 006 | Doc-sync enforcement and API extractor reports | implemented (pts 1-2; pt 3 deferred) |
| 007 | Supply chain checks and vendor drift verification | proposed |
| 008 | Deep-readonly public surfaces | implemented (revised) |
| 009 | Durable session persistence — abstract, append-only, event-based store | proposed |
| 010 | Agent Client Protocol (ACP) support for external editors | proposed |
| 011 | Multiplex concurrent ACP sessions over one connection | proposed |
| 012 | Optional Code Mode — model writes TypeScript against an SDK of all tools | proposed |
| 013 | Runtime schemas for the event vocabulary (Zod vs the merge-extensible-map pattern) | proposed |