mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
64ce7caedc
Resolve the inline review feedback on PR #18 (all verified against the codebase, the published @agentclientprotocol/sdk@0.25.1 tarball, and Cordis fiber semantics): - 009: dsh-session owns SessionMeta (persistence re-exports) to avoid a package cycle; split mutable summary into a sidecar so the event log stays append-only and list/load can return it; pick one load-repair rule (resume from the last complete turn/end, overwrite the orphan). - 010: SDK has a zod peer dep + runtime zod/v4 import (drop "zero runtime deps"); session/new needs a create seam taking {sessionId, meta}; propose an abstract create/resume factory on dsh-agent so the bridge depends on the interface not the loop, and observe agent/status for quiescence since agent.done is LoopAgent-only; add the explicit TurnEndReason -> ACP StopReason wire mapping + test; reject non-empty additionalDirectories for the MVP; remove the EOF blank line. - 011: ctx.extend() does not create a disposable fiber — use a real per-session disposer scope.