imccyu 507dd25a3a fix(storage,workspace): review-bot findings — emit isolation, domain ownership, null globals ...

- domain/changed emission is isolated from the write path: an observer
  throwing synchronously can no longer turn a committed (durable +
  in-memory) write into a rejection; the failure is logged and later
  writes proceed.
- Domain lifecycle belongs to the opening consumer: Domain gains an
  idempotent close() (drain, unit close, reservation release), the
  facility stops registering effects on its own context and instead
  closes any still-open domains on unmount; WorkspaceRegistry holds its
  domain through its own effect, so disposing and re-mounting the
  consumer no longer wedges on already-open.
- defineDomain rejects a global schema accepting null at declaration
  time: JSON null is the medium's absence sentinel, so a nullable global
  could never round-trip; failing loud at the spec keeps set(null)
  unrepresentable.

Regression tests cover all three (hostile listener, close/reopen and
consumer re-mount, nullable-global rejection).

2026-07-25 11:08:04 +08:00

..

domain.ts

fix(storage,workspace): review-bot findings — emit isolation, domain ownership, null globals

2026-07-25 11:08:04 +08:00

error.ts

feat(storage): domain data form — typed schemas over opaque KV units

2026-07-25 11:08:04 +08:00

events.ts

fix(storage,workspace): post-review hardening

2026-07-25 11:08:04 +08:00

index.ts

fix(storage,workspace): review-bot findings — emit isolation, domain ownership, null globals

2026-07-25 11:08:04 +08:00

invariant.ts

fix(storage,workspace): post-review hardening

2026-07-25 11:08:04 +08:00

spec.ts

fix(storage,workspace): review-bot findings — emit isolation, domain ownership, null globals

2026-07-25 11:08:04 +08:00