mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
1b0ea07bce
The definitive slot model for the web client, replacing the first-generation
define/register two-step, ScopedSlots whitelist faces, and binding handles:
- 'root' is the only a-priori slot (SlotsService built-in); the shell renders
exactly ctx.slots.renderSlot('root', {}).
- register is the single API: children = slot declaration + render
authorization + runtime spec in one options object; misconfiguration fails
loud at load (duplicate declaration, undeclared contribution, one store
handle under two scopes).
- Component props arrive in four auto-derived shares: PropsRuntime<K>
(owner params + session/global standard kits via declare-merge),
PropsRenderSlots<S>, PropsStore<H>, and the inject business face.
sessionId is framework-supplied; hooks are framework-made only.
- Framework store seat: defineStore factories declare schema/actions/persist;
read = useStore, write = baked actions only; store scope derives from the
mounting entry; per-session persist keys and clearPersisted lifecycle.
- inject factories read the apply closure's own ctx (binding handles retired;
root-ctx back door closed); SessionProvider is self-wired render-prop.
- Rendering sits behind the SlotRenderer install seam; runtime stays
React-free; ownership ledger keyed to the single entry axis closes the
stale-authority window (StaleAuthorizationError probes).
Docs: the slot type-chain note is refreshed in place as the slot system
standard RFC (bilingual pair re-recorded); the web client architecture RFC
defers its slot sections there; packages/client/AGENTS.md gains the slot and
props discipline; gui-testing/web-styling notes drop missions/ references.
Tests: suites rewritten to the standard (props fed directly, real store
engines via createXXXStore().create(), no render machinery); load-time
negative samples for declaration/authorization/store conflicts; verified by
real-host playwright run (three columns, empty state, collapse, keyed session
remount, cross-slot selection sharing).
docs(ui-sidebar): point contract reference at the committed slot standard RFC
missions/ is workspace-local and never committed; the README must not cite it.
74 lines
3.5 KiB
TypeScript
74 lines
3.5 KiB
TypeScript
// @vitest-environment jsdom
|
|
// Client apply wiring under the terminal register form: ctx.layout provided,
|
|
// ONE register() call declares the four child slots + seats the store factory
|
|
// + wires the panel actions through the inject hook; teardown cascades
|
|
// (service unprovided + declarations gone + registration cleared). Node half
|
|
// and the invariant companion ride along — one-line surfaces the aggregate
|
|
// coverage gate still requires exercised.
|
|
|
|
import { Context } from 'cordis'
|
|
import { describe, expect, it, vi } from 'vitest'
|
|
import { SlotsService } from '@deepseek-ai/dsh-client-runtime/client'
|
|
import { apply, inject, LayoutService } from '@deepseek-ai/dsh-client-ui-layout/client'
|
|
import { apply as nodeApply } from '@deepseek-ai/dsh-client-ui-layout'
|
|
import * as invariant from '@deepseek-ai/dsh-client-ui-layout/invariant'
|
|
|
|
async function bench() {
|
|
const ctx = new Context()
|
|
const slotsFiber = ctx.plugin(SlotsService)
|
|
await slotsFiber.await()
|
|
return { ctx, slots: ctx.get('slots') as SlotsService }
|
|
}
|
|
|
|
describe('ui-layout client apply', () => {
|
|
it('declares its service dependencies', () => {
|
|
expect(inject).toContain('slots')
|
|
})
|
|
|
|
it('provides ctx.layout and registers AppFrame into root with the four child declarations', async () => {
|
|
const { ctx, slots } = await bench()
|
|
const fiber = ctx.plugin({ inject: ['slots'], apply })
|
|
await fiber.await()
|
|
expect(ctx.get('layout')).toBeInstanceOf(LayoutService)
|
|
// The one register() call occupied 'root'…
|
|
expect(slots.entries('root')).toHaveLength(1)
|
|
// …and declared the four children in the ledger.
|
|
expect(slots.spec('sidebar')).toEqual({ kind: 'single', scope: 'root' })
|
|
expect(slots.spec('conversation')).toEqual({ kind: 'single', scope: 'session' })
|
|
expect(slots.spec('details')).toEqual({ kind: 'single', scope: 'session' })
|
|
expect(slots.spec('conversation.empty')).toEqual({ kind: 'single', scope: 'root' })
|
|
})
|
|
|
|
it('teardown unwinds the service, the root registration, and the child declarations', async () => {
|
|
const { ctx, slots } = await bench()
|
|
const fiber = ctx.plugin({ inject: ['slots'], apply })
|
|
await fiber.await()
|
|
await fiber.dispose()
|
|
expect(ctx.get('layout')).toBeUndefined()
|
|
expect(slots.entries('root')).toHaveLength(0)
|
|
expect(slots.spec('sidebar')).toBeUndefined()
|
|
expect(slots.spec('conversation.empty')).toBeUndefined()
|
|
// The built-in root declaration survives entry teardown (runtime-owned).
|
|
expect(slots.spec('root')).toEqual({ kind: 'single', scope: 'root' })
|
|
})
|
|
})
|
|
|
|
describe('node half + invariant companion', () => {
|
|
it('node apply is an intentional no-op (loader-managed lifecycle only)', () => {
|
|
nodeApply()
|
|
expect(true).toBe(true) // reaching here without throw is the contract
|
|
})
|
|
|
|
it('invariant companion registers under the package name', async () => {
|
|
const register = vi.fn().mockReturnValue(() => {})
|
|
const ctx = { invariants: { register } } as never
|
|
// The /invariant subpath types live in lib/types (build product); assert
|
|
// the surface so the call stays typed where lint runs without a build.
|
|
const dispose = await (invariant as { apply: (ctx: never) => Promise<() => void> }).apply(ctx)
|
|
expect(register).toHaveBeenCalledWith('@deepseek-ai/dsh-client-ui-layout', expect.any(Function))
|
|
// The installer is the declared no-op — calling it must not throw.
|
|
expect(() => { (register.mock.calls[0]![1] as (c: never) => void)(undefined as never) }).not.toThrow()
|
|
expect(dispose).toBeTypeOf('function')
|
|
})
|
|
})
|