mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
A Codex review pass on the draft caught four real gaps and two solid suggestions; all addressed except one pushed back on the merits: - hooks-claude/hooks-codex: stderrSummaryMaxChars was the one new knob with NO range validation — a negative/NaN cap would silently misbehave inside slice(). Both bridges now assert a positive integer at the TOP of apply() (before the config-file parse's early return, so a bad value fails the load loudly), with rejection tests. - tool-fs: the read caps count lines/chars/bytes, so positive-FINITE was too loose (a fractional readLimit would flow into windowing arithmetic and the schema description). All four now require a positive integer, matching tool-web's cap. - Doc drift the gates cannot catch: tool-web's README tools table still named WEB_SEARCH_MAX_RESULTS as the mechanism; compact-basic's README/module doc and the compaction-capability-seam RFC still described estimation as fixed char/4 rather than the charsPerToken default. - subagent-acp: the dispose graces were tested only at the startAcpRun level, so a regression that stopped threading plugin config into AcpRunSpec would have survived. A provider-path test now drives the trap-escalation scenario through ctx.subagents.start with small config graces and bounds dispose at 4s. Pushed back on: converting compact-basic's charsPerToken to a schemastery field. The package's whole config is deliberately hand-rolled (resolveConfig, every threshold REQUIRED with no default — a documented design posture); one schemastery field beside it would be incoherent. The knob is cordis.yml-reachable, defaulted, and validated, which is what the convention requires; migrating the package to schemastery wholesale is pre-existing config-surface hygiene out of this change's scope.
93 lines
4.2 KiB
TypeScript
93 lines
4.2 KiB
TypeScript
/**
|
|
* The model-facing filesystem tool suite (`read`, `write`, `edit`) over the
|
|
* `ctx.fs` provider seam. This single plugin registers all three tools.
|
|
*
|
|
* ## The tool is the executor; policy is an event gate
|
|
*
|
|
* The tool reads/writes/edits through `ctx.fs` DIRECTLY and owns model-facing
|
|
* concerns only — tool names, JSON schemas, argument validation, prompt
|
|
* sections, read windowing, result formatting. It does NOT inject a policy
|
|
* service. Instead, on each write/edit it dispatches a single-slot waterfall
|
|
* (`fs/write-intent`/`fs/edit-intent`) to obtain the OPTIONAL version guard, and
|
|
* after every read/write/edit it emits `fs/observed` with a plain (unguarded)
|
|
* `ctx.emit`. A policy plugin (`@deepseek-ai/dsh-fs-policy`) occupies the
|
|
* decision slot and listens for `fs/observed` to add observed-state +
|
|
* read-before-edit + version-guarded write/edit; a deployment that loads these
|
|
* tools is expected to also load it. With no policy plugin the waterfalls fall
|
|
* through to their `undefined` default (the unconstrained bare provider) and
|
|
* `fs/observed` is unheard — the tool still functions. This package never
|
|
* imports `node:fs`, `node:path`, or an `@deepseek-ai/dsh-fs-local`
|
|
* implementation.
|
|
*
|
|
* @module @deepseek-ai/dsh-tool-fs
|
|
*/
|
|
|
|
import type { Context } from 'cordis'
|
|
import z from 'schemastery'
|
|
import { applyReadTool, READ_LIMIT, STREAM_MIN_SIZE } from './read.ts'
|
|
import { applyWriteTool } from './write.ts'
|
|
import { applyEditTool } from './edit.ts'
|
|
import { READ_MAX_BYTES, READ_MAX_LINE_LENGTH } from './read-render.ts'
|
|
|
|
export { READ_LIMIT, STREAM_MIN_SIZE, applyReadTool, parseReadArgs } from './read.ts'
|
|
export type { ReadToolCaps } from './read.ts'
|
|
export { applyWriteTool, formatWriteOutput, parseWriteArgs } from './write.ts'
|
|
export { applyEditTool, formatEditOutput, parseEditArgs } from './edit.ts'
|
|
export { READ_MAX_BYTES, READ_MAX_LINE_LENGTH, buildWindow, formatReadOutput } from './read-render.ts'
|
|
export type { FileReadOutcome, FileTextLine, ReadWindow, WindowResult } from './read-render.ts'
|
|
export { DIFF_CONTEXT, computeHunkDiffs, diffsFromMeta } from './diff.ts'
|
|
export type { FsDiffMeta } from './diff.ts'
|
|
|
|
/** Cordis plugin name used by loader diagnostics. */
|
|
export const name = 'tool-fs'
|
|
|
|
/** Services required by the filesystem tool suite. */
|
|
export const inject = ['tools', 'fs', 'systemPrompt']
|
|
|
|
/** Plugin config (all optional — `Config` supplies the defaults). */
|
|
export interface Config {
|
|
/** Default and maximum number of lines returned by one `read` call. */
|
|
readLimit?: number
|
|
/** Maximum characters returned for a single line before truncation. */
|
|
readMaxLineLength?: number
|
|
/** Maximum bytes returned for the selected lines of one `read` call. */
|
|
readMaxBytes?: number
|
|
/** Files at or above this size stream instead of loading whole into memory. */
|
|
readStreamMinSize?: number
|
|
}
|
|
|
|
export const Config: z<Config> = z.object({
|
|
readLimit: z.number().default(READ_LIMIT),
|
|
readMaxLineLength: z.number().default(READ_MAX_LINE_LENGTH),
|
|
readMaxBytes: z.number().default(READ_MAX_BYTES),
|
|
readStreamMinSize: z.number().default(STREAM_MIN_SIZE),
|
|
})
|
|
|
|
/** The shape after schemastery applied the defaults. */
|
|
type ResolvedConfig = Required<Config>
|
|
|
|
/** Every read cap counts lines/chars/bytes — a positive integer, or windowing arithmetic misbehaves silently. */
|
|
function assertPositiveInteger(name: string, value: number): void {
|
|
if (!Number.isInteger(value) || value < 1) {
|
|
throw new Error(`tool-fs: ${name} must be a positive integer`)
|
|
}
|
|
}
|
|
|
|
/** Register the full `read`/`write`/`edit` filesystem tool suite. */
|
|
export function apply(ctx: Context, config: Config): void {
|
|
// schemastery (Config) has already filled every defaulted field.
|
|
const resolved = config as ResolvedConfig
|
|
assertPositiveInteger('readLimit', resolved.readLimit)
|
|
assertPositiveInteger('readMaxLineLength', resolved.readMaxLineLength)
|
|
assertPositiveInteger('readMaxBytes', resolved.readMaxBytes)
|
|
assertPositiveInteger('readStreamMinSize', resolved.readStreamMinSize)
|
|
applyReadTool(ctx, {
|
|
limit: resolved.readLimit,
|
|
maxLineLength: resolved.readMaxLineLength,
|
|
maxBytes: resolved.readMaxBytes,
|
|
streamMinSize: resolved.readStreamMinSize,
|
|
})
|
|
applyWriteTool(ctx)
|
|
applyEditTool(ctx)
|
|
}
|