mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
37576ade6a
The loop passed the authoritative call.id into ctx.tools.execute() but then appended tool/result using result.callId — the value a tools/execute waterfall listener returns — with no check. A listener returning a mismatched id silently recorded the result under the wrong call. callId is the model-transcript correlation id: deriveMessages() turns it into the tool-result block's toolCallId, which must pair with the assistant tool-call block; a wrong id orphans that pairing in the next model request. Append tool/result with callId: call.id (the loop's authoritative id). A listener-internal id, if ever worth keeping, belongs in a separate diagnostic field — never overloaded onto callId. Test: a tools/execute listener returns a wrong callId; assert the logged tool/result.callId equals call.id AND deriveMessages() yields a tool-result block whose toolCallId equals call.id (not the wrong returned id). Verified the test fails on the pre-fix result.callId behavior.